Uh oh!
There was an error while loading. Please reload this page.
Backport "HBASE-26782 Minor code cleanup in and around RpcExecutor" to branch-2 - #4173
Conversation
Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
ndimiduk
commented
Mar 7, 2022
@stoty can you confirm that this change is not problematic for Phoenix? |
stoty
commented
Mar 7, 2022
Technically, Phoenix doesn't support branch-2, only branch-2.[1..4] |
Apache-HBase
commented
Mar 7, 2022
🎊 +1 overall
This message was automatically generated. |
stoty
commented
Mar 7, 2022
Interesting. For branch-2.4 we're compiling phoenix with Hbase 2.4.1, so we don't see the difference at compile time. For 2.5 and later, we're going to have to rename our internal dispatch() method, and add a dispatch() wrapper to the compatibility shim that handles the API differences betweeen the HBase versions, instead of overriding it as we do now. All in all, Phoenix can handle the API change in HBase 2.5+ . |
ndimiduk
commented
Mar 7, 2022
Is that for just this change to RpcExecutor, or are you looking at changes to RpcScheduler#dispatch ? Thanks @stoty . |
stoty
commented
Mar 7, 2022
I've only looked at RPCExecutor#dispatch() . |
stoty
commented
Mar 7, 2022
But RpcScheduler#dispatch can be handled the same way. |
ndimiduk
commented
Mar 8, 2022
I wouldn't want to make any interface compatibility changes to IA.LimitedPrivate classes on a patch release, only minor release. Thank again @stoty for taking the time! |
Apache-HBase
commented
Mar 8, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 8, 2022
🎊 +1 overall
This message was automatically generated. |
ndimiduk
commented
Mar 9, 2022
Okay, so here's a problem that confused me through this. |
Signed-off-by: Bharath Vissapragada bharathv@apache.org
Signed-off-by: Duo Zhang zhangduo@apache.org