HBASE-26804 Missing opentelemetry agent in hadoop-two-compat.xml

[taklwu]

No description provided.

[taklwu]

see the original commit in master here 8d2a0ef and this PR is porting the change in hadoop-three-compat.xml to hadoop-two-compat.xml

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 55s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		8m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4185
Optional Tests	dupname asflicense javac xml
uname	Linux 210756ce7a3a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 98836fb
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	45 (vs. ulimit of 12500)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 51s	branch-2 passed
+1 💚	javadoc	0m 17s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 19s	the patch passed
+1 💚	javadoc	0m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 14s	hbase-assembly in the patch passed.
		8m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4185
Optional Tests	javac javadoc unit
uname	Linux daecaf97109c 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 98836fb
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/testReport/
Max. process+thread count	44 (vs. ulimit of 12500)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 23s	branch-2 passed
+1 💚	javadoc	0m 13s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 13s	the patch passed
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 21s	hbase-assembly in the patch passed.
		9m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4185
Optional Tests	javac javadoc unit
uname	Linux b5a4072a3d72 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 98836fb
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/testReport/
Max. process+thread count	59 (vs. ulimit of 12500)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4185/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[ndimiduk]

Looks right to me. I don't have a simple means of testing it, can I assume you've got that covered, @taklwu ?

[taklwu]

I had an internal runtime was using hadoop2 build client and bin. But for this PR, I checked if the jar exists within the tar.gz that should be proving the agent has been included as part of the classpath.

# build the assembly tar bar with the default hadoop2 profile
% mvn clean install -DskipTests -Dcheckstyle.skip=true site assembly:single -Prelease
# go into the assembly output directory
$ cd hbase-assembly/target
% pwd
/Users/taklwu/workspace/hbase2/hbase-assembly/target
# unzip the tar bin and client ball
% tar -zxvf hbase-2.6.0-SNAPSHOT-bin.tar.gz
% tar -zxvf hbase-2.6.0-SNAPSHOT-client-bin.tar.gz
# verify the client exists
% ls -l hbase-2.6.0-SNAPSHOT/lib/trace/opentelemetry-javaagent-1.0.1-all.jar
-rw-r--r-- 1 taklwu staff 26478003 Jan 22 2020 hbase-2.6.0-SNAPSHOT/lib/trace/opentelemetry-javaagent-1.0.1-all.jar
% ls -l hbase-2.6.0-SNAPSHOT-client/lib/trace/*
-rw-r--r-- 1 taklwu staff 26478003 Jan 22 2020 hbase-2.6.0-SNAPSHOT-client/lib/trace/opentelemetry-javaagent-1.0.1-all.jar