HBASE-26832 Check epoch in AsyncFSWAL#syncCompleted, to avoid repeated release of flushed wal entries by sunhelly · Pull Request #4190 · apache/hbase

sunhelly · 2022-03-09T14:49:32Z

No description provided.

Apache-HBase · 2022-03-09T16:02:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 52s	master passed
+1 💚	compile	2m 57s	master passed
+1 💚	checkstyle	0m 52s	master passed
+1 💚	spotbugs	1m 59s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	3m 5s	the patch passed
+1 💚	javac	3m 5s	the patch passed
+1 💚	checkstyle	0m 49s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 9s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 58s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		43m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4190
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d56da9f46ff9 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1047194`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-09T20:53:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 43s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	4m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 33s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	4m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
-1 ❌	unit	313m 10s	hbase-server in the patch failed.
		334m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4190
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 81e73202d343 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1047194`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/testReport/
Max. process+thread count	2387 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-09T21:23:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 6s	master passed
+1 💚	compile	0m 42s	master passed
+1 💚	shadedjars	4m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	4m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	344m 14s	hbase-server in the patch failed.
		364m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4190
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 756dfcf8b9b2 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1047194`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/testReport/
Max. process+thread count	3042 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-03-11T06:34:19Z

The PR is for another issue?

…d release of flushed wal entries

sunhelly · 2022-03-14T08:14:59Z

The PR is for another issue?

Thanks, @Apache9 , I have changed the PR issue.

Apache-HBase · 2022-03-14T08:21:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 0s	Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem	Report/Notes
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T08:34:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	6m 11s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	checkstyle	0m 35s	master passed
+1 💚	spotbugs	1m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 37s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotbugs	1m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		13m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4190
Optional Tests	dupname asflicense javac spotbugs checkstyle compile
uname	Linux 47d91c3964be 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a49d147`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	57 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T10:55:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 48s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 57s	the patch passed
+1 💚	compile	0m 48s	the patch passed
+1 💚	javac	0m 48s	the patch passed
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
-1 ❌	unit	143m 4s	hbase-server in the patch failed.
		154m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4190
Optional Tests	javac javadoc unit compile
uname	Linux 70012f3d7c1a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a49d147`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/2/testReport/
Max. process+thread count	2345 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4190/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-03-26T10:42:01Z

Use consumeLock is a bit expensive in normal write path.

Let me see if we could fix it by checking whether we have the same writer instance, as described on the jira issue.

sunhelly · 2022-03-27T03:08:15Z

Use consumeLock is a bit expensive in normal write path.
Let me see if we could fix it by checking whether we have the same writer instance, as described on the jira issue.

OK, thanks, @Apache9 , looking forward to it.

sunhelly requested a review from Apache9 March 10, 2022 03:42

HBASE-26832 Check epoch in AsyncFSWAL#syncCompleted, to avoid repeate…
01c8201
…d release of flushed wal entries

sunhelly force-pushed the HBASE-22761 branch from 5709d49 to 01c8201Compare March 14, 2022 08:13

sunhelly changed the title ~~HBASE-22761 Caught ArrayIndexOutOfBoundsException while processing ev…~~HBASE-26832 Check epoch in AsyncFSWAL#syncCompleted, to avoid repeated release of flushed wal entriesMar 14, 2022

sunhelly closed this Mar 27, 2022

Navigation Menu

Uh oh!

HBASE-26832 Check epoch in AsyncFSWAL#syncCompleted, to avoid repeated release of flushed wal entries - #4190

HBASE-26832 Check epoch in AsyncFSWAL#syncCompleted, to avoid repeated release of flushed wal entries#4190
sunhelly wants to merge 1 commit into
apache:masterfrom
sunhelly:HBASE-22761

sunhelly commented Mar 9, 2022•
edited
Loading

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache9 commented Mar 11, 2022

Uh oh!

sunhelly commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache9 commented Mar 26, 2022

Uh oh!

sunhelly commented Mar 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sunhelly commented Mar 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache9 commented Mar 11, 2022

Uh oh!

sunhelly commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache9 commented Mar 26, 2022

Uh oh!

sunhelly commented Mar 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sunhelly commented Mar 9, 2022•
edited
Loading