Skip to content

HBASE-26813 Remove javax.ws.rs-api dependency - #4191

Merged
ndimiduk merged 2 commits into
apache:masterfrom
ndimiduk:26813-remove-javax.ws.rs-api-dependency
Mar 16, 2022
Merged

HBASE-26813 Remove javax.ws.rs-api dependency#4191
ndimiduk merged 2 commits into
apache:masterfrom
ndimiduk:26813-remove-javax.ws.rs-api-dependency

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

This is no longer needed since we've transitioned to the shaded Jersey shipped in
hbase-thirdparty.

This is no longer needed since we've transitioned to the shaded Jersey shipped in
hbase-thirdparty.
@ndimiduk

Copy link
Copy Markdown
MemberAuthor

With this change TestSecureRESTServer passes locally. Seems plausible that we're good?

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall2m 40smaster passed
+1 💚compile6m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 22sthe patch passed
+1 💚compile6m 3sthe patch passed
-0 ⚠️javac6m 3sroot generated 1 new + 1471 unchanged - 1 fixed = 1472 total (was 1472)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 4sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 44sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
35m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4191/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4191
Optional Testsdupname asflicense javac hadoopcheck xml compile
unameLinux 34a12c7b4bdc 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1047194
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4191/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-it hbase-rest . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4191/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the analysis on the JIRA. Let's try this.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 48sMaven dependency ordering for branch
+1 💚mvninstall2m 51smaster passed
+1 💚compile1m 45smaster passed
+1 💚shadedjars3m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 16smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 35sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚shadedjars3m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 19sthe patch passed
_ Other Tests _
-1 ❌unit354m 57sroot in the patch failed.
380m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4191/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4191
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2c457b8774fe 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1047194
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4191/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4191/1/testReport/
Max. process+thread count3558 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-it hbase-rest . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4191/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

The unit test suite is basically passing, so that's a good sign. I'd like to manually test the system and the REST gateway. Since I'm here, I'm considering also removing all of the excludes we have over our poms. Shout if that sounds terrifying.

@apurtell

Copy link
Copy Markdown
Contributor

SGTM

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

I did some manual testing of this patch by creating the assembly tarball, running standalone hbase and a REST server, and issuing various commands using curl. Everything worked as expected. I'm not sure what else to do in terms of testing.

@ndimiduk
ndimiduk merged commit b1c161e into apache:masterMar 16, 2022
@ndimiduk
ndimiduk deleted the 26813-remove-javax.ws.rs-api-dependency branch March 16, 2022 15:50
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 16, 2022
This is no longer needed since we've transitioned to the shaded Jersey shipped in
hbase-thirdparty. Also drop supplemental models entry.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 16, 2022
This is no longer needed since we've transitioned to the shaded Jersey shipped in
hbase-thirdparty. Also drop supplemental models entry.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
ndimiduk added a commit that referenced this pull request Mar 16, 2022
This is no longer needed since we've transitioned to the shaded Jersey shipped in
hbase-thirdparty. Also drop supplemental models entry.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
ndimiduk added a commit that referenced this pull request Mar 16, 2022
This is no longer needed since we've transitioned to the shaded Jersey shipped in
hbase-thirdparty. Also drop supplemental models entry.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Apache9 added a commit that referenced this pull request Mar 19, 2022
Apache9 added a commit that referenced this pull request Mar 19, 2022
Apache9 added a commit that referenced this pull request Mar 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ndimiduk@Apache-HBase@apurtell@Apache9