HBASE-26814 Default StoreHotnessProtector to off, with logs to guide when to turn it on by bbeaudreault · Pull Request #4194 · apache/hbase

bbeaudreault · 2022-03-09T20:52:31Z

See discussion in https://issues.apache.org/jira/browse/HBASE-26814

This change applies cleanly to branch-2 as well

…when to turn it on

bbeaudreault · 2022-03-09T21:23:46Z

Hold off on this. I tested it on an internal cluster and it actually logs per-region as regions come online. That's not exactly what we wanted, so I'll be making a change shortly.

bbeaudreault · 2022-03-09T21:33:09Z

Added a commit to only log once.

I looked around and am not aware of any ways within the hbase ecosystem to unit test a log message. If that's something we want feel free to let me know, but this seems trivial enough?

Apache-HBase · 2022-03-09T21:51:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 22s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	checkstyle	0m 37s	master passed
+1 💚	spotbugs	1m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	2m 15s	the patch passed
+1 💚	javac	2m 15s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 48s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 20s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		32m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4194
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 4d37d3eaaf28 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1047194`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…when to turn it on (#4194) Signed-off-by: Andrew Purtell <apurtell@apache.org>

Apache-HBase · 2022-03-10T04:04:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 50s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	shadedjars	3m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	3m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
-1 ❌	unit	336m 23s	hbase-server in the patch failed.
		353m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4194
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 84b936ab6f21 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1047194`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/testReport/
Max. process+thread count	2267 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-10T04:37:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 48s	master passed
+1 💚	compile	1m 8s	master passed
+1 💚	shadedjars	5m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	5m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
-1 ❌	unit	359m 57s	hbase-server in the patch failed.
		386m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4194
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7bc635e54475 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1047194`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/testReport/
Max. process+thread count	1917 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4194/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2022-03-10T15:40:37Z

This change appears to have introduced a spot bugs error. I don't know why it wasn't caught in precommit.

ndimiduk · 2022-03-10T15:42:56Z

For instance, https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4196/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html

bbeaudreault · 2022-03-10T15:48:52Z

@ndimiduk yea Duo alerted me to that in the issue as well. I just pushed #4201

…when to turn it on (apache#4194)

HBASE-26814 Default StoreHotnessProtector to off, with logs to guide …
c9defe5
…when to turn it on

log once
93c753c

apurtell approved these changes Mar 9, 2022
View reviewed changes

apurtell merged commit 1dd29db into apache:masterMar 9, 2022

asfgit pushed a commit that referenced this pull request Mar 10, 2022
HBASE-26814Default StoreHotnessProtector to off, with logs to guide …
8a43178
…when to turn it on (#4194) Signed-off-by: Andrew Purtell <apurtell@apache.org>

asfgit pushed a commit that referenced this pull request Mar 10, 2022
HBASE-26814Default StoreHotnessProtector to off, with logs to guide …
206100f
…when to turn it on (#4194) Signed-off-by: Andrew Purtell <apurtell@apache.org>

bbeaudreault deleted the HBASE-26814 branch March 10, 2022 15:47

guangxuCheng pushed a commit to guangxuCheng/hbase that referenced this pull request Mar 28, 2022
HBASE-26814 Default StoreHotnessProtector to off, with logs to guide …
0e12530
…when to turn it on (apache#4194)

Navigation Menu

Uh oh!

HBASE-26814 Default StoreHotnessProtector to off, with logs to guide when to turn it on - #4194

HBASE-26814 Default StoreHotnessProtector to off, with logs to guide when to turn it on#4194
apurtell merged 2 commits into
apache:masterfrom
HubSpot:HBASE-26814

bbeaudreault commented Mar 9, 2022•
edited
Loading

Uh oh!

bbeaudreault commented Mar 9, 2022

Uh oh!

bbeaudreault commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 10, 2022

Uh oh!

Apache-HBase commented Mar 10, 2022

Uh oh!

ndimiduk commented Mar 10, 2022

Uh oh!

ndimiduk commented Mar 10, 2022

Uh oh!

bbeaudreault commented Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

bbeaudreault commented Mar 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bbeaudreault commented Mar 9, 2022

Uh oh!

bbeaudreault commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 9, 2022

Uh oh!

Apache-HBase commented Mar 10, 2022

Uh oh!

Apache-HBase commented Mar 10, 2022

Uh oh!

ndimiduk commented Mar 10, 2022

Uh oh!

ndimiduk commented Mar 10, 2022

Uh oh!

bbeaudreault commented Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bbeaudreault commented Mar 9, 2022•
edited
Loading