Skip to content

HBASE-26617 Use spotless to reduce the pain on fixing checkstyle issues - #4214

Closed
Apache9 wants to merge 1 commit into
apache:masterfrom
Apache9:HBASE-26617
Closed

HBASE-26617 Use spotless to reduce the pain on fixing checkstyle issues#4214
Apache9 wants to merge 1 commit into
apache:masterfrom
Apache9:HBASE-26617

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Mar 13, 2022
@Apache9

Copy link
Copy Markdown
ContributorAuthor

The ratchetFrom is the last commit of master branch, so 'mvn spotless:apply' only format the main pom.xml.

We could add new checks in pre commit to force developers to run 'mvn spotless:apply' before submitting PRs.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 48smaster passed
+1 💚compile6m 7smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 21sthe patch passed
+1 💚compile6m 14sthe patch passed
+1 💚javac6m 14sthe patch passed
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
35m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4214
Optional Testsdupname asflicense shellcheck shelldocs javac hadoopcheck xml compile
unameLinux 27cf9de8b440 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fd301ad
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 40smaster passed
+1 💚compile3m 9smaster passed
+1 💚shadedjars5m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 9smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 20sthe patch passed
+1 💚compile3m 9sthe patch passed
+1 💚javac3m 9sthe patch passed
+1 💚shadedjars5m 28spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 8sthe patch passed
_ Other Tests _
-1 ❌unit457m 42sroot in the patch failed.
493m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4214
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9c722224a48d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fd301ad
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/testReport/
Max. process+thread count1790 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 51smaster passed
+1 💚compile1m 43smaster passed
+1 💚shadedjars3m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 22sthe patch passed
+1 💚compile1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
+1 💚shadedjars3m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 27sthe patch passed
_ Other Tests _
+1 💚unit542m 44sroot in the patch passed.
564m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4214
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9835a9927ab8 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fd301ad
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/testReport/
Max. process+thread count2765 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 59smaster passed
+1 💚compile2m 14smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile2m 15sthe patch passed
+1 💚javac2m 15sthe patch passed
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 0sThe patch has no ill-formed XML file.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
16m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4214
Optional Testsdupname asflicense shellcheck shelldocs javac xml compile
unameLinux 4e6f69b76fb3 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a49d147
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count42 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 48smaster passed
+1 💚compile4m 23smaster passed
+1 💚javadoc3m 54smaster passed
_ Patch Compile Tests _
+1 💚mvninstall6m 18sthe patch passed
+1 💚compile4m 22sthe patch passed
+1 💚javac4m 22sthe patch passed
+1 💚javadoc3m 52sthe patch passed
_ Other Tests _
-1 ❌unit212m 33sroot in the patch failed.
244m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4214
Optional Testsjavac javadoc unit compile
unameLinux 0fd8b2547c41 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a49d147
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/testReport/
Max. process+thread count1953 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 54sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 5smaster passed
+1 💚compile3m 39smaster passed
+1 💚javadoc2m 53smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 23sthe patch passed
+1 💚compile3m 36sthe patch passed
+1 💚javac3m 36sthe patch passed
+1 💚javadoc2m 52sthe patch passed
_ Other Tests _
-1 ❌unit327m 3sroot in the patch failed.
355m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4214
Optional Testsjavac javadoc unit compile
unameLinux 8618bfd7a797 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a49d147
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/testReport/
Max. process+thread count2088 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 31smaster passed
+1 💚compile9m 6smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile8m 1sthe patch passed
+1 💚javac8m 1sthe patch passed
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 0sThe patch has no ill-formed XML file.
+1 💚hadoopcheck15m 8sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
45m 51s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4214
Optional Testsdupname asflicense shellcheck shelldocs javac hadoopcheck xml compile
unameLinux 2519d26e82fa 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ad70ac2
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count138 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 38smaster passed
+1 💚compile1m 51smaster passed
+1 💚shadedjars3m 41sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 54smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 32sthe patch passed
+1 💚compile1m 53sthe patch passed
+1 💚javac1m 53sthe patch passed
+1 💚shadedjars3m 38spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 57sthe patch passed
_ Other Tests _
+1 💚unit236m 59sroot in the patch passed.
260m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4214
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e5bcb1766e19 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ad70ac2
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/testReport/
Max. process+thread count5167 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 26smaster passed
+1 💚compile1m 39smaster passed
+1 💚shadedjars3m 36sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile1m 33sthe patch passed
+1 💚javac1m 33sthe patch passed
+1 💚shadedjars3m 37spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 24sthe patch passed
_ Other Tests _
+1 💚unit322m 20sroot in the patch passed.
344m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4214
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 36713bf38222 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ad70ac2
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/testReport/
Max. process+thread count4498 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4214/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 added a commit that referenced this pull request Mar 28, 2022
…es (#4214)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Apache9 added a commit that referenced this pull request Mar 28, 2022
…es (#4214)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 28, 2022
…es (apache#4214)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Conflicts:
pom.xml
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@GeorryHuang