Skip to content

HBASE-26840 Fix NPE in the retry of logroller - #4224

Merged
sunhelly merged 2 commits into
apache:masterfrom
sunhelly:HBASE-26840
Mar 15, 2022
Merged

HBASE-26840 Fix NPE in the retry of logroller#4224
sunhelly merged 2 commits into
apache:masterfrom
sunhelly:HBASE-26840

Conversation

@sunhelly

@sunhellysunhelly commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Mar 15, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall6m 25smaster passed
+1 💚compile0m 43smaster passed
+1 💚checkstyle0m 40smaster passed
+1 💚spotbugs1m 31smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 41sthe patch passed
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 37sthe patch passed
+1 💚checkstyle0m 36sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotbugs1m 33sthe patch passed
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
14m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4224
Optional Testsdupname asflicense javac spotbugs checkstyle compile
unameLinux 17279bdbadcc 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f640b7f
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count57 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 15, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 9smaster passed
+1 💚compile0m 38smaster passed
+1 💚javadoc0m 26smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 42sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
-1 ❌unit146m 50shbase-server in the patch failed.
156m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4224
Optional Testsjavac javadoc unit compile
unameLinux 48b52a624e9e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f640b7f
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/testReport/
Max. process+thread count2214 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 15, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 55smaster passed
+1 💚compile1m 12smaster passed
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+1 💚mvninstall1m 20sthe patch passed
+1 💚compile1m 13sthe patch passed
+1 💚javac1m 13sthe patch passed
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit182m 35shbase-server in the patch passed.
196m 58s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4224
Optional Testsjavac javadoc unit compile
unameLinux 890a9a086d1d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f640b7f
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/testReport/
Max. process+thread count1866 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani previously approved these changes Mar 15, 2022
View reviewed changes
virajjasani
virajjasani reviewed Mar 15, 2022
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java Outdated
LOG.warn("Retry to roll log, nAttempts={}, waiting time={}ms, sleeping 1s to retry,"
+ " last excepiton= {}", nAttempts, waitingTime,
ioe.getCause().getClass().getSimpleName());
+ " last excepiton= {}", nAttempts, waitingTime, ioe);

@virajjasanivirajjasaniMar 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need to add {} after last excepiton, keeping ioe as the last arg will print the whole Exception stacktrace.

@sunhellysunhellyMar 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll remove it.

@Apache-HBase

Apache-HBase commented Mar 15, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 59smaster passed
+1 💚compile0m 42smaster passed
+1 💚checkstyle0m 37smaster passed
+1 💚spotbugs1m 23smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 43sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚checkstyle0m 36sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotbugs1m 33sthe patch passed
_ Other Tests _
+1 💚asflicense0m 6sThe patch does not generate ASF License warnings.
12m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4224
Optional Testsdupname asflicense javac spotbugs checkstyle compile
unameLinux e41e66db8413 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cc2c220
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count57 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 15, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 41smaster passed
+1 💚compile0m 39smaster passed
+1 💚javadoc0m 23smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 41sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
-1 ❌unit155m 9shbase-server in the patch failed.
163m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4224
Optional Testsjavac javadoc unit compile
unameLinux 2074fca0b561 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cc2c220
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/testReport/
Max. process+thread count3052 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 15, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 59smaster passed
+1 💚compile1m 19smaster passed
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+1 💚mvninstall1m 17sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
-1 ❌unit182m 48shbase-server in the patch failed.
197m 16s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4224
Optional Testsjavac javadoc unit compile
unameLinux 424b376e4fbd 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cc2c220
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/testReport/
Max. process+thread count1823 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4224/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@sunhelly
sunhelly merged commit fb09cb9 into apache:masterMar 15, 2022
asfgit pushed a commit that referenced this pull request Mar 15, 2022
@sunhelly
HBASE-26840Fix NPE in the retry of logroller (#4224)
31cb0b8
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Mar 15, 2022
@sunhelly
HBASE-26840Fix NPE in the retry of logroller (#4224)
46af73b
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Mar 15, 2022
@sunhelly
HBASE-26840Fix NPE in the retry of logroller (#4224)
8349965
Signed-off-by: Duo Zhang <zhangduo@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@sunhelly@petersomogyi
HBASE-26840 Fix NPE in the retry of logroller (apache#4224)
ffedb92
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 31cb0b8)
Change-Id: I42bb559ba29417f43d17e1db893141656d87b806
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani left review comments
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunhelly@Apache-HBase@Apache9@virajjasani