Uh oh!
There was an error while loading. Please reload this page.
HBASE-26867 Introduce a FlushProcedure - #4246
Conversation
Apache-HBase
commented
Mar 20, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 20, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 20, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 21, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 21, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 21, 2022
💔 -1 overall
This message was automatically generated. |
| // the hbase hadoop version does not match the running hadoop version. | ||
| // if that happens, we need fall back to the old flush implementation. | ||
| LOG.info("Unrecoverable error in master side. Fallback to FlushTableProcedure V1", error); | ||
| addListener(tableExists(tableName), (exists, err) -> { |
There was a problem hiding this comment.
Better abstract this to a seprated method and call it legacyFlush(or something else, I'm not good at naming in English...)
| * the procedure will suspend and retry later. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public abstract class AbstractRegionRemoteProcedure extends Procedure<MasterProcedureEnv> |
There was a problem hiding this comment.
Better give it another name? Like IdempotentRegionRemoteProcedureBase?
| false, FlushLifeCycleTracker.DUMMY); | ||
| } | ||
| if (res.getResult() == HRegion.FlushResult.Result.CANNOT_FLUSH) { | ||
| region.waitForFlushes(); |
There was a problem hiding this comment.
Is it always safe to call this here?
There was a problem hiding this comment.
From what I've seen so far, it's safe. It's just for a simple check to make sure all the data which should be flushed (whose seqId is less than or equal to the read point) has been flushed. But it's ok for me to remove this check if you're concerned there is any risk of getting the flush procedure stuck here.
frostruan
commented
Apr 6, 2022
Thanks so much for reviewing this Duo. I'll address the suggestions as soon as possible. |
Apache-HBase
commented
Apr 10, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 10, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 10, 2022
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Jul 1, 2022
Any updates here? |
frostruan
commented
Jul 1, 2022
Sorry, I've been a little busy recently. Will start work on fixing file conflicts as soon as possible. Thanks. |
Apache-HBase
commented
Jul 2, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 2, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 2, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 2, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 2, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 2, 2022
💔 -1 overall
This message was automatically generated. |
guangxuCheng
commented
Mar 27, 2023
hi @frostruan , any updates here ? |
frostruan
commented
Mar 27, 2023
Thanks for your attention guangxu @guangxuCheng . Will continue this work as soon as possible. |
frostruan
commented
May 27, 2023
Submitted a new PR #5256 . This one will be closed. Please see the new PR if you're interested, I'd be grateful for any comments and suggestions. Thanks. @Apache9@guangxuCheng |
No description provided.