Skip to content

HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException - #4273

Merged
bbeaudreault merged 6 commits into
apache:branch-2from
HubSpot:HBASE-26807-2
Apr 22, 2022
Merged

HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException#4273
bbeaudreault merged 6 commits into
apache:branch-2from
HubSpot:HBASE-26807-2

Conversation

@bbeaudreault

Copy link
Copy Markdown
Contributor

This is the branch-2 port for #4180

The first commit is a simple cherry-pick of that PR.

The second commit applies the same changes to the blocking RPC client classes. In implementing for blocking client, I consolidated the configuration parsing within ConnectionConfiguration. In my opinion this is much cleaner/DRY, and also mirrors how AsyncConnectionConfiguration works for the async client.

Added tests for each of the 3 places that these pauses end up in the blocking client: AsyncProcess, RpcRetryingCallerImpl, and ConnectionImplementation.locationRegions.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 17sbranch-2 passed
+1 💚compile1m 4sbranch-2 passed
+1 💚shadedjars0m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 50sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 1sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars0m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 47sthe patch passed
_ Other Tests _
+1 💚unit1m 26shbase-common in the patch passed.
+1 💚unit2m 37shbase-client in the patch passed.
-1 ❌unit8m 57shbase-server in the patch failed.
24m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 715707fcc488 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b7cfc1d
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/testReport/
Max. process+thread count557 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 15sbranch-2 passed
+1 💚compile3m 17sbranch-2 passed
+1 💚checkstyle1m 3sbranch-2 passed
+0 🆗refguide2m 46sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs2m 18sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 59sthe patch passed
+1 💚compile3m 15sthe patch passed
-0 ⚠️javac0m 39shbase-client generated 3 new + 158 unchanged - 0 fixed = 161 total (was 158)
-0 ⚠️checkstyle0m 17shbase-client: The patch generated 7 new + 66 unchanged - 0 fixed = 73 total (was 66)
-0 ⚠️checkstyle0m 34shbase-server: The patch generated 2 new + 15 unchanged - 0 fixed = 17 total (was 15)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide1m 27spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck6m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 30sthe patch passed
_ Other Tests _
-1 ❌asflicense0m 20sThe patch generated 1 ASF License warnings.
35m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 82184e06df6f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b7cfc1d
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/1/yetus-general-check/output/branch-site/book.html
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/1/yetus-general-check/output/patch-site/book.html
asflicensehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count60 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 51sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall5m 36sbranch-2 passed
+1 💚compile2m 51sbranch-2 passed
+1 💚shadedjars0m 36sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 47sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for patch
+1 💚mvninstall5m 0sthe patch passed
+1 💚compile2m 53sthe patch passed
+1 💚javac2m 53sthe patch passed
+1 💚shadedjars0m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 42sthe patch passed
_ Other Tests _
+1 💚unit3m 22shbase-common in the patch passed.
+1 💚unit4m 16shbase-client in the patch passed.
-1 ❌unit23m 57shbase-server in the patch failed.
57m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d8d645495e2c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b7cfc1d
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/testReport/
Max. process+thread count986 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall2m 28sbranch-2 passed
+1 💚compile4m 14sbranch-2 passed
+1 💚checkstyle1m 12sbranch-2 passed
+0 🆗refguide1m 41sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs2m 58sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for patch
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile3m 56sthe patch passed
+1 💚javac3m 56sthe patch passed
+1 💚checkstyle1m 14sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide2m 17spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck9m 55sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 49sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
46m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 17ed3243c2d5 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b7cfc1d
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/2/yetus-general-check/output/branch-site/book.html
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count60 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 49sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 20sbranch-2 passed
+1 💚compile1m 3sbranch-2 passed
+1 💚shadedjars0m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 48sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 1sthe patch passed
+1 💚compile1m 7sthe patch passed
+1 💚javac1m 7sthe patch passed
+1 💚shadedjars0m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 46sthe patch passed
_ Other Tests _
+1 💚unit1m 24shbase-common in the patch passed.
+1 💚unit2m 32shbase-client in the patch passed.
-1 ❌unit177m 19shbase-server in the patch failed.
193m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8d15ed5ce350 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b7cfc1d
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/testReport/
Max. process+thread count2585 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 46sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 0sbranch-2 passed
+1 💚compile3m 28sbranch-2 passed
+1 💚shadedjars0m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 54sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 55sthe patch passed
+1 💚compile2m 50sthe patch passed
+1 💚javac2m 50sthe patch passed
+1 💚shadedjars0m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 6sthe patch passed
_ Other Tests _
+1 💚unit3m 41shbase-common in the patch passed.
+1 💚unit4m 53shbase-client in the patch passed.
-1 ❌unit356m 34shbase-server in the patch failed.
393m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 13eb61613e9b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b7cfc1d
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/testReport/
Max. process+thread count2291 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the HBASE-26807-2 branch 2 times, most recently from c42ca47 to 56cccb4CompareMarch 25, 2022 14:34
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 23sbranch-2 passed
+1 💚compile7m 17sbranch-2 passed
+1 💚checkstyle2m 15sbranch-2 passed
+0 🆗refguide4m 20sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs5m 13sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile7m 20sthe patch passed
+1 💚javac7m 20sthe patch passed
-0 ⚠️checkstyle0m 27shbase-common: The patch generated 1 new + 8 unchanged - 0 fixed = 9 total (was 8)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide3m 52spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck12m 56sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs5m 24sthe patch passed
_ Other Tests _
-1 ❌asflicense0m 39sThe patch generated 1 ASF License warnings.
70m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 19f55f33167d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6650807
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/3/yetus-general-check/output/branch-site/book.html
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/3/yetus-general-check/output/patch-site/book.html
asflicensehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count60 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 37sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 51sMaven dependency ordering for branch
+1 💚mvninstall3m 38sbranch-2 passed
+1 💚compile1m 26sbranch-2 passed
+1 💚shadedjars0m 30sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 41sthe patch passed
+1 💚compile1m 30sthe patch passed
+1 💚javac1m 30sthe patch passed
+1 💚shadedjars0m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 5sthe patch passed
_ Other Tests _
+1 💚unit2m 0shbase-common in the patch passed.
+1 💚unit3m 15shbase-client in the patch passed.
-1 ❌unit215m 30shbase-server in the patch failed.
239m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bda36a13fbd0 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6650807
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/testReport/
Max. process+thread count2309 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 4sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 5sbranch-2 passed
+1 💚compile2m 35sbranch-2 passed
+1 💚shadedjars0m 36sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 51sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for patch
+1 💚mvninstall4m 49sthe patch passed
+1 💚compile2m 42sthe patch passed
+1 💚javac2m 42sthe patch passed
+1 💚shadedjars0m 34spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 56sthe patch passed
_ Other Tests _
+1 💚unit3m 7shbase-common in the patch passed.
+1 💚unit3m 56shbase-client in the patch passed.
-1 ❌unit265m 52shbase-server in the patch failed.
298m 48s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux afc165f151cb 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6650807
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/testReport/
Max. process+thread count2416 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 1sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 5sbranch-2 passed
+1 💚compile5m 40sbranch-2 passed
+1 💚checkstyle1m 40sbranch-2 passed
+0 🆗refguide3m 8sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 55sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile5m 39sthe patch passed
+1 💚javac5m 39sthe patch passed
+1 💚checkstyle1m 40sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide3m 8spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck10m 14sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs4m 29sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
55m 16s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 2ce8e146fc71 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 51f8c87
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/4/yetus-general-check/output/branch-site/book.html
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count60 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 0sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 19sbranch-2 passed
+1 💚compile1m 17sbranch-2 passed
+1 💚shadedjars0m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 6sthe patch passed
+1 💚compile1m 13sthe patch passed
+1 💚javac1m 13sthe patch passed
+1 💚shadedjars0m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sthe patch passed
_ Other Tests _
-1 ❌unit0m 53shbase-common in the patch failed.
+1 💚unit2m 40shbase-client in the patch passed.
-1 ❌unit204m 34shbase-server in the patch failed.
223m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e0dd4bc0efb6 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 51f8c87
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-common.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/testReport/
Max. process+thread count2536 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 31sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 55sbranch-2 passed
+1 💚compile2m 9sbranch-2 passed
+1 💚shadedjars0m 30sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 28sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile2m 14sthe patch passed
+1 💚javac2m 14sthe patch passed
+1 💚shadedjars0m 30spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 28sthe patch passed
_ Other Tests _
+1 💚unit2m 57shbase-common in the patch passed.
+1 💚unit3m 54shbase-client in the patch passed.
-1 ❌unit264m 44shbase-server in the patch failed.
292m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 63078929388b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 51f8c87
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/testReport/
Max. process+thread count2234 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall5m 38sbranch-2 passed
+1 💚compile11m 50sbranch-2 passed
+1 💚checkstyle3m 25sbranch-2 passed
+0 🆗refguide5m 51sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs11m 15sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall5m 22sthe patch passed
+1 💚compile12m 12sthe patch passed
+1 💚cc12m 12sthe patch passed
+1 💚javac12m 12sthe patch passed
-0 ⚠️checkstyle0m 44shbase-client: The patch generated 4 new + 61 unchanged - 0 fixed = 65 total (was 61)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide5m 32spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck17m 44sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 19sthe patch passed
+1 💚spotbugs12m 44sthe patch passed
_ Other Tests _
+1 💚asflicense1m 8sThe patch does not generate ASF License warnings.
113m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool
unameLinux 10969902ef0e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 489af42
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/5/yetus-general-check/output/branch-site/book.html
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/5/yetus-general-check/output/patch-site/book.html
Max. process+thread count69 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 47sMaven dependency ordering for branch
+1 💚mvninstall2m 17sbranch-2 passed
+1 💚compile1m 26sbranch-2 passed
+1 💚shadedjars3m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 1sthe patch passed
+1 💚compile1m 28sthe patch passed
+1 💚javac1m 28sthe patch passed
+1 💚shadedjars3m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 55sthe patch passed
_ Other Tests _
+1 💚unit0m 22shbase-protocol-shaded in the patch passed.
+1 💚unit1m 23shbase-common in the patch passed.
+1 💚unit2m 30shbase-client in the patch passed.
-1 ❌unit186m 6shbase-server in the patch failed.
211m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 61be3954fb1c 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 489af42
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/testReport/
Max. process+thread count2509 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 46sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall2m 43sbranch-2 passed
+1 💚compile2m 3sbranch-2 passed
+1 💚shadedjars4m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile2m 17sthe patch passed
+1 💚javac2m 17sthe patch passed
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 24sthe patch passed
_ Other Tests _
+1 💚unit0m 41shbase-protocol-shaded in the patch passed.
+1 💚unit2m 17shbase-common in the patch passed.
+1 💚unit3m 25shbase-client in the patch passed.
-1 ❌unit235m 46shbase-server in the patch failed.
270m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c05ddb857a9c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 489af42
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/testReport/
Max. process+thread count2347 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall4m 20sbranch-2 passed
+1 💚compile7m 35sbranch-2 passed
+1 💚checkstyle1m 51sbranch-2 passed
+0 🆗refguide3m 12sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs6m 29sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 21sthe patch passed
+1 💚compile6m 53sthe patch passed
+1 💚cc6m 53sthe patch passed
+1 💚javac6m 53sthe patch passed
+1 💚checkstyle1m 47sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide3m 12spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck11m 19sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc2m 0sthe patch passed
+1 💚spotbugs7m 13sthe patch passed
_ Other Tests _
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
70m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool
unameLinux a35878742836 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 8ef1ae3
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/6/yetus-general-check/output/branch-site/book.html
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/6/yetus-general-check/output/patch-site/book.html
Max. process+thread count64 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 18sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 19sbranch-2 passed
+1 💚compile1m 42sbranch-2 passed
+1 💚shadedjars3m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile1m 42sthe patch passed
+1 💚javac1m 42sthe patch passed
+1 💚shadedjars3m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 6sthe patch passed
_ Other Tests _
+1 💚unit0m 28shbase-protocol-shaded in the patch passed.
+1 💚unit1m 26shbase-common in the patch passed.
+1 💚unit2m 34shbase-client in the patch passed.
-1 ❌unit187m 22shbase-server in the patch failed.
213m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4ffa8a9474ca 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 8ef1ae3
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/testReport/
Max. process+thread count2605 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec7m 7sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep1m 55sMaven dependency ordering for branch
+1 💚mvninstall6m 6sbranch-2 passed
+1 💚compile3m 48sbranch-2 passed
+1 💚shadedjars6m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 9sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 12sthe patch passed
+1 💚compile3m 38sthe patch passed
+1 💚javac3m 38sthe patch passed
+1 💚shadedjars6m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 44sthe patch passed
_ Other Tests _
+1 💚unit0m 53shbase-protocol-shaded in the patch passed.
+1 💚unit3m 6shbase-common in the patch passed.
+1 💚unit4m 0shbase-client in the patch passed.
-1 ❌unit311m 53shbase-server in the patch failed.
368m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 69c5a38e0624 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 8ef1ae3
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/testReport/
Max. process+thread count2525 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

private final int maxKeyValueSize;

AsyncConnectionConfiguration(Configuration conf) {
ConnectionConfiguration connectionConf = new ConnectionConfiguration(conf);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note this difference between master and branch-2 -- since we must maintain both an async and blocking configuration, I pulled this in here to DRY up the handling (and remove the duplicate logging)


public SingleRequestCallerBuilder<T> pauseForCQTBE(long pause, TimeUnit unit) {
this.pauseForCQTBENs = unit.toNanos(pause);
public SingleRequestCallerBuilder<T> pauseForServerOverloaded(long pause, TimeUnit unit) {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class is IA.Private, so I simply rename all of these methods rather than handle deprecation

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

@ndimiduk We should let this branch run the pre-commit checks before merging, but I just checked and it should apply cleanly to branch-2.5 as well.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 42sMaven dependency ordering for branch
+1 💚mvninstall2m 13sbranch-2 passed
+1 💚compile4m 0sbranch-2 passed
+1 💚checkstyle1m 9sbranch-2 passed
+0 🆗refguide1m 39sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 51sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall2m 2sthe patch passed
+1 💚compile3m 58sthe patch passed
+1 💚cc3m 58sthe patch passed
+1 💚javac3m 58sthe patch passed
-0 ⚠️checkstyle0m 16shbase-client: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide1m 31spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck7m 41sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc1m 21sthe patch passed
+1 💚spotbugs4m 5sthe patch passed
_ Other Tests _
+1 💚asflicense0m 26sThe patch does not generate ASF License warnings.
42m 16s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool
unameLinux 31910dff0234 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28acbc1
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/7/yetus-general-check/output/branch-site/book.html
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/7/yetus-general-check/output/patch-site/book.html
Max. process+thread count65 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 8sbranch-2 passed
+1 💚compile1m 43sbranch-2 passed
+1 💚shadedjars3m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 5sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 10sthe patch passed
+1 💚compile1m 42sthe patch passed
+1 💚javac1m 42sthe patch passed
+1 💚shadedjars3m 40spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sthe patch passed
_ Other Tests _
+1 💚unit0m 28shbase-protocol-shaded in the patch passed.
+1 💚unit1m 23shbase-common in the patch passed.
+1 💚unit2m 36shbase-client in the patch passed.
-1 ❌unit191m 9shbase-server in the patch failed.
216m 16s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 32b0275a57bc 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28acbc1
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/testReport/
Max. process+thread count2259 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Ok unfortunately I think the test failure might be real. I was able to reproduce locally, and branch-2 succeeded. I don't have time to look into this right now because I'm headed out of town. I'll be back to look at it on Tuesday, so we might want to hold off merging until I can get to it @ndimiduk

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 40sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 13sbranch-2 passed
+1 💚compile3m 1sbranch-2 passed
+1 💚shadedjars5m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 42sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 57sthe patch passed
+1 💚compile3m 0sthe patch passed
+1 💚javac3m 0sthe patch passed
+1 💚shadedjars5m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 36sthe patch passed
_ Other Tests _
+1 💚unit0m 50shbase-protocol-shaded in the patch passed.
+1 💚unit2m 44shbase-common in the patch passed.
+1 💚unit3m 43shbase-client in the patch passed.
-1 ❌unit286m 0shbase-server in the patch failed.
328m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 718699b3a626 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 28acbc1
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/testReport/
Max. process+thread count2406 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Apr 8, 2022
@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

The test failure was due to a somewhat implicit dependency between HTableMultiplexer and AsyncProcess conf parsing. I fixed that by creating a new AsyncProcess constuctor for use by HTableMultiplier which upgrades the dependency to explicit. This way we're unlikely to hit issues like this again in the future. The change is covered by existing tests since they failed previously and now succeed.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall5m 21sbranch-2 passed
+1 💚compile8m 59sbranch-2 passed
+1 💚checkstyle2m 52sbranch-2 passed
+0 🆗refguide4m 24sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs9m 8sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 24sthe patch passed
+1 💚compile9m 29sthe patch passed
+1 💚cc9m 29sthe patch passed
+1 💚javac9m 29sthe patch passed
+1 💚checkstyle2m 28sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide4m 26spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck14m 20sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc2m 34sthe patch passed
+1 💚spotbugs9m 54sthe patch passed
_ Other Tests _
+1 💚asflicense0m 48sThe patch does not generate ASF License warnings.
91m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4273
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool
unameLinux 3ad3d9c6b4df 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5dc93d7
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/9/yetus-general-check/output/branch-site/book.html
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4273/9/yetus-general-check/output/patch-site/book.html
Max. process+thread count64 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 52sbranch-2 passed
+1 💚compile1m 46sbranch-2 passed
+1 💚shadedjars4m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 31sthe patch passed
+1 💚compile1m 47sthe patch passed
+1 💚javac1m 47sthe patch passed
+1 💚shadedjars4m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 1sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-protocol-shaded in the patch passed.
+1 💚unit1m 38shbase-common in the patch passed.
+1 💚unit2m 51shbase-client in the patch passed.
+1 💚unit176m 29shbase-server in the patch passed.
204m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ccbd8586c0f7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5dc93d7
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/testReport/
Max. process+thread count2816 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 49sMaven dependency ordering for branch
+1 💚mvninstall2m 25sbranch-2 passed
+1 💚compile1m 26sbranch-2 passed
+1 💚shadedjars3m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall1m 58sthe patch passed
+1 💚compile1m 26sthe patch passed
+1 💚javac1m 26sthe patch passed
+1 💚shadedjars3m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sthe patch passed
_ Other Tests _
+1 💚unit0m 23shbase-protocol-shaded in the patch passed.
+1 💚unit1m 21shbase-common in the patch passed.
+1 💚unit2m 28shbase-client in the patch passed.
+1 💚unit185m 25shbase-server in the patch passed.
210m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4273
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6bf1af074021 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5dc93d7
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/testReport/
Max. process+thread count2336 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4273/9/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

Copy link
Copy Markdown
Member

Your extra commit for branch-2 looks fine to me. Will you need to apply that change as an addendum to master? If so, I suggest that you encapsulate it as it's own commit, with a commit title like "HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException (addendum)". You can make a PR with just the addendum for master and in this PR you can merge both commits (the original backport and the addendum) to branch-2. I recommend that you preserve the addendum through all backport branches. This makes it a little easier down the road when a RM wants to audit whether a JIRA ID as been applied in its entirety to a given branch.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

I don't think we need an addendum for master. All of the extra commits here are just to support branch-2 specific functionality (i.e blocking client). HTableMultiplexer doesn't exist in master.

The one divergence between master and branch-2 that might matter is the difference in in AsyncConnectionConfiguration, where here we instantiate a new ConnectionConfiguration in order to DRY up a bit. I thought about doing that in my master branch PR as well but it felt confusing since a bunch of fields have been removed from ConnectionConfiguration there and it almost seems like ConnectionConfiguration itself should be deleted in master branch. So I decided to leave it alone.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

I was thinking of creating a jira to clean up ConnectionConfiguration in master, but not sure how much time I'll have for that in the near future.

@bbeaudreault
bbeaudreault merged commit 2240025 into apache:branch-2Apr 22, 2022
@bbeaudreault
bbeaudreault deleted the HBASE-26807-2 branch April 22, 2022 12:56
bbeaudreault added a commit that referenced this pull request Apr 22, 2022
…ppedException (#4273)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Apr 24, 2022
…pause with CallDroppedException (apache#4273)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@ndimiduk