HBASE-26899 Run spotless:apply

[Apache9]

No description provided.

[Apache9]

I downloaded the newest eclipse, imported our formatter file, did some modifications, and then exported it and replaced our current formatter file.

What I changed are:

1. Change all the indent from default to 1, I saw a lot of checkstyle warnings which indicates that we indent more than expected.
2. Do not format file header. It is just the ASF license header, which do not need to be formatted.
3. As @ndimiduk point out, on method declarations, function calls and enum declarations we should wrap more, usually on every element if we need to wrap. So I changed the method declaration and function calls to 'wrap all elements, expect the first element if not necessary', and for function calls I also enabled 'Indent from the base expression's first line'. And for enum, I just use 'wrap all elements, every element on a new line'.
4. Remove 'Indent wrapped param/throws descriptions' as it seems useless.

Let's see the style check result.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 28s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	5m 52s	master passed
+1 💚	checkstyle	2m 54s	master passed
+1 💚	spotbugs	20m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	5m 57s	the patch passed
-0 ⚠️	javac	5m 57s	root generated 97 new + 1375 unchanged - 97 fixed = 1472 total (was 1472)
-0 ⚠️	checkstyle	2m 10s	root: The patch generated 1124 new + 3478 unchanged - 5094 fixed = 4602 total (was 8572)
-0 ⚠️	whitespace	0m 0s	The patch has 131 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 38s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	14m 25s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	31m 2s	the patch passed
		_ Other Tests _
+1 💚	asflicense	6m 22s	The patch does not generate ASF License warnings.
		135m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense xml javac hadoopcheck compile spotbugs hbaseanti checkstyle
uname	Linux e4ab4c262631 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	139 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Let me check the while space issue.

In my local test, eclipse will generate whitespace ending lines when formatting the 'pre' tag, but if we already have no whitespace endling blank lines before and after the 'pre' tag, it will not adding new whitespaces to the line.

And let me also check the indent error of checkstyle.

[Apache9]

More changes:

1. Add a format section in spotless to include all text files, specify trimTrailingWhitespace. But for java files, though I place the formats section after the java section, it will be executed before the java formatter, so the 'pre' tag will still generate whitespaces, you need to run spotless:apply the second time to trim them.
2. It should be a bug in the eclipse formatter as sometimes, if the condition statement in the 'if' condition section is wrapped, the indent of the following lines maybe wrong, like this:

if (func(a,
b) {
...
} else if (func(a,
b) {
...
}

Which is really annoying. So I change the config of 'Parentheses positions' for most elements to 'separate lines if wrapped'. In this way the indent will be correct. The code is like this

if (shortCondition) {
doSometing();
}
if (
longCondition(" 1 ")
&& longCondition(" 2 ")
&& longCondition(" 2 ")
) {
doSometing();
}
while (shortCondition) {
doSometing();
}
do {
doSometing();
} while (
longCondition(" 1 ")
&& longCondition(" 2 ")
&& longCondition(" 2 ")
);
if (mixedCondition1) {
doSometing();
}
if (mixedCondition2) {
doSometing();
}
if (mixedCondition3) {
doSometing();
}

For me I think it is kinda acceptable.

Let's see the result.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 32s	No case conflicting files found.
+0 🆗	shelldocs	0m 32s	Shelldocs was not available.
+0 🆗	markdownlint	0m 32s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s	master passed
+1 💚	compile	7m 6s	master passed
+1 💚	checkstyle	3m 17s	master passed
+1 💚	mvnsite	12m 44s	master passed
+0 🆗	refguide	1m 50s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	25m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 23s	the patch passed
+1 💚	compile	7m 0s	the patch passed
-0 ⚠️	javac	7m 0s	root generated 104 new + 1362 unchanged - 110 fixed = 1466 total (was 1472)
-0 ⚠️	checkstyle	2m 2s	root: The patch generated 769 new + 3336 unchanged - 5280 fixed = 4105 total (was 8616)
-0 ⚠️	mvnsite	2m 8s	root in the patch failed.
+1 💚	pylint	0m 54s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 0s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 44s	The patch has no ill-formed XML file.
+0 🆗	refguide	1m 49s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	13m 1s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotbugs	1m 33s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 ❌	spotbugs	8m 54s	root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	6m 7s	The patch does not generate ASF License warnings.
		170m 16s

Reason	Tests
FindBugs	module:hbase-server
	Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit) ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 160]
FindBugs	module:root
	Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit) ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 160]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux 1583bf519794 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/2/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-general-check/output/patch-mvnsite-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/2/yetus-general-check/output/patch-site/book.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-general-check/output/new-spotbugs-root.html
Max. process+thread count	139 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 37s	Docker mode activated.
-0 ⚠️	yetus	2m 18s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 50s	master passed
+1 💚	compile	2m 29s	master passed
+1 💚	shadedjars	4m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 43s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	2m 11s	the patch passed
+1 💚	javac	2m 11s	the patch passed
+1 💚	shadedjars	4m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	16m 44s	the patch passed
		_ Other Tests _
-1 ❌	unit	291m 58s	root in the patch failed.
		379m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 905b1243f304 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/testReport/
Max. process+thread count	2415 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 29s	Docker mode activated.
-0 ⚠️	yetus	2m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 56s	master passed
+1 💚	compile	2m 17s	master passed
+1 💚	shadedjars	4m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	11m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	1m 56s	the patch passed
+1 💚	javac	1m 56s	the patch passed
+1 💚	shadedjars	4m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	10m 43s	the patch passed
		_ Other Tests _
-1 ❌	unit	400m 55s	root in the patch failed.
		476m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 84075a07c7e6 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/testReport/
Max. process+thread count	2326 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 28s	No case conflicting files found.
+0 🆗	shelldocs	0m 28s	Shelldocs was not available.
+0 🆗	markdownlint	0m 28s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 5s	master passed
+1 💚	compile	5m 49s	master passed
+1 💚	checkstyle	2m 47s	master passed
-0 ⚠️	mvnsite	2m 56s	root in master failed.
+0 🆗	refguide	1m 40s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	21m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	5m 49s	the patch passed
-0 ⚠️	javac	5m 49s	root generated 92 new + 1380 unchanged - 92 fixed = 1472 total (was 1472)
-0 ⚠️	checkstyle	1m 45s	root: The patch generated 708 new + 3338 unchanged - 5278 fixed = 4046 total (was 8616)
-0 ⚠️	mvnsite	1m 56s	root in the patch failed.
+1 💚	pylint	0m 51s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 1s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 39s	The patch has no ill-formed XML file.
+0 🆗	refguide	1m 36s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotbugs	1m 21s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 ❌	spotbugs	7m 11s	root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	5m 23s	The patch does not generate ASF License warnings.
		141m 33s

Reason	Tests
FindBugs	module:hbase-server
	Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit) ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 160]
FindBugs	module:root
	Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit) ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 160]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux 1eb8797d17d5 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/branch-mvnsite-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/3/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/patch-mvnsite-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/3/yetus-general-check/output/patch-site/book.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-general-check/output/new-spotbugs-root.html
Max. process+thread count	140 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 18s	Docker mode activated.
-0 ⚠️	yetus	2m 51s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 54s	master passed
+1 💚	compile	2m 47s	master passed
+1 💚	shadedjars	5m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	14m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	2m 48s	the patch passed
+1 💚	javac	2m 48s	the patch passed
+1 💚	shadedjars	5m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	14m 53s	the patch passed
		_ Other Tests _
-1 ❌	unit	216m 2s	root in the patch failed.
		311m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 345dfb0d1d39 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/testReport/
Max. process+thread count	2382 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Seems the mvnsite result is not very stable. On master branch it could also fail.

The spotbugs problem is not introduced by the reformat. It says we miss to check the return value of await but looking at the code, I think the code is correct, we do not need to check the return value. Let me think if there is a better way instead of just suppress the warning.

And there are still some indentation problem. Let me take a look on them.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 28s	No case conflicting files found.
+0 🆗	shelldocs	0m 28s	Shelldocs was not available.
+0 🆗	markdownlint	0m 28s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 7s	master passed
+1 💚	compile	5m 49s	master passed
+1 💚	checkstyle	2m 47s	master passed
-0 ⚠️	mvnsite	1m 53s	root in master failed.
+0 🆗	refguide	1m 36s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	21m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	5m 48s	the patch passed
-0 ⚠️	javac	5m 48s	root generated 81 new + 1391 unchanged - 81 fixed = 1472 total (was 1472)
-0 ⚠️	checkstyle	1m 44s	root: The patch generated 713 new + 3341 unchanged - 5275 fixed = 4054 total (was 8616)
+1 💚	mvnsite	7m 57s	the patch passed
+1 💚	pylint	0m 50s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 1s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 38s	The patch has no ill-formed XML file.
+0 🆗	refguide	1m 34s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	24m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	5m 24s	The patch does not generate ASF License warnings.
		141m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux d308c373f041 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-general-check/output/branch-mvnsite-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/4/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 11s	Docker mode activated.
-0 ⚠️	yetus	2m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	11m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	1m 52s	the patch passed
+1 💚	javac	1m 52s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	11m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	249m 21s	root in the patch passed.
		327m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bd7b35ee5233 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/testReport/
Max. process+thread count	4963 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

There is a problem that the spotless plugin does not support exclude, for example, the thrift generated files.

Let me see how to deal with this.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 37s	Docker mode activated.
-0 ⚠️	yetus	2m 55s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	5m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	shadedjars	5m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 37s	the patch passed
		_ Other Tests _
-1 ❌	unit	374m 51s	root in the patch failed.
		464m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 44eb58736ded 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/testReport/
Max. process+thread count	2423 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 8s	#4312 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/console
versions	git=2.25.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 28s	No case conflicting files found.
+0 🆗	shelldocs	0m 28s	Shelldocs was not available.
+0 🆗	markdownlint	0m 28s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 6s	master passed
+1 💚	compile	5m 44s	master passed
+1 💚	checkstyle	2m 46s	master passed
-0 ⚠️	mvnsite	1m 55s	root in master failed.
+0 🆗	refguide	1m 34s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	21m 17s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	5m 50s	the patch passed
-0 ⚠️	javac	5m 50s	root generated 64 new + 1408 unchanged - 64 fixed = 1472 total (was 1472)
-0 ⚠️	checkstyle	2m 12s	root: The patch generated 2555 new + 3678 unchanged - 4942 fixed = 6233 total (was 8620)
+1 💚	mvnsite	8m 2s	the patch passed
+1 💚	pylint	0m 50s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 0s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 38s	The patch has no ill-formed XML file.
+0 🆗	refguide	1m 33s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	24m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	5m 23s	The patch does not generate ASF License warnings.
		140m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux 938f39517b0d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/artifact/yetus-general-check/output/branch-mvnsite-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/5/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/5/yetus-general-check/output/patch-site/book.html
Max. process+thread count	140 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

OK, good, seems worked.

Why we still touch the generated files and package-info.java is because in the formats section I do not exclude them from removing trailing whitespaces.

@ndimiduk@apurtell PTAL whether this is enough to do a full reformat. And I've already filed HBASE-26915 for addressing some nasty style issues which should be done before landing this PR.

Thanks.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 17s	Docker mode activated.
-0 ⚠️	yetus	2m 36s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	shadedjars	4m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 10s	the patch passed
+1 💚	compile	2m 12s	the patch passed
+1 💚	javac	2m 12s	the patch passed
+1 💚	shadedjars	4m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 2s	the patch passed
		_ Other Tests _
-1 ❌	unit	239m 32s	root in the patch failed.
		315m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fd92cf64741c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/testReport/
Max. process+thread count	2643 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 28s	No case conflicting files found.
+0 🆗	shelldocs	0m 28s	Shelldocs was not available.
+0 🆗	markdownlint	0m 28s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 7s	master passed
+1 💚	compile	5m 49s	master passed
+1 💚	checkstyle	2m 47s	master passed
-0 ⚠️	mvnsite	1m 53s	root in master failed.
+0 🆗	refguide	1m 37s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	21m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	5m 49s	the patch passed
-0 ⚠️	javac	5m 49s	root generated 64 new + 1408 unchanged - 64 fixed = 1472 total (was 1472)
-0 ⚠️	checkstyle	2m 16s	root: The patch generated 2531 new + 3673 unchanged - 4920 fixed = 6204 total (was 8593)
+1 💚	mvnsite	8m 3s	the patch passed
+1 💚	pylint	0m 50s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 0s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 39s	The patch has no ill-formed XML file.
+0 🆗	refguide	1m 33s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 38s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	24m 22s	the patch passed
		_ Other Tests _
+1 💚	asflicense	5m 23s	The patch does not generate ASF License warnings.
		138m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux d2a558cd4d48 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-general-check/output/branch-mvnsite-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/6/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/6/yetus-general-check/output/patch-site/book.html
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 16s	Docker mode activated.
-0 ⚠️	yetus	2m 52s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 0s	master passed
+1 💚	compile	2m 52s	master passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 53s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	1m 49s	the patch passed
+1 💚	javac	1m 49s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	11m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	250m 12s	root in the patch passed.
		332m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cd6a37583ea1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/testReport/
Max. process+thread count	5019 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 28s	Docker mode activated.
-0 ⚠️	yetus	2m 59s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 22s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	5m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	5m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	12m 42s	the patch passed
		_ Other Tests _
-1 ❌	unit	372m 42s	root in the patch failed.
		456m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7b72bac1c455 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / f51e579
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/testReport/
Max. process+thread count	2296 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 9s	#4312 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/7/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 30s	No case conflicting files found.
+0 🆗	shelldocs	0m 30s	Shelldocs was not available.
+0 🆗	markdownlint	0m 30s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 7s	master passed
+1 💚	compile	5m 56s	master passed
+1 💚	checkstyle	2m 53s	master passed
-0 ⚠️	mvnsite	1m 54s	root in master failed.
+0 🆗	refguide	1m 39s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	21m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	6m 0s	the patch passed
-0 ⚠️	javac	6m 0s	root generated 76 new + 1396 unchanged - 76 fixed = 1472 total (was 1472)
-0 ⚠️	checkstyle	2m 21s	root: The patch generated 3183 new + 2869 unchanged - 5721 fixed = 6052 total (was 8590)
+1 💚	mvnsite	8m 11s	the patch passed
+1 💚	pylint	0m 52s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 0s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 39s	The patch has no ill-formed XML file.
+0 🆗	refguide	1m 36s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 39s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	25m 2s	the patch passed
		_ Other Tests _
+1 💚	asflicense	5m 33s	The patch does not generate ASF License warnings.
		143m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux 7fda904ed0c1 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 3e09e87
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/8/artifact/yetus-general-check/output/branch-mvnsite-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/8/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/8/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/8/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/8/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/8/yetus-general-check/output/patch-site/book.html
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/8/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Updated the PR. PTAL again? @bbeaudreault@ndimiduk Thanks~

[apurtell]

Spot checked some files, mostly lgtm but I am not a fan of this particular change:

someMethodWithParams(that, causes, the, line, to, become, too, long, and, used, to,
be, wrapped, like, this)

->

someMethodWithParams(that,
causes,
the,
line,
to,
become,
too,
long,
and,
used,
to,
be,
wrapped,
like,
this)

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 33s	No case conflicting files found.
+0 🆗	shelldocs	0m 33s	Shelldocs was not available.
+0 🆗	markdownlint	0m 33s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 42s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	7m 19s	master passed
+1 💚	checkstyle	3m 12s	master passed
-0 ⚠️	mvnsite	2m 28s	root in master failed.
+0 🆗	refguide	1m 57s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	27m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 56s	the patch passed
+1 💚	compile	9m 50s	the patch passed
-0 ⚠️	javac	9m 50s	root generated 387 new + 987 unchanged - 485 fixed = 1374 total (was 1472)
-0 ⚠️	checkstyle	2m 10s	root: The patch generated 467 new + 1346 unchanged - 7159 fixed = 1813 total (was 8505)
+1 💚	mvnsite	11m 41s	the patch passed
+1 💚	pylint	0m 57s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 1s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 58s	The patch has no ill-formed XML file.
+0 🆗	refguide	2m 27s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	15m 24s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotbugs	1m 39s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 ❌	spotbugs	8m 53s	root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	6m 20s	The patch does not generate ASF License warnings.
		180m 37s

Reason	Tests
FindBugs	module:hbase-server
	Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit) ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 169]
FindBugs	module:root
	Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit) ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:ignored in org.apache.hadoop.hbase.master.locking.LockManager$MasterLock.tryAcquire(long) At LockManager.java:[line 169]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux 9c1ef8be1031 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 242a194
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-general-check/output/branch-mvnsite-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/12/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/12/yetus-general-check/output/patch-site/book.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-general-check/output/new-spotbugs-root.html
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[ndimiduk]

Spot checked some files, mostly lgtm but I am not a fan of this particular change:

Agreed @apurtell , this is one of our points of discussion earlier in the thread (try to read between the buildbot spam).

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 0s	Docker mode activated.
-0 ⚠️	yetus	2m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	master passed
+1 💚	compile	2m 36s	master passed
+1 💚	shadedjars	4m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	13m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	15m 45s	the patch passed
		_ Other Tests _
-1 ❌	unit	325m 14s	root in the patch failed.
		408m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 73c4ab085f5c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 242a194
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/testReport/
Max. process+thread count	4945 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 48s	Docker mode activated.
-0 ⚠️	yetus	2m 16s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s	master passed
+1 💚	compile	2m 6s	master passed
+1 💚	shadedjars	4m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	11m 1s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 8s	hbase-checkstyle in the patch passed.
+1 💚	javadoc	0m 7s	hbase-annotations in the patch passed.
+1 💚	javadoc	0m 7s	hbase-build-configuration in the patch passed.
+1 💚	javadoc	0m 9s	hbase-logging in the patch passed.
+1 💚	javadoc	0m 8s	hbase-protocol-shaded in the patch passed.
+1 💚	javadoc	0m 13s	hbase-common in the patch passed.
+1 💚	javadoc	0m 8s	hbase-metrics-api in the patch passed.
+1 💚	javadoc	0m 9s	hbase-metrics in the patch passed.
+1 💚	javadoc	0m 12s	hbase-hadoop-compat in the patch passed.
+1 💚	javadoc	0m 17s	hbase-client in the patch passed.
+1 💚	javadoc	0m 10s	hbase-zookeeper in the patch passed.
+1 💚	javadoc	0m 10s	hbase-replication in the patch passed.
+1 💚	javadoc	0m 9s	hbase-balancer in the patch passed.
+1 💚	javadoc	0m 7s	hbase-resource-bundle in the patch passed.
+1 💚	javadoc	0m 12s	hbase-http in the patch passed.
+1 💚	javadoc	0m 10s	hbase-asyncfs in the patch passed.
+1 💚	javadoc	0m 9s	hbase-procedure in the patch passed.
+1 💚	javadoc	0m 27s	hbase-server generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1 💚	javadoc	0m 13s	hbase-mapreduce in the patch passed.
+1 💚	javadoc	0m 12s	hbase-testing-util in the patch passed.
+1 💚	javadoc	0m 28s	hbase-thrift in the patch passed.
+1 💚	javadoc	0m 10s	hbase-shell in the patch passed.
+1 💚	javadoc	0m 10s	hbase-endpoint in the patch passed.
+1 💚	javadoc	0m 14s	hbase-backup in the patch passed.
+1 💚	javadoc	0m 13s	hbase-it in the patch passed.
+1 💚	javadoc	0m 12s	hbase-rest in the patch passed.
+1 💚	javadoc	0m 15s	hbase-examples in the patch passed.
+1 💚	javadoc	0m 10s	hbase-shaded in the patch passed.
+1 💚	javadoc	0m 8s	hbase-shaded-client in the patch passed.
+1 💚	javadoc	0m 8s	hbase-shaded-client-byo-hadoop in the patch passed.
+1 💚	javadoc	0m 10s	hbase-shaded-mapreduce in the patch passed.
+1 💚	javadoc	0m 10s	hbase-external-blockcache in the patch passed.
+1 💚	javadoc	0m 10s	hbase-hbtop in the patch passed.
+1 💚	javadoc	0m 14s	hbase-compression in the patch passed.
+1 💚	javadoc	0m 12s	hbase-compression-aircompressor in the patch passed.
+1 💚	javadoc	0m 12s	hbase-compression-lz4 in the patch passed.
+1 💚	javadoc	0m 11s	hbase-compression-snappy in the patch passed.
+1 💚	javadoc	0m 10s	hbase-compression-xz in the patch passed.
+1 💚	javadoc	0m 11s	hbase-compression-zstd in the patch passed.
+1 💚	javadoc	0m 15s	hbase-assembly in the patch passed.
+1 💚	javadoc	0m 9s	hbase-shaded-testing-util in the patch passed.
+1 💚	javadoc	0m 7s	hbase-shaded-testing-util-tester in the patch passed.
+1 💚	javadoc	0m 8s	hbase-shaded-check-invariants in the patch passed.
+1 💚	javadoc	0m 8s	hbase-shaded-with-hadoop-check-invariants in the patch passed.
+1 💚	javadoc	0m 9s	hbase-archetypes in the patch passed.
+1 💚	javadoc	0m 9s	hbase-client-project in the patch passed.
+1 💚	javadoc	0m 11s	hbase-shaded-client-project in the patch passed.
+1 💚	javadoc	0m 8s	hbase-archetype-builder in the patch passed.
+1 💚	javadoc	1m 53s	root generated 0 new + 84 unchanged - 1 fixed = 84 total (was 85)
		_ Other Tests _
-1 ❌	unit	386m 51s	root in the patch failed.
		461m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cfdf55db70af 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 242a194
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/testReport/
Max. process+thread count	2472 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/12/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Spot checked some files, mostly lgtm but I am not a fan of this particular change:

Agreed @apurtell , this is one of our points of discussion earlier in the thread (try to read between the buildbot spam).

I do not get the point here... In the past we DO wrap the method calls like this

 a = func(b, c, d, e, f
g, h, i);

And in this issue you mentioned you do not like this style

https://issues.apache.org/jira/browse/HBASE-26617

 protected static final MiniClusterRule miniClusterRule = MiniClusterRule.newBuilder()
- .setMiniClusterOption(StartMiniClusterOption.builder()
- .numWorkers(3)
- .build())
- .build();
+ .setMiniClusterOption(StartMiniClusterOption.builder().numWorkers(3).build()).build();

So you only want to the chained method calls to be one call per line, but for the arguments, you still want them to keep the old style?

Just let me know. It is just a formatter config change...

Thanks.

[Apache9]

Ping @ndimiduk

[ndimiduk]

@Apache9 These are my preferences. I don't know how expressive the Eclipse Formatter configuration language is...

For method invocation arguments, I usually prefer as little whitespace as possible, wrapping only where necessary. Something like,

 foo(a, b, c, d, e, f,
g, h, i, j);

However, when invoking other methods as method (or commonly, constructor) parameters, I prefer a form with more whitespace,

 final foo = new Foo(
conf.get("foo_a_key", DEFAULT_A_VALUE),
callsiteParam.getFooBValue(),
...);

For method declarations, I follow two styles. For simple functions where declaring a parameter type and name doesn't use very many characters, I will do a "basic" version. But when the type parameter declarations take a lot of space, I prefer a style with more whitespace. So,

class Foo {
// a basic method declaration style style
public Foo(int a, boolean b, float c, ...) { ... }
// a style that uses more whitespace
public Foo(
final SomeType someType,
final SomeOtherType someOtherType,
...
) throws MyFavoriteException {
...
}
}

For method call chains with only a two method calls, I'm fine with keeping that to a single line. If there are many steps or steps that themselves wrap call chains, my preferences is one method call per line, with appropriate indentation. for example,

 // a simple one-liner
protected static final Foo foo = Foo().setA(a);
// a more complex example, where extra newlines improve readability.
protected static final MiniClusterRule miniClusterRule = MiniClusterRule.newBuilder()
.setMiniClusterOption(StartMiniClusterOption.builder()
.numWorkers(3)
.build())
.build();

[Apache9]

The eclipse formatter can not express the above things exactly, let me show you some examples.

This is Wrap where necessary

class Example {
void foo() {
Other.bar(100, nested(200, 300, 400,
500, 600, 700, 800, 900));
}
}

This is Wrap first element, others where necessary

class Example {
void foo() {
Other.bar(
100,
nested(
200, 300, 400, 500, 600, 700,
800, 900));
}
}

This is Wrap all elements, every element on a new line

class Example {
void foo() {
Other.bar(
100,
nested(
200,
300,
400,
500,
600,
700,
800,
900));
}
}

This is Wrap all elements, indent all but first element

class Example {
void foo() {
Other.bar(
100,
nested(
200,
300,
400,
500,
600,
700,
800,
900));
}
}

This is Wrap all elements, except first elemen if not necessary

class Example {
void foo() {
Other.bar(100,
nested(200,
300,
400,
500,
600,
700,
800,
900));
}
}

For me I think either we choose the first one, or the last one. The last one will have more lines but I think it is more clear if we have lots of arguments.

[Apache9]

So what's your guys decision? Seems there is no perfect format, let's choose a 'not bad' one?

Thanks. @ndimiduk@apurtell

[ndimiduk]

So what's your guys decision? Seems there is no perfect format, let's choose a 'not bad' one?

Thanks. @ndimiduk@apurtell

I'm not really satisfied by either -- the first is good for most scenarios but the last is better when there's lots of longer arguments. If I must choose one, I choose the first as it's likely the correct choice most of the time.

At this point, I wonder if it's worth it for us as a community to maintain our own custom style guidelines. Perhaps we should adopt the Google Java Style, use the Google Java Format Tool, and move on. The former is well known and familiar to most devs by this point, and also is mostly identical to what we already do as a community. The latter is supported by all the major built tools via spotless plugins, as well as by both major IDEs.

Thanks again, @Apache9, for spending time on this.

[Apache9]

So what's your guys decision? Seems there is no perfect format, let's choose a 'not bad' one?
Thanks. @ndimiduk@apurtell

I'm not really satisfied by either -- the first is good for most scenarios but the last is better when there's lots of longer arguments. If I must choose one, I choose the first as it's likely the correct choice most of the time.

At this point, I wonder if it's worth it for us as a community to maintain our own custom style guidelines. Perhaps we should adopt the Google Java Style, use the Google Java Format Tool, and move on. The former is well known and familiar to most devs by this point, and also is mostly identical to what we already do as a community. The latter is supported by all the major built tools via spotless plugins, as well as by both major IDEs.

Thanks again, @Apache9, for spending time on this.

Using google-java-format was my first proposal :)

See this thread:
https://lists.apache.org/thread/ognh01nt7hv4gy4cqj9grlgopj6t8tvl

[apurtell]

I would settle for 'wrap where necessary' unless you do want to move right away to a different formatter. "Wrap where necessary" is very common in our code base already. All the other alternatives are not as good, IMHO. (Unless we move to a different tool.) @ndimiduk@Apache9

[Apache9]

OK, I think the winner is 'wrap where necessary'. Let me change the formatter file and update the PR here.

And let me post an email in the dev list about this change, to receive more feedbacks before finally merging the PR. This is a very huge change on our code base, and will have long term effect, so I think we should be patient.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 37s	No case conflicting files found.
+0 🆗	shelldocs	0m 38s	Shelldocs was not available.
+0 🆗	markdownlint	0m 38s	markdownlint was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 51s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s	master passed
+1 💚	compile	7m 27s	master passed
+1 💚	checkstyle	4m 57s	master passed
-0 ⚠️	mvnsite	2m 7s	root in master failed.
+0 🆗	refguide	1m 37s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	21m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	5m 51s	the patch passed
-0 ⚠️	javac	5m 51s	root generated 391 new + 984 unchanged - 489 fixed = 1375 total (was 1473)
-0 ⚠️	checkstyle	1m 23s	root: The patch generated 475 new + 1347 unchanged - 7160 fixed = 1822 total (was 8507)
+1 💚	mvnsite	8m 5s	the patch passed
+1 💚	pylint	0m 56s	The patch generated 0 new + 1122 unchanged - 3 fixed = 1122 total (was 1125)
+1 💚	shellcheck	0m 3s	There were no new shellcheck issues.
-0 ⚠️	whitespace	0m 0s	The patch 30 line(s) with tabs.
+1 💚	xml	0m 40s	The patch has no ill-formed XML file.
+0 🆗	refguide	1m 33s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 10s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	24m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	5m 35s	The patch does not generate ASF License warnings.
		150m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	dupname asflicense shellcheck shelldocs xml markdownlint javac hadoopcheck compile spotbugs hbaseanti checkstyle refguide pylint mvnsite
uname	Linux 1e382cc25a50 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / af13c6d
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvnsite	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-general-check/output/branch-mvnsite-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/13/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-general-check/output/whitespace-tabs.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4312/13/yetus-general-check/output/patch-site/book.html
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 pylint=2.4.4
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 17s	Docker mode activated.
-0 ⚠️	yetus	2m 9s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	2m 22s	master passed
+1 💚	shadedjars	4m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	13m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	2m 10s	the patch passed
+1 💚	javac	2m 10s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	16m 7s	the patch passed
		_ Other Tests _
-1 ❌	unit	323m 40s	root in the patch failed.
		405m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f6d174f3e3f4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / af13c6d
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/testReport/
Max. process+thread count	5148 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 17s	Docker mode activated.
-0 ⚠️	yetus	2m 20s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	2m 6s	master passed
+1 💚	shadedjars	4m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	11m 13s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	2m 17s	the patch passed
+1 💚	javac	2m 17s	the patch passed
+1 💚	shadedjars	4m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 8s	hbase-checkstyle in the patch passed.
+1 💚	javadoc	0m 9s	hbase-annotations in the patch passed.
+1 💚	javadoc	0m 7s	hbase-build-configuration in the patch passed.
+1 💚	javadoc	0m 8s	hbase-logging in the patch passed.
+1 💚	javadoc	0m 9s	hbase-protocol-shaded in the patch passed.
+1 💚	javadoc	0m 14s	hbase-common in the patch passed.
+1 💚	javadoc	0m 8s	hbase-metrics-api in the patch passed.
+1 💚	javadoc	0m 9s	hbase-metrics in the patch passed.
+1 💚	javadoc	0m 11s	hbase-hadoop-compat in the patch passed.
+1 💚	javadoc	0m 16s	hbase-client in the patch passed.
+1 💚	javadoc	0m 10s	hbase-zookeeper in the patch passed.
+1 💚	javadoc	0m 10s	hbase-replication in the patch passed.
+1 💚	javadoc	0m 9s	hbase-balancer in the patch passed.
+1 💚	javadoc	0m 7s	hbase-resource-bundle in the patch passed.
+1 💚	javadoc	0m 11s	hbase-http in the patch passed.
+1 💚	javadoc	0m 10s	hbase-asyncfs in the patch passed.
+1 💚	javadoc	0m 10s	hbase-procedure in the patch passed.
+1 💚	javadoc	0m 25s	hbase-server generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1 💚	javadoc	0m 13s	hbase-mapreduce in the patch passed.
+1 💚	javadoc	0m 13s	hbase-testing-util in the patch passed.
+1 💚	javadoc	0m 25s	hbase-thrift in the patch passed.
+1 💚	javadoc	0m 10s	hbase-shell in the patch passed.
+1 💚	javadoc	0m 10s	hbase-endpoint in the patch passed.
+1 💚	javadoc	0m 12s	hbase-backup in the patch passed.
+1 💚	javadoc	0m 13s	hbase-it in the patch passed.
+1 💚	javadoc	0m 13s	hbase-rest in the patch passed.
+1 💚	javadoc	0m 16s	hbase-examples in the patch passed.
+1 💚	javadoc	0m 9s	hbase-shaded in the patch passed.
+1 💚	javadoc	0m 8s	hbase-shaded-client in the patch passed.
+1 💚	javadoc	0m 9s	hbase-shaded-client-byo-hadoop in the patch passed.
+1 💚	javadoc	0m 10s	hbase-shaded-mapreduce in the patch passed.
+1 💚	javadoc	0m 11s	hbase-external-blockcache in the patch passed.
+1 💚	javadoc	0m 12s	hbase-hbtop in the patch passed.
+1 💚	javadoc	0m 18s	hbase-compression in the patch passed.
+1 💚	javadoc	0m 12s	hbase-compression-aircompressor in the patch passed.
+1 💚	javadoc	0m 11s	hbase-compression-brotli in the patch passed.
+1 💚	javadoc	0m 10s	hbase-compression-lz4 in the patch passed.
+1 💚	javadoc	0m 12s	hbase-compression-snappy in the patch passed.
+1 💚	javadoc	0m 10s	hbase-compression-xz in the patch passed.
+1 💚	javadoc	0m 9s	hbase-compression-zstd in the patch passed.
+1 💚	javadoc	0m 11s	hbase-assembly in the patch passed.
+1 💚	javadoc	0m 8s	hbase-shaded-testing-util in the patch passed.
+1 💚	javadoc	0m 7s	hbase-shaded-testing-util-tester in the patch passed.
+1 💚	javadoc	0m 7s	hbase-shaded-check-invariants in the patch passed.
+1 💚	javadoc	0m 9s	hbase-shaded-with-hadoop-check-invariants in the patch passed.
+1 💚	javadoc	0m 12s	hbase-archetypes in the patch passed.
+1 💚	javadoc	0m 11s	hbase-client-project in the patch passed.
+1 💚	javadoc	0m 8s	hbase-shaded-client-project in the patch passed.
+1 💚	javadoc	0m 8s	hbase-archetype-builder in the patch passed.
-0 ⚠️	javadoc	1m 52s	root generated 8 new + 75 unchanged - 10 fixed = 83 total (was 85)
		_ Other Tests _
-1 ❌	unit	385m 25s	root in the patch failed.
		458m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4312
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 78460c5b2bba 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / af13c6d
Default Java	AdoptOpenJDK-1.8.0_282-b08
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/testReport/
Max. process+thread count	2091 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4312/13/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Seems no big concerns from the community on the mailing list.

Then let's go with wrap where necessary?

Since the PR will have conflicts soon after there are new commits coming in as it touch almost all the files, I plan to just push it through command line after executing 'mvn spotless:apply' locally.

Plan to do it on Sunday. Shout if you guys have any concerns.

Thanks @apurtell@ndimiduk@bbeaudreault for helping here!

[ndimiduk]

Thank you @Apache9 for landing this effort!