Skip to content

HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while th… - #4333

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-26941
Apr 13, 2022
Merged

HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while th…#4333
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-26941

Conversation

@Apache9

@Apache9Apache9 commented Apr 9, 2022

Copy link
Copy Markdown
Contributor

…read is interrupted

@Apache9Apache9 self-assigned this Apr 9, 2022
@Apache9

Apache9 commented Apr 9, 2022

Copy link
Copy Markdown
ContributorAuthor

Since this is usually used in UT I think a better way is to just throw the exception out and let the callers deal with it.

Some modified classes are marked IA.LimitedPrivate, so it is not suitable to be backported to branch-2.4. I think either we just ignore this change on branch-2.4 or we prepare a special patch for branch-2.4. But in fact I do not know what is the suitable way to fix this without throwing exception out, as if the thread is interrupted, Thread.sleep will be useless too...

@busbey FYI. This is why we eat all the spaces on some jenkins node.

@Apache-HBase

Apache-HBase commented Apr 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 42smaster passed
+1 💚compile4m 9smaster passed
+1 💚checkstyle1m 4smaster passed
+1 💚spotbugs2m 45smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile4m 2sthe patch passed
+1 💚javac4m 2sthe patch passed
+1 💚checkstyle1m 2sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 15sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs3m 1sthe patch passed
_ Other Tests _
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
49m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4333
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 7a0f6329c70e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3ae0d90
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall2m 16smaster passed
+1 💚compile0m 45smaster passed
+1 💚shadedjars3m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 59sthe patch passed
+1 💚compile0m 44sthe patch passed
+1 💚javac0m 44sthe patch passed
+1 💚shadedjars3m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29sthe patch passed
_ Other Tests _
+1 💚unit183m 42shbase-server in the patch passed.
+1 💚unit1m 20shbase-testing-util in the patch passed.
202m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4333
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fdea91a1a1b9 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3ae0d90
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/testReport/
Max. process+thread count3369 (vs. ulimit of 30000)
modulesC: hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall4m 14smaster passed
+1 💚compile1m 13smaster passed
+1 💚shadedjars4m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile1m 24sthe patch passed
+1 💚javac1m 24sthe patch passed
+1 💚shadedjars5m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 46sthe patch passed
_ Other Tests _
+1 💚unit207m 40shbase-server in the patch passed.
+1 💚unit1m 32shbase-testing-util in the patch passed.
234m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4333
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a339efc8ac50 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3ae0d90
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/testReport/
Max. process+thread count2702 (vs. ulimit of 30000)
modulesC: hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ddupg
ddupg approved these changes Apr 12, 2022
View reviewed changes

@ddupgddupg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9
Apache9 merged commit 8247b7c into apache:masterApr 13, 2022
Apache9 added a commit that referenced this pull request Apr 13, 2022
@Apache9
HBASE-26941LocalHBaseCluster.waitOnRegionServer should quit while th…
c10e4bd
…read is interrupted (#4333)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
Apache9 added a commit that referenced this pull request Apr 13, 2022
@Apache9
HBASE-26941LocalHBaseCluster.waitOnRegionServer should quit while th…
29ce27c
…read is interrupted (#4333)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
Apache9 added a commit that referenced this pull request Apr 13, 2022
@Apache9
HBASE-26941LocalHBaseCluster.waitOnRegionServer should quit while th…
f8b2ac0
…read is interrupted (#4333)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
Apache9 added a commit that referenced this pull request Apr 13, 2022
@Apache9
Revert "HBASE-26941LocalHBaseCluster.waitOnRegionServer should quit …
1fc1866
…while thread is interrupted (#4333)"
This reverts commit c10e4bd.
Apache9 added a commit that referenced this pull request Apr 13, 2022
@Apache9
Revert "HBASE-26941LocalHBaseCluster.waitOnRegionServer should quit …
785a546
…while thread is interrupted (#4333)"
This reverts commit 29ce27c.
Apache9 added a commit that referenced this pull request Apr 13, 2022
@Apache9
Revert "HBASE-26941LocalHBaseCluster.waitOnRegionServer should quit …
b405a6f
…while thread is interrupted (#4333)"
This reverts commit f8b2ac0.
Apache9 added a commit that referenced this pull request Apr 13, 2022
@Apache9
Revert "HBASE-26941LocalHBaseCluster.waitOnRegionServer should quit …
b7ffb56
…while thread is interrupted (#4333)"
This reverts commit 8247b7c.
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9
HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while th…
706d305
…read is interrupted (apache#4333)
Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
(cherry picked from commit c10e4bd)
Change-Id: I3816ce2364a96fb7ca4cd2fe6090a239677b31cb
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9
Revert "HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit …
a3e86d7
…while thread is interrupted (apache#4333)"
This reverts commit c10e4bd.
(cherry picked from commit 1fc1866)
Change-Id: I5b90b9ebe1ff9ded85b68513f3c931b061e46642
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddupgddupgddupg approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@ddupg