Uh oh!
There was an error while loading. Please reload this page.
HBASE-26943 HMaster page style display confusion - #4336
Conversation
Apache-HBase
commented
Apr 11, 2022
🎊 +1 overall
This message was automatically generated. |
carp84
left a comment
There was a problem hiding this comment.
Thanks for the contribution @2005hithlj . I have two questions about the current PR:
- The content of the changed file (i.e.
bootstrap.min.css) seems to be a one-liner (lack of normal line breakers). It's really hard to tell the real change according to the commit history, so I would suggest to split this PR into two commits: one for formatting and the other containing the real, easy-to-tell change to fix the margin-top issue. - The version of
normalize.cssinbootstrap.min.cssis3.0.3, which is released on March 15th, 2015 and the latest version is already8.0.1. Have you ever tried to use the latest version and see whether the problem could be resolved?
And to be explicit, I think the first point is better to resolve, while the second is nice to have.
Please feel free to let me know your thoughts.
Apache-HBase
commented
Apr 11, 2022
💔 -1 overall
This message was automatically generated. |
2005hithlj
commented
Apr 12, 2022
Yes, upgrade normalize.css version needs a lot of compatibility tests. |
2005hithlj
commented
Apr 12, 2022
I have formatted bootstrap.min.css, @carp84 please review it, thanks. |
Apache-HBase
commented
Apr 12, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 12, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 12, 2022
💔 -1 overall
This message was automatically generated. |
carp84
commented
Apr 13, 2022
The work is completed through #4341 |
https://issues.apache.org/jira/browse/HBASE-26943