Skip to content

HBASE-26960 Another case for unnecessary replication suspending in Re… - #4355

Merged
comnetwork merged 3 commits into
apache:masterfrom
comnetwork:ignoreflush
Apr 30, 2022
Merged

HBASE-26960 Another case for unnecessary replication suspending in Re…#4355
comnetwork merged 3 commits into
apache:masterfrom
comnetwork:ignoreflush

Conversation

@comnetwork

@comnetworkcomnetwork commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

…gionReplicationSink

@Apache-HBase

Apache-HBase commented Apr 19, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 15smaster passed
+1 💚compile2m 48smaster passed
+1 💚checkstyle0m 39smaster passed
+1 💚spotbugs1m 30smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile2m 35sthe patch passed
+1 💚javac2m 35sthe patch passed
+1 💚checkstyle0m 38sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 31sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs2m 4sthe patch passed
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
43m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4355
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 164cdef935b4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 35aa57e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 19, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 42smaster passed
+1 💚compile0m 41smaster passed
+1 💚shadedjars3m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 25sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚shadedjars3m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
+1 💚unit173m 44shbase-server in the patch passed.
191m 9s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4355
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 506c337fc0d0 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 35aa57e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/testReport/
Max. process+thread count3503 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 19, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 46sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 17smaster passed
+1 💚compile0m 52smaster passed
+1 💚shadedjars4m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile0m 44sthe patch passed
+1 💚javac0m 44sthe patch passed
+1 💚shadedjars4m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26sthe patch passed
_ Other Tests _
+1 💚unit192m 59shbase-server in the patch passed.
215m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4355
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9a53d5a5af1e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 35aa57e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/testReport/
Max. process+thread count2546 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@comnetwork
comnetwork requested a review from Apache9April 20, 2022 02:27
@Apache9

Apache9 commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

This will cause we write extra data in WAL.

Maybe a more lightweight solution is to call RegionReplicationSink.add even when writeFlushWalMarker is false?

@comnetwork

comnetwork commented Apr 21, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@Apache9 , RegionReplicationSink.add is invoked by MultiVersionConcurrencyControl.complete(WriteEntry), so it seems not very elegant and somewhat tricky to not write WAL but still invoke RegionReplicationSink.add.

I think an alternative is we could add an overload MemStoreFlusher.requestFlush to accept the writeFlushRequestWalMarker paramter which is only used by RegionReplicationSink, just some modifications for MemStoreFlusher, I think seems it is more suitable than doing some trick to not write WAL but still invoke RegionReplicationSink.add?

@Apache9

Apache9 commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

@Apache9 , RegionReplicationSink.add is invoked by MultiVersionConcurrencyControl.complete(WriteEntry), so it seems not very elegant and somewhat tricky to not write WAL but still invoke RegionReplicationSink.add.

I think we could add an overload MemStoreFlusher.requestFlush to accept the writeFlushRequestWalMarker paramter，just some modifications for {{MemStoreFlusher}}, I think seems it is more suitable than doing some trick to not write WAL but still invoke RegionReplicationSink.add?

I think it is OK to not write the WAL but still add it to RegionReplicationSink.

A problem for the old implementation of region replication is that, if users use SKIP_WAL, then we can not do region replication any more. WIth the current approach, since we do not need to read WAL from the file, it is OK for us to send out WAL even if we do not want to write the WAL to file.

This one could a start. Later we could also try to see if the actual data WAL can be replicated when SKIP_WAL is used.

Thanks.

@Apache9

Apache9 commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

OK, checked the code again, the problem here is that, if we do not write WAL, then we will not have a MVCC.WriteEntry then we can not use WriteEntry.attachCompletionAction trick.

This is a problem. Let me think if there is a way to fix this.

Thanks.

@comnetwork

comnetwork commented Apr 21, 2022

Copy link
Copy Markdown
ContributorAuthor

@Apache9, thank you very much , ok, I think we could also add a MVCC entry to maintain the MVCC order to invoke the RegionReplicationSink.add?

@Apache9

Apache9 commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

Oh, at least for calling writeFlushRequestMarkerToWAL, we do have a MVCC.WriteEntry...

So let's pass it in to the method and also add the WALEntry to RegionReplicationSink.

And for the normal updates, we will not build the WALEntry, and we will create a MVCC WriteEntry when applying updates to memstore, in MutationBatchOperation.writeMiniBatchOperationsToMemStore. FWIW, we always need a MVCC WriteEntry to finish a write operation. So I think it is possible to also replicate the edits to secondary replicas even if we set SKIP_WAL. Anyway, should be another issue.

Thanks.

@comnetwork

comnetwork commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@Apache9 ,thank you very much for reply.

Oh, at least for calling writeFlushRequestMarkerToWAL, we do have a MVCC.WriteEntry...

So let's pass it in to the method and also add the WALEntry to RegionReplicationSink.

You mean we use the following line 2793 outside the writeFlushRequestMarkerToWAL?

2792 if (wal != null) {
2793 writeEntry = mvcc.begin();
2794 long flushOpSeqId = writeEntry.getWriteNumber();
2795 FlushResultImpl flushResult =
2796 new FlushResultImpl(FlushResult.Result.CANNOT_FLUSH_MEMSTORE_EMPTY, flushOpSeqId,
2797 "Nothing to flush", writeFlushRequestMarkerToWAL(wal, writeFlushWalMarker));
2798 mvcc.completeAndWait(writeEntry);
2799 // Set to null so we don't complete it again down in finally block.
2800 writeEntry = null;
2801 return new PrepareFlushResult(flushResult, myseqid);

@comnetwork

comnetwork commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

And for the normal updates, we will not build the WALEntry, and we will create a MVCC WriteEntry when applying updates to memstore, in MutationBatchOperation.writeMiniBatchOperationsToMemStore. FWIW, we always need a MVCC WriteEntry to finish a write operation. So I think it is possible to also replicate the edits to secondary replicas even if we set SKIP_WAL. Anyway, should be another issue.

@Apache9 , I open a new jira HBASE-26993 to try to work on this problem.

@Apache-HBase

Apache-HBase commented Apr 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 56smaster passed
+1 💚compile2m 55smaster passed
+1 💚checkstyle0m 42smaster passed
+1 💚spotbugs1m 44smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile3m 3sthe patch passed
+1 💚javac3m 3sthe patch passed
+1 💚checkstyle0m 43sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 48sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs1m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
37m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4355
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 1381c595d6ba 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebfac21
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count67 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 58sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 33smaster passed
+1 💚compile0m 36smaster passed
+1 💚shadedjars4m 35sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 31smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 20sthe patch passed
+1 💚compile0m 35sthe patch passed
+1 💚javac0m 35sthe patch passed
+1 💚shadedjars4m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sthe patch passed
_ Other Tests _
+1 💚unit184m 57shbase-server in the patch passed.
203m 54s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4355
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 33d6176d7a0c 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebfac21
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/testReport/
Max. process+thread count2598 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 approved these changes Apr 29, 2022
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* @return whether WAL write was successful
*/
private boolean writeFlushRequestMarkerToWAL(WAL wal, boolean writeFlushWalMarker) {
private boolean writeCanNotFlushMarkerToWAL(WriteEntry flushOpSeqIdMVCCEntry, WAL wal,

@Apache9Apache9Apr 29, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. The new method name is better.

@Apache-HBase

Apache-HBase commented Apr 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 54smaster passed
+1 💚compile0m 45smaster passed
+1 💚shadedjars3m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 37sthe patch passed
+1 💚compile0m 44sthe patch passed
+1 💚javac0m 44sthe patch passed
+1 💚shadedjars3m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26sthe patch passed
_ Other Tests _
+1 💚unit199m 26shbase-server in the patch passed.
218m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4355
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 73c3ea812a81 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebfac21
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/testReport/
Max. process+thread count2684 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 28smaster passed
+1 💚compile2m 33smaster passed
+1 💚checkstyle0m 43smaster passed
+1 💚spotbugs1m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 7sthe patch passed
+1 💚compile2m 54sthe patch passed
+1 💚javac2m 54sthe patch passed
+1 💚checkstyle0m 45sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 53sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs1m 42sthe patch passed
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
36m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4355
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux cff7943dc703 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebfac21
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 39smaster passed
+1 💚compile0m 40smaster passed
+1 💚shadedjars3m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 23sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚shadedjars3m 40spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit173m 26shbase-server in the patch passed.
189m 48s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4355
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c211c360404c 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebfac21
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/testReport/
Max. process+thread count2941 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 28smaster passed
+1 💚compile0m 40smaster passed
+1 💚shadedjars3m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 13sthe patch passed
+1 💚compile0m 38sthe patch passed
+1 💚javac0m 38sthe patch passed
+1 💚shadedjars3m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit189m 31shbase-server in the patch passed.
206m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4355
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0a8a867acd47 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ebfac21
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/testReport/
Max. process+thread count3119 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@comnetwork
comnetwork merged commit f5a566e into apache:masterApr 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@comnetwork@Apache-HBase@Apache9