Skip to content

HBASE-26975 Add on heap and off heap memstore info in rs web UI - #4368

Merged
Apache9 merged 1 commit into
apache:masterfrom
liangxs:HBASE-26975
Apr 28, 2022
Merged

HBASE-26975 Add on heap and off heap memstore info in rs web UI#4368
Apache9 merged 1 commit into
apache:masterfrom
liangxs:HBASE-26975

Conversation

@liangxs

@liangxsliangxs commented Apr 25, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/HBASE-26975

There are Memstore Size and Memstore Limit info in rs-status page.

The information is a little coarse granularity and confusing:

  • Memstore Size means memstore data size, but we cannot tell the difference of on heap and off heap memstore data size.
  • Memstore Limit is off heap memstore limit if off-heap is enabled, otherwise, it is on heap memstore limit.

We should provide more detailed information.

@liangxs

liangxs commented Apr 25, 2022

Copy link
Copy Markdown
ContributorAuthor

The rs page without off heap memstore:

image



The rs page with off heap memstore:

image

@Apache-HBase

Apache-HBase commented Apr 25, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 27smaster passed
+1 💚compile2m 34smaster passed
+1 💚checkstyle0m 46smaster passed
+1 💚spotbugs1m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile2m 33sthe patch passed
+1 💚javac2m 33sthe patch passed
+1 💚checkstyle0m 45sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 51sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs1m 49sthe patch passed
_ Other Tests _
+1 💚asflicense0m 19sThe patch does not generate ASF License warnings.
33m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4368
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 464d643d9429 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f5b10e0
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 25, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 58smaster passed
+1 💚compile0m 45smaster passed
+1 💚shadedjars3m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile0m 45sthe patch passed
+1 💚javac0m 45sthe patch passed
+1 💚shadedjars3m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 31sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-hadoop-compat in the patch passed.
+1 💚unit182m 58shbase-server in the patch passed.
201m 21s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4368
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7ad541eb45b9 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f5b10e0
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/testReport/
Max. process+thread count2991 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 25, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall2m 55smaster passed
+1 💚compile0m 54smaster passed
+1 💚shadedjars4m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 41sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars4m 3spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 35shbase-hadoop-compat in the patch passed.
+1 💚unit188m 6shbase-server in the patch passed.
208m 59s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4368
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7d06fc5a09db 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f5b10e0
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/testReport/
Max. process+thread count2780 (vs. ulimit of 30000)
modulesC: hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4368/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit cdf81ea into apache:masterApr 28, 2022
Apache9 pushed a commit that referenced this pull request Apr 28, 2022
@liangxs@Apache9
HBASE-26975Add on heap and off heap memstore info in rs web UI (#4368)
895e0f4
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit cdf81ea)
Apache9 pushed a commit that referenced this pull request Apr 28, 2022
@liangxs@Apache9
HBASE-26975Add on heap and off heap memstore info in rs web UI (#4368)
27c3584
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit cdf81ea)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liangxs@Apache-HBase@Apache9