Skip to content

HBASE-26983 Upgrade JRuby to 9.3.4.0 - #4378

Merged
busbey merged 1 commit into
apache:masterfrom
busbey:HBASE-26983
Jun 5, 2022
Merged

HBASE-26983 Upgrade JRuby to 9.3.4.0#4378
busbey merged 1 commit into
apache:masterfrom
busbey:HBASE-26983

Conversation

@busbey

@busbeybusbey commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@busbey

busbey commented Apr 28, 2022

Copy link
Copy Markdown
ContributorAuthor

I'm having trouble running unit tests locally. please wait to merge.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
petersomogyi
petersomogyi reviewed May 2, 2022
View reviewed changes

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The java_kind_of? expression was removed in 9.3.0.0 so this line needs to be updated: https://github.com/apache/hbase/blob/master/hbase-shell/src/main/ruby/hbase/security.rb#L185

jruby/jruby#6862

Comment threadpom.xml
<glassfish.jsp.version>2.3.2</glassfish.jsp.version>
<glassfish.el.version>3.0.1-b08</glassfish.el.version>
<jruby.version>9.2.13.0</jruby.version>
<jruby.version>9.3.4.0</jruby.version>

@petersomogyipetersomogyiMay 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The joni/jcoding versions might need to be updated as well. See the comment on line 818.

@busbey
HBASE-26983 Upgrade JRuby to 9.3.4.0
cd36d57
- Update JRuby
- Replace java_kind_of since it has been removed
- update jcoding / joni to match jruby
@Apache-HBase

Apache-HBase commented May 29, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 22smaster passed
+1 💚compile6m 10smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 14sthe patch passed
+1 💚compile6m 6sthe patch passed
+1 💚javac6m 6sthe patch passed
-0 ⚠️rubocop0m 4sThe patch generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 46sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
37m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4378
Optional Testsdupname asflicense javac spotless rubocop hadoopcheck xml compile
unameLinux 83bd675c4cc2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cf0ed2e
Default JavaAdoptOpenJDK-1.8.0_282-b08
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count139 (vs. ulimit of 30000)
modulesC: hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/console
versionsgit=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 29, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall2m 47smaster passed
+1 💚compile1m 50smaster passed
+1 💚shadedjars3m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 30sthe patch passed
+1 💚compile1m 50sthe patch passed
+1 💚javac1m 50sthe patch passed
+1 💚shadedjars3m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 4sthe patch passed
_ Other Tests _
-1 ❌unit212m 59sroot in the patch failed.
236m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4378
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8b1b59fde503 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cf0ed2e
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/testReport/
Max. process+thread count2574 (vs. ulimit of 30000)
modulesC: hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 29, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 55sMaven dependency ordering for branch
+1 💚mvninstall3m 5smaster passed
+1 💚compile1m 26smaster passed
+1 💚shadedjars3m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 28smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 5sthe patch passed
+1 💚compile1m 24sthe patch passed
+1 💚javac1m 24sthe patch passed
+1 💚shadedjars3m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 25sthe patch passed
_ Other Tests _
-1 ❌unit341m 51sroot in the patch failed.
364m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4378
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a211e970eedb 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cf0ed2e
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/testReport/
Max. process+thread count3629 (vs. ulimit of 30000)
modulesC: hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@busbey

busbey commented May 29, 2022

Copy link
Copy Markdown
ContributorAuthor

the unit tests passed in the hbase-shell module. the failures that happened in other modules for the most part are some class not found exceptions around leveldbjni. sounds like maybe fall out from HBASE-27065 (fyi @apurtell )

@busbey
busbey requested a review from petersomogyiMay 29, 2022 23:52
@Apache-HBase

Apache-HBase commented May 31, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 17smaster passed
-1 ❌compile1m 0sroot in master failed.
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile6m 11sthe patch passed
-0 ⚠️javac6m 11sroot generated 1373 new + 2 unchanged - 0 fixed = 1375 total (was 2)
-0 ⚠️rubocop0m 3sThe patch generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 34sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
31m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4378
Optional Testsdupname asflicense javac spotless rubocop hadoopcheck xml compile
unameLinux f865d6e3e003 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ce85aa
Default JavaAdoptOpenJDK-1.8.0_282-b08
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/branch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count138 (vs. ulimit of 30000)
modulesC: hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/console
versionsgit=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 31, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall2m 30smaster passed
+1 💚compile1m 49smaster passed
+1 💚shadedjars3m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 32sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars3m 38spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 5sthe patch passed
_ Other Tests _
-1 ❌unit212m 49sroot in the patch failed.
236m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4378
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8dfb2ac4c74c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ce85aa
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/testReport/
Max. process+thread count2958 (vs. ulimit of 30000)
modulesC: hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 31, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 57sMaven dependency ordering for branch
+1 💚mvninstall3m 26smaster passed
+1 💚compile1m 29smaster passed
+1 💚shadedjars4m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 34smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile1m 27sthe patch passed
+1 💚javac1m 27sthe patch passed
+1 💚shadedjars3m 58spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 7shbase-shell in the patch passed.
+1 💚javadoc1m 23sroot generated 0 new + 83 unchanged - 1 fixed = 83 total (was 84)
_ Other Tests _
-1 ❌unit374m 59sroot in the patch failed.
398m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4378
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a2507c5f8935 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4ce85aa
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/testReport/
Max. process+thread count3796 (vs. ulimit of 30000)
modulesC: hbase-shell . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4378/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@busbey
busbey merged commit d1149f7 into apache:masterJun 5, 2022
@busbey
busbey deleted the HBASE-26983 branch June 5, 2022 05:16
busbey added a commit that referenced this pull request Jun 5, 2022
@busbey
HBASE-26983Upgrade JRuby to 9.3.4.0 (#4378)
bb8b80e
- Update JRuby
- Replace java_kind_of since it has been removed
- update jcoding / joni to match jruby
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit d1149f7)
wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
@busbey@wenwj0
HBASE-26983 Upgrade JRuby to 9.3.4.0 (apache#4378)
f29f669
- Update JRuby
- Replace java_kind_of since it has been removed
- update jcoding / joni to match jruby
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
@wenwj0
Revert "HBASE-26983 Upgrade JRuby to 9.3.4.0 (apache#4378)"
cd3de95
This reverts commit f29f669.
udaynpusa pushed a commit to mapr/hbase that referenced this pull request Jan 30, 2024
@busbey@sercanCyberVision
HBASE-26983 Upgrade JRuby to 9.3.4.0 (apache#4378)
56fff9c
- Update JRuby
- Replace java_kind_of since it has been removed
- update jcoding / joni to match jruby
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit d1149f7)
szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Aug 16, 2024
@busbeyVillő Szűcs
CDPD-73214: HBASE-26983 Upgrade JRuby to 9.3.4.0 (apache#4378)
1934999
- Update JRuby
- Replace java_kind_of since it has been removed
- update jcoding / joni to match jruby
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit d1149f7)
Change-Id: I586c02263dbec0fbfc653a3c650cd2f94c329e90
szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Sep 9, 2024
@busbeyVillő Szűcs
CDPD-73214: Backport HBASE-26983 Upgrade JRuby to 9.3.4.0 (apache#4378)
4696222
- Update JRuby
- Replace java_kind_of since it has been removed
- update jcoding / joni to match jruby
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit d1149f7)
Change-Id: I586c02263dbec0fbfc653a3c650cd2f94c329e90
(cherry picked from commit 1934999)
mapr-devops pushed a commit to mapr/hbase that referenced this pull request May 8, 2025
@busbey@sercanCyberVision
HBASE-26983 Upgrade JRuby to 9.3.4.0 (apache#4378)
3f355d1
- Update JRuby
- Replace java_kind_of since it has been removed
- update jcoding / joni to match jruby
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit d1149f7)
(cherry picked from commit ca6f73792ac3a16a4810b9b372dc99452829f363)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@busbey@Apache-HBase@petersomogyi