Uh oh!
There was an error while loading. Please reload this page.
HBASE-26989 TestStochasticLoadBalancer fixes for performance and consistency - #4385
Merged
Conversation
Apache-HBase
commented
Apr 29, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 29, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 29, 2022
🎊 +1 overall
This message was automatically generated. |
| //reset config | ||
| conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", minCost); | ||
| conf.unset(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE); | ||
| conf.setBoolean(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE, oldIsByTable); |
Contributor
There was a problem hiding this comment.
@d-c-manning Instead of resetting the conf object in every method's finally block, can we reset the conf object to some default values in a method which is annotated After ?
ContributorAuthor
There was a problem hiding this comment.
@shahrs87 I can try that. I would probably try it in the base class with a @Before annotation to ensure that we restore state before each test. That is sort of in line with the @BeforeClass that currently exists. It will make the PR much bigger, though, as this style of conf updates pre-exists my tests.
ContributorAuthor
There was a problem hiding this comment.
It would require #4384 but since that is merged now, I guess we can try.
ContributorAuthor
There was a problem hiding this comment.
I couldn't put it in the base class, because other subclasses override the beforeAllTests with their own BeforeClass version. It's probably for the best anyway, to keep the scope of the change more limited.
ContributorAuthor
There was a problem hiding this comment.
@shahrs87 I made the change. It's best viewed by using the "hide whitespace" feature in github, because of the removal of try blocks. I think it cleans up this test class nicely, even though it's a bigger scoped change. Thanks for the recommendation!
shahrs87
approved these changes
Apr 29, 2022
shahrs87
left a comment
Contributor
There was a problem hiding this comment.
+1 assuming jenkins is green. Thank you @d-c-manning
Apache-HBase
commented
Apr 30, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 30, 2022
🎊 +1 overall
This message was automatically generated. |
apurtell
commented
May 2, 2022
Contributor
@d-c-manning Please resolve conflicts and I will merge it. |
asfgit pushed a commit
that referenced
this pull request
May 2, 2022
…istency (#4385) Signed-off-by: Andrew Purtell <apurtell@apache.org> Reviewed by: Rushabh Shah <shahrs87@gmail.com> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
asfgit pushed a commit
that referenced
this pull request
May 2, 2022
…istency (#4385) Signed-off-by: Andrew Purtell <apurtell@apache.org> Reviewed by: Rushabh Shah <shahrs87@gmail.com> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-26989
When running the tests locally, I see these runtime improvements:
testNeedBalance: from 120 seconds to 11 secondstestSloppyTablesLoadBalanceByTable27 seconds to <1 secondtestBalanceOfSloppyServers67 seconds to <1 secondI ran
testNeedBalance100 times locally, and the other two tests I ran 1000 times locally.So total class
TestStochasticLoadBalancerruntime reduces from 230 seconds to 31 seconds.Additionally, we get more deterministic behavior, since tests are more likely to have consistent results with a max number of steps when compared to a max running time.