Uh oh!
There was an error while loading. Please reload this page.
HBASE-27033 Backport "HBASE-27013 Introduce read all bytes when using… - #4429
Merged
Conversation
… pread for prefetch" - introduce optional flag `hfile.pread.all.bytes.enabled` for pread that must read full bytes with the next block header
taklwu
commented
May 13, 2022
ContributorAuthor
please see the original commit from branch-2 43e8c11 |
ankitsinghal
approved these changes
May 13, 2022
Apache-HBase
commented
May 13, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 14, 2022
🎊 +1 overall
This message was automatically generated. |
joshelser
approved these changes
May 16, 2022
joshelser
left a comment
Member
There was a problem hiding this comment.
Backport lgtm (should not have a change in functionality to the 2.4 line). Looks like you also already have jira marked for 2.4.13 rather than the in-flight 2.4.12)
Comment on lines
+1455
to
+1457
| if ( | ||
| !BlockIOUtils.preadWithExtra(dest, istream, fileOffset, size, extraSize, isPreadAllBytes) | ||
| ) { |
Member
There was a problem hiding this comment.
Suggested change
| if ( | |
| !BlockIOUtils.preadWithExtra(dest, istream, fileOffset, size, extraSize, isPreadAllBytes) | |
| ) { | |
| if (!BlockIOUtils.preadWithExtra( | |
| dest, istream, fileOffset, size, extraSize, isPreadAllBytes)) { |
Typically, we break long lines with method invocations around the arguments, rather than break up the if condition itself.
However, if checkstyle is happy with this how it is, then it's fine :)
ContributorAuthor
There was a problem hiding this comment.
that was modified by spotless:apply, and yet the checkstyle was happy about it
vinayakphegde pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
… pread for prefetch" (apache#4429) - introduce optional flag `hfile.pread.all.bytes.enabled` for pread that must read full bytes with the next block header Signed-off-by: Ankit Singhal <ankit@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit 5b31975) Change-Id: I6caba0ad25e8feb38f6b7d45ea957e5890ab8154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… pread for prefetch"
hfile.pread.all.bytes.enabledfor pread that must read full bytes with the next block header