Uh oh!
There was an error while loading. Please reload this page.
HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… - #4464
Conversation
huaxiangsun
commented
May 26, 2022
Hi @Apache9, please help to review the synchronous version of listAllRegions() change, thanks. |
Apache-HBase
commented
May 26, 2022
💔 -1 overall
This message was automatically generated. |
9db9f24 to
1ad53f1CompareApache-HBase
commented
May 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 26, 2022
💔 -1 overall
This message was automatically generated. |
Apache9
commented
May 26, 2022
Please run 'mvn spotless:apply' to fix the spotless errors? |
Apache-HBase
commented
May 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 26, 2022
💔 -1 overall
This message was automatically generated. |
huaxiangsun
commented
May 26, 2022
Will do and update accordingly, thanks! |
1ad53f1 to
7787ad2CompareApache-HBase
commented
May 26, 2022
💔 -1 overall
This message was automatically generated. |
…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>
7787ad2 to
1ceb7e7CompareApache-HBase
commented
May 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 26, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2022
💔 -1 overall
This message was automatically generated. |
huaxiangsun
commented
May 31, 2022
Run the failed test case TestAsyncTableScanner#testReverseScanNoStopKey locally, it passed. Look a bit closer to the error, Cannot map the tracestack to my git branch. It is something related with tracing, @ndimiduk, can you help o how to parse this assert? I cannot find assertTraceContinuity() in TestAsyncTableScanner class, thanks. |
Apache-HBase
commented
May 31, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 1, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 1, 2022
💔 -1 overall
This message was automatically generated. |
huaxiangsun
commented
Jun 2, 2022
I tried to get a clean unittest run. This time, it failed at TestSplitRegionWhileRSCrash. The logs show the test case timed out. Did a manual run locally and it passed. @Apache9 Can you help to review? Thanks. |
Apache9
left a comment
There was a problem hiding this comment.
So the difference compard to the PR for master is that we also need to change the sync client?
+1
huaxiangsun
commented
Jun 2, 2022
Thanks, yeah, the async part is same. The sync part is the new development. |
…etAllRegionLocations() (#4442)
Signed-off-by: Duo Zhang zhangduo@apache.org