Skip to content

HBASE-27092 Regionserver table on Master UI is broken - #4495

Merged
virajjasani merged 1 commit into
apache:masterfrom
tomscut:HBASE-27092
Jun 8, 2022
Merged

HBASE-27092 Regionserver table on Master UI is broken#4495
virajjasani merged 1 commit into
apache:masterfrom
tomscut:HBASE-27092

Conversation

@tomscut

Copy link
Copy Markdown
Contributor

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall6m 37smaster passed
+1 💚spotless0m 49sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 21sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 49spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
14m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4495/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4495
Optional Testsdupname asflicense javac spotless
unameLinux 5686f31ad593 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a060e71
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count71 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4495/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 4smaster passed
+1 💚javadoc0m 26smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 42sthe patch passed
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
-1 ❌unit206m 20shbase-server in the patch failed.
215m 38s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4495/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4495
Optional Testsjavac javadoc unit
unameLinux 118c791ec109 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a060e71
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4495/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4495/1/testReport/
Max. process+thread count2619 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4495/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani

Copy link
Copy Markdown
Contributor

@tomscut the change looks good. For Normal regionservers, is it good to display Live instead? Just like datanodes state, it would be live and decommissioned. WDYT?

@tomscut

Copy link
Copy Markdown
ContributorAuthor

@tomscut the change looks good. For Normal regionservers, is it good to display Live instead? Just like datanodes state, it would be live and decommissioned. WDYT?

I planned to set the status to Live, but found that the Live RegionServers in hbase included the Decommissioned RegionServers. If it is set to Live, there is ambiguity.

@virajjasani
virajjasani merged commit 9342653 into apache:masterJun 8, 2022
virajjasani pushed a commit that referenced this pull request Jun 8, 2022
Signed-off-by: Viraj Jasani <vjasani@apache.org>
wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
Signed-off-by: Viraj Jasani <vjasani@apache.org>
wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tomscut@Apache-HBase@virajjasani