Skip to content

Backport "HBASE-27153 Improvements to read-path tracing" to branch-2 - #4573

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27153-trace-read-path-branch-2
Aug 2, 2022
Merged

Backport "HBASE-27153 Improvements to read-path tracing" to branch-2#4573
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:27153-trace-read-path-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented Jun 23, 2022

Copy link
Copy Markdown
Member

This is a backport of #4572 .

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jun 23, 2022
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
apurtell
apurtell approved these changes Jun 23, 2022
View reviewed changes

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying my approval over from #4572 but see my comment there.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 27153-trace-read-path-branch-2 branch from 6e2e17d to 2451291CompareJune 28, 2022 12:20
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 27153-trace-read-path-branch-2 branch from 2451291 to 45b87ddCompareJuly 7, 2022 14:40
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
HBASE-27153 Improvements to read-path tracing
10ca11a
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimiduk
ndimidukforce-pushed the 27153-trace-read-path-branch-2 branch from 45b87dd to 10ca11aCompareAugust 1, 2022 12:03
@Apache-HBase

Apache-HBase commented Aug 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall2m 13sbranch-2 passed
+1 💚compile3m 31sbranch-2 passed
+1 💚checkstyle1m 1sbranch-2 passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 27sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile4m 21sthe patch passed
+1 💚javac4m 21sthe patch passed
+1 💚checkstyle1m 27sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotless1m 30spatch has no errors when running spotless:check.
+1 💚spotbugs3m 47sthe patch passed
_ Other Tests _
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
43m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4573
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux b725af2ff94c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / dbad3d1
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count60 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 32sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 56sMaven dependency ordering for branch
+1 💚mvninstall2m 50sbranch-2 passed
+1 💚compile1m 21sbranch-2 passed
+1 💚shadedjars4m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 24sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
+1 💚shadedjars4m 16spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
+1 💚unit1m 45shbase-common in the patch passed.
+1 💚unit2m 41shbase-client in the patch passed.
+1 💚unit184m 0shbase-server in the patch passed.
212m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4573
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3fc61057e131 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / dbad3d1
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/testReport/
Max. process+thread count2461 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 40sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 51sbranch-2 passed
+1 💚compile1m 27sbranch-2 passed
+1 💚shadedjars3m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 3sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall2m 41sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12sthe patch passed
_ Other Tests _
+1 💚unit1m 52shbase-common in the patch passed.
+1 💚unit3m 19shbase-client in the patch passed.
+1 💚unit241m 29shbase-server in the patch passed.
272m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4573
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 73260676458d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / dbad3d1
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/testReport/
Max. process+thread count2333 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4573/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit bcec871 into apache:branch-2Aug 2, 2022
@ndimiduk
ndimiduk deleted the 27153-trace-read-path-branch-2 branch August 2, 2022 12:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@apurtell