Skip to content

Backport "HBASE-27153 Improvements to read-path tracing" to branch-2.5 - #4574

Merged
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:27153-trace-read-path-branch-2.5
Aug 2, 2022
Merged

Backport "HBASE-27153 Improvements to read-path tracing" to branch-2.5#4574
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:27153-trace-read-path-branch-2.5

Conversation

@ndimiduk

@ndimidukndimiduk commented Jun 23, 2022

Copy link
Copy Markdown
Member

This is a backport of #4572 .

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jun 23, 2022
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
apurtell
apurtell approved these changes Jun 23, 2022
View reviewed changes

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying my approval over from #4572 but see my comment there.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 27153-trace-read-path-branch-2.5 branch from e35cdc9 to 23a3878CompareJune 28, 2022 12:20
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 27153-trace-read-path-branch-2.5 branch from 23a3878 to 9258380CompareJuly 7, 2022 14:42
@ndimidukndimiduk mentioned this pull request Jul 7, 2022
Closed
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@apurtell

apurtell commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

There are some flaky replication tests in the precommit results that are not related here.

@ndimiduk
HBASE-27153 Improvements to read-path tracing
f2b5f32
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimiduk
ndimidukforce-pushed the 27153-trace-read-path-branch-2.5 branch from 9258380 to f2b5f32CompareAugust 1, 2022 12:04
@Apache-HBase

Apache-HBase commented Aug 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 15sbranch-2.5 passed
+1 💚compile3m 28sbranch-2.5 passed
+1 💚checkstyle1m 3sbranch-2.5 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 30sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 2sthe patch passed
+1 💚compile3m 29sthe patch passed
+1 💚javac3m 29sthe patch passed
+1 💚checkstyle1m 2sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 12sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs2m 49sthe patch passed
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
38m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4574
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 0bc6adb0577b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7aa46f0
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count65 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 20sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for branch
+1 💚mvninstall2m 44sbranch-2.5 passed
+1 💚compile1m 28sbranch-2.5 passed
+1 💚shadedjars3m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 3sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 30sthe patch passed
+1 💚compile1m 25sthe patch passed
+1 💚javac1m 25sthe patch passed
+1 💚shadedjars3m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 2sthe patch passed
_ Other Tests _
+1 💚unit2m 1shbase-common in the patch passed.
+1 💚unit2m 55shbase-client in the patch passed.
+1 💚unit187m 4shbase-server in the patch passed.
213m 54s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4574
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 12c6142e3a78 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7aa46f0
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/testReport/
Max. process+thread count2368 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 33sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall2m 52sbranch-2.5 passed
+1 💚compile1m 24sbranch-2.5 passed
+1 💚shadedjars4m 18sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sbranch-2.5 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile1m 22sthe patch passed
+1 💚javac1m 22sthe patch passed
+1 💚shadedjars3m 57spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sthe patch passed
_ Other Tests _
+1 💚unit1m 29shbase-common in the patch passed.
+1 💚unit2m 51shbase-client in the patch passed.
+1 💚unit193m 23shbase-server in the patch passed.
222m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4574
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a69130d95ace 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7aa46f0
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/testReport/
Max. process+thread count2120 (vs. ulimit of 12500)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 472e810 into apache:branch-2.5Aug 2, 2022
@ndimiduk
ndimiduk deleted the 27153-trace-read-path-branch-2.5 branch August 2, 2022 12:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@apurtell