Uh oh!
There was an error while loading. Please reload this page.
HBASE-27201 Clean up error-prone findings in hbase-backup - #4622
Closed
apurtell wants to merge 2 commits into
Closed
HBASE-27201 Clean up error-prone findings in hbase-backup#4622apurtell wants to merge 2 commits into
apurtell wants to merge 2 commits into
Conversation
Apache-HBase
commented
Jul 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jul 16, 2022
| return null; | ||
| } | ||
| return new String(val).split(","); | ||
| return new String(val, StandardCharsets.UTF_8).split(","); |
Contributor
There was a problem hiding this comment.
I think this will introduce another error prone warning? Use guava's Splitter.on
| return null; | ||
| } | ||
| return new String(val).split(","); | ||
| return new String(val, StandardCharsets.UTF_8).split(","); |
ContributorAuthor
There was a problem hiding this comment.
It does not produce a warning, because stringsplitter warnings are suppressed.
| return scan; | ||
| } | ||
| @SuppressWarnings("StringSplitter") |
Contributor
There was a problem hiding this comment.
Since we have shaded guava, I think it is OK for use to make use of guava's Splitter.
ContributorAuthor
There was a problem hiding this comment.
There's nothing wrong with string.split in these applications and when I used Splitter it caused more trouble than it was worth.
| return parts[1]; | ||
| } | ||
| @SuppressWarnings("StringSplitter") |
| return logFiles; | ||
| } | ||
| @SuppressWarnings("StringSplitter") |
| return ts1 < ts2 ? 1 : -1; | ||
| } | ||
| @SuppressWarnings("StringSplitter") |
| return BulkLoadHFiles.create(conf); | ||
| } | ||
| @SuppressWarnings("StringSplitter") |
ContributorAuthor
@Apache9 It is fine to handle the string split warnings some other way, but I thought I would take this approach. I had a bit of trouble actually using Splitter. I'm sure I could figure it out but there are other things that seem more important. string#split works in these cases and is good enough IMHO. Is this ok? Or, we could just leave these in place and also not add the |
ContributorAuthor
Lets apply the new spotless rule for the automated fix for many of the javadoc issues, and then come back to this PR. |
apurtell
marked this pull request as draft
July 18, 2022 22:54
Apache9
commented
Jul 19, 2022
Contributor
Usually there is no harm to use String.split, as long as it has been like this for a long time in our code base, so I'm OK with leaving it as is or adding a SuppressWarnings. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.