Uh oh!
There was an error while loading. Please reload this page.
HBASE-27203 Clean up error-prone findings in hbase-client - #4626
Closed
apurtell wants to merge 1 commit into
Closed
Conversation
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 14, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 15, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jul 15, 2022
Apache9
left a comment
Contributor
There was a problem hiding this comment.
Just skimmed a small piece of code.
For the returns only warning, let me think whether we could implement spotless rule to convert it automatically, so we do not need to mix this stytle change with other more critical fixes.
| private final long evictedBlocks; | ||
| private final long maxCacheSize; | ||
| private final Map<byte[], Throwable> exceptions; | ||
| private final IdentityHashMap<byte[], Throwable> exceptions; |
Contributor
There was a problem hiding this comment.
I think this will be a bit dangerous if we will return this map to upper layer...
ContributorAuthor
There was a problem hiding this comment.
The warning here is the one that suggests maps and identity keys should not be mixed... that if the keys use object identity, the map type should be IdentityHashMap. It seems minor, but correct.
| storeFileSizeMB += r.getStoreFileSize().get(Size.Unit.MEGABYTE); | ||
| memStoreSizeMB += r.getMemStoreSize().get(Size.Unit.MEGABYTE); | ||
| storefileIndexSizeKB += r.getStoreFileUncompressedDataIndexSize().get(Size.Unit.KILOBYTE); | ||
| uncompressedStoreFileSizeMB = (long) (uncompressedStoreFileSizeMB |
Contributor
There was a problem hiding this comment.
Just use += and cast the right operator to long is enough?
apurtell
commented
Jul 18, 2022
ContributorAuthor
@Apache9 Agreed, let's apply the new spotless rule for the automated fix, and then come back to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.