Skip to content

HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2.4 (addendum) - #4631

Merged
bbeaudreault merged 1 commit into
apache:branch-2.4from
HubSpot:HBASE-27205-addendum
Jul 18, 2022
Merged

HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2.4 (addendum)#4631
bbeaudreault merged 1 commit into
apache:branch-2.4from
HubSpot:HBASE-27205-addendum

Conversation

@bbeaudreault

@bbeaudreaultbbeaudreault commented Jul 16, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

I wasn't sure if an addendum was the way to go here, so let me know if a new jira would be better

@Apache-HBase

Apache-HBase commented Jul 16, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 53sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+1 💚mvninstall2m 15sbranch-2.4 passed
+1 💚compile2m 10sbranch-2.4 passed
+1 💚checkstyle0m 29sbranch-2.4 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 13sbranch-2.4 passed
_ Patch Compile Tests _
+1 💚mvninstall1m 51sthe patch passed
+1 💚compile2m 9sthe patch passed
+1 💚javac2m 9sthe patch passed
+1 💚checkstyle0m 28sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 52sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚spotless0m 38spatch has no errors when running spotless:check.
+1 💚spotbugs1m 18sthe patch passed
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
30m 16s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4631
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux dd28b878f858 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / cc62da2
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count68 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 17, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+1 💚mvninstall2m 28sbranch-2.4 passed
+1 💚compile0m 37sbranch-2.4 passed
+1 💚shadedjars4m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sbranch-2.4 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 14sthe patch passed
+1 💚compile0m 36sthe patch passed
+1 💚javac0m 36sthe patch passed
+1 💚shadedjars4m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
+1 💚unit160m 36shbase-server in the patch passed.
178m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4631
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 083c35522774 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / cc62da2
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/testReport/
Max. process+thread count2858 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 17, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 57sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+1 💚mvninstall2m 11sbranch-2.4 passed
+1 💚compile0m 31sbranch-2.4 passed
+1 💚shadedjars4m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sbranch-2.4 passed
_ Patch Compile Tests _
+1 💚mvninstall1m 53sthe patch passed
+1 💚compile0m 32sthe patch passed
+1 💚javac0m 32sthe patch passed
+1 💚shadedjars4m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 20sthe patch passed
_ Other Tests _
+1 💚unit164m 44shbase-server in the patch passed.
181m 33s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4631
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a64539e818ca 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / cc62da2
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/testReport/
Max. process+thread count2534 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell

apurtell commented Jul 17, 2022

Copy link
Copy Markdown
Contributor

lgtm thanks for jumping on this @bbeaudreault

@bbeaudreault

bbeaudreault commented Jul 17, 2022

Copy link
Copy Markdown
ContributorAuthor

@virajjasani no rush, but any chance you can test this patch out in your environment's tests to ensure that it solves the issue. If possible would like to avoid having to push a bunch more addendums. As mentioned, I ran them a bunch myself but would be good to know it solves your issue specifically.

@virajjasani

virajjasani commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Sounds good, on it.

@virajjasani

virajjasani commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

We are all good here, thanks a lot @bbeaudreault!

@bbeaudreault

bbeaudreault commented Jul 18, 2022

Copy link
Copy Markdown
ContributorAuthor

Great, thanks for checking!

@bbeaudreault
bbeaudreault merged commit f5f248d into apache:branch-2.4Jul 18, 2022
@bbeaudreault
bbeaudreault deleted the HBASE-27205-addendum branch July 18, 2022 18:54
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@bbeaudreault
HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2…
ba70a32
….4 (addendum) (apache#4631)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit f5f248d)
Change-Id: I061fe714855e6f4963b1743c53ced9f4dd9f44b6
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bbeaudreault@Apache-HBase@apurtell@virajjasani