Skip to content

HBASE-22809 Allow creating table in group when rs group contains no l… - #464

Merged
Apache9 merged 1 commit into
apache:HBASE-22514from
Apache9:HBASE-22809
Aug 9, 2019
Merged

HBASE-22809 Allow creating table in group when rs group contains no l…#464
Apache9 merged 1 commit into
apache:HBASE-22514from
Apache9:HBASE-22809

Conversation

@Apache9

@Apache9Apache9 commented Aug 7, 2019

Copy link
Copy Markdown
Contributor

…ive servers

@Apache-HBase

Apache-HBase commented Aug 7, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec205Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-22514 Compile Tests _
+1mvninstall353HBASE-22514 passed
+1compile57HBASE-22514 passed
+1checkstyle90HBASE-22514 passed
+1shadedjars301branch has no errors when building our shaded downstream artifacts.
+1javadoc41HBASE-22514 passed
0spotbugs298Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs296HBASE-22514 passed
_ Patch Compile Tests _
+1mvninstall329the patch passed
+1compile64the patch passed
+1javac64the patch passed
+1checkstyle88the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars318patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1037Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc35the patch passed
+1findbugs304the patch passed
_ Other Tests _
-1unit13143hbase-server in the patch failed.
+1asflicense27The patch does not generate ASF License warnings.
17101
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/artifact/out/Dockerfile
GITHUB PR#464
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5ff6f81b8859 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-464/out/precommit/personality/provided.sh
git revisionHBASE-22514 / 77e95bd
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/testReport/
Max. process+thread count4436 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 requested a review from infraioAugust 8, 2019 01:31
infraio
infraio reviewed Aug 8, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java Outdated
infraio
infraio reviewed Aug 8, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
"No servers in the rsgroup " + group.getName() + " for namespace " + ns.getName());
}
}

@infraioinfraioAug 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these method can be refacotred to 3 methods:

  1. getRSGroupForTable()
  2. getRSGroupForNamespace()
  3. checkRSGroup() : it will check RSGroup exists and not empty.

@Apache9Apache9Aug 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here is not that straight-forward. If we are modifying table, we do not need to check the group if the group config is not changed or we just removed the group config. So does namespace...

@Apache-HBase

Apache-HBase commented Aug 8, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec62Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-22514 Compile Tests _
+1mvninstall376HBASE-22514 passed
+1compile61HBASE-22514 passed
+1checkstyle74HBASE-22514 passed
+1shadedjars266branch has no errors when building our shaded downstream artifacts.
+1javadoc36HBASE-22514 passed
0spotbugs259Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs256HBASE-22514 passed
_ Patch Compile Tests _
+1mvninstall300the patch passed
+1compile55the patch passed
+1javac55the patch passed
+1checkstyle75the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars266patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1002Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc35the patch passed
+1findbugs259the patch passed
_ Other Tests _
-1unit16114hbase-server in the patch failed.
+1asflicense42The patch does not generate ASF License warnings.
19647
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncTableAdminApi2
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/artifact/out/Dockerfile
GITHUB PR#464
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux fd04d12ec33f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-464/out/precommit/personality/provided.sh
git revisionHBASE-22514 / e4b1720
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/testReport/
Max. process+thread count4596 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 8, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec163Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ HBASE-22514 Compile Tests _
+1mvninstall552HBASE-22514 passed
+1compile80HBASE-22514 passed
+1checkstyle105HBASE-22514 passed
+1shadedjars385branch has no errors when building our shaded downstream artifacts.
+1javadoc51HBASE-22514 passed
0spotbugs350Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs347HBASE-22514 passed
_ Patch Compile Tests _
+1mvninstall413the patch passed
+1compile67the patch passed
+1javac67the patch passed
+1checkstyle101the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars366patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1398Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc49the patch passed
+1findbugs332the patch passed
_ Other Tests _
-1unit15601hbase-server in the patch failed.
+1asflicense28The patch does not generate ASF License warnings.
20583
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/artifact/out/Dockerfile
GITHUB PR#464
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f3107b79f42f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-464/out/precommit/personality/provided.sh
git revisionHBASE-22514 / e4b1720
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/testReport/
Max. process+thread count4384 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 595aa9d into apache:HBASE-22514Aug 9, 2019
asfgit pushed a commit that referenced this pull request Aug 15, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
07fe41d
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 16, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
25566ae
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 18, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
1ae9298
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 22, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
ce67fec
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 24, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
d78c328
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 25, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
541c768
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Aug 27, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
5762c18
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 1, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
ea7ce7a
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 2, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
9cd801a
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 2, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
83e6882
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 4, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
dfa95fc
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 7, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
35f041d
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 9, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
cb58bfb
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 10, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
928ecfb
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 10, 2019
@Apache9
Revert "HBASE-22809Allow creating table in group when rs group conta…
1c150e0
…ins no live servers (#464)"
This reverts commit 928ecfb.
asfgit pushed a commit that referenced this pull request Sep 10, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
fc57d38
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 11, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
3a5a8cf
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 11, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
475a1bf
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 16, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
e3b402f
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 17, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
ec55c1f
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 18, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
fd42412
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 20, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
6aa8da7
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Sep 24, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
51f13fe
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Oct 5, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
b1dd9a8
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Oct 28, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
9f4e594
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Nov 5, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
225ee08
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Nov 10, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
83fa1e4
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Nov 13, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
9d6cc4f
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Dec 24, 2019
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
4784905
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 2, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
7960d37
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 3, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
13af8b0
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 4, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
8223c4c
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 6, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
12cb421
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 7, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
5df8085
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 8, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
cd98bae
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 9, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
461b826
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 12, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
d415217
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 20, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
d93bf76
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 22, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
eaa05f8
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 25, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
9b5818f
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 26, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
e47e85a
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit pushed a commit that referenced this pull request Feb 29, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
5d50788
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Apache9 added a commit that referenced this pull request Mar 2, 2020
@Apache9
HBASE-22809Allow creating table in group when rs group contains no l…
44ddb30
…ive servers (#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@Apache9@thangTang
HBASE-22809 Allow creating table in group when rs group contains no l…
b584955
…ive servers (apache#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@Apache9@thangTang
HBASE-22809 Allow creating table in group when rs group contains no l…
c95f83a
…ive servers (apache#464)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infraioinfraioinfraio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@infraio