Uh oh!
There was an error while loading. Please reload this page.
HBASE-27206 Clean up error-prone findings in hbase-common - #4645
Merged
Conversation
Apache-HBase
commented
Jul 23, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 23, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jul 23, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| private int qualifierOffset; | ||
| private int qualifierLength; | ||
| private long timestamp; | ||
| private long timeStamp; |
Contributor
There was a problem hiding this comment.
I think timestamp is a valid word in English?
ContributorAuthor
There was a problem hiding this comment.
This was an instance of the error-prone warning about inconsistent caps with respect to the field name and getter/setter or constructor parameter name. https://github.com/google/error-prone/blob/master/docs/bugpattern/InconsistentCapitalization.md
Contributor
There was a problem hiding this comment.
Searched our code base, there are bunch of mixed TimeStamp and Timestamp usages... We even have code like this:
.setTimestampsOfLastAppliedOp(rls.getTimeStampsOfLastAppliedOp())
And in the same protobuf message, we have mixed style of timestamps...
message ReplicationLoadSink {
required uint64 ageOfLastAppliedOp = 1;
required uint64 timeStampsOfLastAppliedOp = 2;
// The below two were added after hbase-2.0.0 went out. They have to be added as 'optional' else
// we break upgrades; old RegionServers reporting in w/ old forms of this message will fail to
// deserialize on the new Master. See HBASE-25234
optional uint64 timestampStarted = 3;
optional uint64 totalOpsProcessed = 4;
}
So I tend to leave it as it for now. Maybe we should start a discussion thread on the dev list on how to better fix these problems...
Contributor
There was a problem hiding this comment.
If we do not change the public method declaration I think it is fine. Can discuss this later.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
apurtell
commented
Jul 26, 2022
ContributorAuthor
Rebase. Address review feedback. |
Apache-HBase
commented
Jul 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 26, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 26, 2022
💔 -1 overall
This message was automatically generated. |
ContributorAuthor
hbase-server results here are probably not related, but it is a bit hard to say. There are two tracing related flakes. /cc @ndimiduk There was a timed out test, but I don't know which one, but I did disable a known hang just today so another run might be cleaner. |
apurtell
commented
Jul 27, 2022
ContributorAuthor
Let me rebase and push to trigger another run. |
Apache-HBase
commented
Jul 27, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 28, 2022
🎊 +1 overall
This message was automatically generated. |
ndimiduk
commented
Aug 1, 2022
Member
Thanks for pointing these out, I see the logs. |
Apache-HBase
commented
Aug 6, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 6, 2022
💔 -1 overall
This message was automatically generated. |
| } | ||
| /** | ||
| * Sets the given timestamp to the cell. n * @param ts buffer containing the timestamp value |
Member
There was a problem hiding this comment.
I think that these comment lines starting with n are left-overs from the auto-formatting tool getting confused by newline characters.
ndimiduk
approved these changes
Aug 12, 2022
| } | ||
| @Override | ||
| @SuppressWarnings("ByteBufferBackingArray") |
Member
There was a problem hiding this comment.
I agree with ErrorProne that this use of a ByteBuffer is problematic. We're leaving it to the caller to perform bounds checking but they don't have the underlying keyBuffer.
Keep the warnings so that we don't lose track of this issue?
| * The values in the enum appear in the order they appear in a version 2 HFile. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| @SuppressWarnings("ImmutableEnumChecker") |
Member
There was a problem hiding this comment.
Does the warning specify the point of mutability? A quick scan here and I don't see any state mutations.
Contributor
There was a problem hiding this comment.
I guess it is because the 'magic' field. It is a byte array, the content can be changed at runtime.
| */ | ||
| @InterfaceAudience.Private | ||
| @InterfaceStability.Stable | ||
| @SuppressWarnings({ "unchecked", "rawtypes", "hiding", "TypeParameterShadowing" }) |
| @edu.umd.cs.findbugs.annotations.SuppressWarnings( | ||
| value = "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS", | ||
| justification = "It has been like this forever") | ||
| @SuppressWarnings("MixedMutabilityReturnType") |
Member
There was a problem hiding this comment.
This method returns both mutable and immutable collections or maps from different paths. This may be confusing for users of the method.
Yeah, that's a fair description.
| // using linux bash commands to retrieve info | ||
| Process p = Runtime.getRuntime() | ||
| .exec(new String[] { "bash", "-c", "ls /proc/" + pidhost[0] + "/fdinfo | wc -l" }); | ||
| .exec(new String[] { "bash", "-c", "ls /proc/" + pidhost.next() + "/fdinfo | wc -l" }); |
Member
There was a problem hiding this comment.
Should we be looking under /proc/self instead of parsing the pid?
Contributor
There was a problem hiding this comment.
This could be done as a separated issue, not an error prone related problem.
ndimiduk
commented
Aug 12, 2022
Member
Thanks for putting time into this cleanup, @apurtell . |
Apache9
approved these changes
Aug 21, 2022
| private int qualifierOffset; | ||
| private int qualifierLength; | ||
| private long timestamp; | ||
| private long timeStamp; |
Contributor
There was a problem hiding this comment.
If we do not change the public method declaration I think it is fine. Can discuss this later.
| * The values in the enum appear in the order they appear in a version 2 HFile. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| @SuppressWarnings("ImmutableEnumChecker") |
Contributor
There was a problem hiding this comment.
I guess it is because the 'magic' field. It is a byte array, the content can be changed at runtime.
| // using linux bash commands to retrieve info | ||
| Process p = Runtime.getRuntime() | ||
| .exec(new String[] { "bash", "-c", "ls /proc/" + pidhost[0] + "/fdinfo | wc -l" }); | ||
| .exec(new String[] { "bash", "-c", "ls /proc/" + pidhost.next() + "/fdinfo | wc -l" }); |
Contributor
There was a problem hiding this comment.
This could be done as a separated issue, not an error prone related problem.
| try { | ||
| for (Cell k : set) { | ||
| assertTrue("count=" + count + ", " + k.toString(), count++ == k.getTimestamp()); | ||
| for (Cell k : set) { |
Contributor
There was a problem hiding this comment.
Could try to use assertThrows in the future. Not a blocker.
| expectedAssert(() -> testReadAndWrite(array, 0, 0, (byte) 15)); | ||
| expectedAssert(() -> testReadAndWrite(array, 4096, cap - 4096 + 1, (byte) 16)); | ||
| // XXX: These cases were apparently expected to assert but expectedAssert() was |
Apache9 pushed a commit
that referenced
this pull request
Aug 21, 2022
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit fbe3b90) Conflicts: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestKeyStoreKeyProvider.java hbase-common/src/test/java/org/apache/hadoop/hbase/types/TestOrderedFloat32.java
Apache9 pushed a commit
that referenced
this pull request
Aug 21, 2022
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit fbe3b90) Conflicts: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestKeyStoreKeyProvider.java hbase-common/src/test/java/org/apache/hadoop/hbase/types/TestOrderedFloat32.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.