Skip to content

[HBASE-27245]Expose the archive API to the end user - #4656

Closed
alexdongli0829 wants to merge 6 commits into
apache:masterfrom
alexdongli0829:HBASE-27245
Closed

[HBASE-27245]Expose the archive API to the end user#4656
alexdongli0829 wants to merge 6 commits into
apache:masterfrom
alexdongli0829:HBASE-27245

Conversation

@alexdongli0829

@alexdongli0829alexdongli0829 commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

@alexdongli0829
alexdongli0829 marked this pull request as ready for review July 27, 2022 06:09
@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 31smaster passed
+1 💚compile5m 47smaster passed
+1 💚checkstyle1m 33smaster passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
+1 💚spotbugs7m 52smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile5m 35sthe patch passed
+1 💚cc5m 35sthe patch passed
-0 ⚠️javac0m 40shbase-client generated 1 new + 31 unchanged - 0 fixed = 32 total (was 31)
-0 ⚠️checkstyle0m 25shbase-client: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)
-0 ⚠️checkstyle0m 46shbase-server: The patch generated 15 new + 20 unchanged - 0 fixed = 35 total (was 20)
-0 ⚠️rubocop0m 14sThe patch generated 5 new + 407 unchanged - 0 fixed = 412 total (was 407)
-0 ⚠️whitespace0m 0sThe patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck18m 27sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc2m 26sthe patch passed
-1 ❌spotless0m 19spatch has 67 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs9m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 57sThe patch does not generate ASF License warnings.
71m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4656
JIRA IssueHBASE-27245
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 06b6aaaf9e00 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 80b3668
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count69 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-testing-util hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

dongaws
Fix the spotless check failure and add override for modifyTableStoreF…
c1cab30
…ileTracker in AsyncHBaseAdmin which was warning
@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 5smaster passed
+1 💚compile3m 4smaster passed
+1 💚shadedjars4m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile3m 20sthe patch passed
+1 💚javac3m 20sthe patch passed
+1 💚shadedjars4m 56spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 57sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
+1 💚unit1m 38shbase-client in the patch passed.
-1 ❌unit202m 1shbase-server in the patch failed.
+1 💚unit1m 58shbase-testing-util in the patch passed.
+1 💚unit6m 33shbase-thrift in the patch passed.
+1 💚unit7m 37shbase-shell in the patch passed.
252m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4656
JIRA IssueHBASE-27245
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d0a42687fa3f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 80b3668
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/testReport/
Max. process+thread count2645 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-testing-util hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for branch
+1 💚mvninstall2m 21smaster passed
+1 💚compile2m 18smaster passed
+1 💚shadedjars3m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 13sthe patch passed
+1 💚compile2m 19sthe patch passed
+1 💚javac2m 19sthe patch passed
+1 💚shadedjars3m 44spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 29shbase-protocol-shaded in the patch passed.
+1 💚unit1m 2shbase-client in the patch passed.
-1 ❌unit222m 1shbase-server in the patch failed.
+1 💚unit2m 9shbase-testing-util in the patch passed.
+1 💚unit7m 4shbase-thrift in the patch passed.
+1 💚unit7m 44shbase-shell in the patch passed.
264m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4656
JIRA IssueHBASE-27245
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c8f9fd302d4d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 80b3668
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/testReport/
Max. process+thread count2570 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-testing-util hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 10smaster passed
+1 💚compile5m 52smaster passed
+1 💚checkstyle1m 32smaster passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
+1 💚spotbugs7m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile5m 36sthe patch passed
+1 💚cc5m 36sthe patch passed
+1 💚javac5m 36sthe patch passed
+1 💚checkstyle2m 3sthe patch passed
-0 ⚠️rubocop0m 6sThe patch generated 5 new + 407 unchanged - 0 fixed = 412 total (was 407)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck18m 4sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc2m 36sthe patch passed
+1 💚spotless0m 46spatch has no errors when running spotless:check.
+1 💚spotbugs9m 26sthe patch passed
_ Other Tests _
+1 💚asflicense1m 2sThe patch does not generate ASF License warnings.
71m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4656
JIRA IssueHBASE-27245
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux a1cf31de43ef 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 80b3668
Default JavaAdoptOpenJDK-1.8.0_282-b08
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-testing-util hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@comnetwork
HBASE-27247 TestPerTableCFReplication.testParseTableCFsFromConfig is …
a3eeab8
…broken because of ReplicationPeerConfigUtil.parseTableCFsFromConfig (apache#4658)
Co-authored-by: comnetwork <comnetwork@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 41smaster passed
+1 💚compile3m 4smaster passed
+1 💚shadedjars4m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile3m 14sthe patch passed
+1 💚javac3m 14sthe patch passed
+1 💚shadedjars5m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 55sthe patch passed
_ Other Tests _
+1 💚unit0m 40shbase-protocol-shaded in the patch passed.
+1 💚unit1m 36shbase-client in the patch passed.
-1 ❌unit200m 50shbase-server in the patch failed.
+1 💚unit2m 2shbase-testing-util in the patch passed.
+1 💚unit6m 39shbase-thrift in the patch passed.
+1 💚unit7m 38shbase-shell in the patch passed.
250m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4656
JIRA IssueHBASE-27245
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 223162a0d81c 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 80b3668
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/testReport/
Max. process+thread count2682 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-testing-util hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 17smaster passed
+1 💚compile2m 38smaster passed
+1 💚shadedjars4m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile2m 32sthe patch passed
+1 💚javac2m 32sthe patch passed
+1 💚shadedjars4m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 32shbase-protocol-shaded in the patch passed.
+1 💚unit1m 9shbase-client in the patch passed.
-1 ❌unit243m 28shbase-server in the patch failed.
+1 💚unit2m 10shbase-testing-util in the patch passed.
+1 💚unit7m 2shbase-thrift in the patch passed.
+1 💚unit7m 35shbase-shell in the patch passed.
290m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4656
JIRA IssueHBASE-27245
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e59af8d203a2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 80b3668
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/testReport/
Max. process+thread count2559 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-testing-util hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#4656 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#4656
JIRA IssueHBASE-27245
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/3/console
versionsgit=2.25.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

1 similar comment
@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#4656 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#4656
JIRA IssueHBASE-27245
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/3/console
versionsgit=2.25.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#4656 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#4656
JIRA IssueHBASE-27245
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4656/3/console
versionsgit=2.17.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@alexdongli0829
alexdongli0829 deleted the HBASE-27245 branch July 27, 2022 23:43
@alexdongli0829

alexdongli0829 commented Jul 27, 2022

Copy link
Copy Markdown
ContributorAuthor

Will rebase and submit the PR again

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexdongli0829@Apache-HBase@comnetwork