Skip to content

HBASE-22803 Modify config value range to enable turning off of the hbck chore - #466

Merged
the-sakthi merged 1 commit into
apache:masterfrom
the-sakthi:HBASE-22803
Aug 9, 2019
Merged

HBASE-22803 Modify config value range to enable turning off of the hbck chore#466
the-sakthi merged 1 commit into
apache:masterfrom
the-sakthi:HBASE-22803

Conversation

@the-sakthi

@the-sakthithe-sakthi commented Aug 8, 2019

Copy link
Copy Markdown
Member

No description provided.

infraio
infraio reviewed Aug 8, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java Outdated
private volatile long checkingStartTimestamp = 0;
private volatile long checkingEndTimestamp = 0;

private boolean stopped = false;

@infraioinfraioAug 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stopped ==> disabled?

infraio
infraio reviewed Aug 8, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java Outdated
int interval =
master.getConfiguration().getInt(HBCK_CHORE_INTERVAL, DEFAULT_HBCK_CHORE_INTERVAL);
if (interval <= 0) {
LOG.warn(HBCK_CHORE_INTERVAL + "is <=0 hence disabling hbck chore");

@infraioinfraioAug 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a whitespace before "is".

infraio
infraio reviewed Aug 8, 2019
View reviewed changes

@infraioinfraio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a ut for this?

@Apache-HBase

Apache-HBase commented Aug 8, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec75Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall449master passed
+1compile70master passed
+1checkstyle97master passed
+1shadedjars345branch has no errors when building our shaded downstream artifacts.
+1javadoc44master passed
0spotbugs312Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs309master passed
_ Patch Compile Tests _
+1mvninstall396the patch passed
+1compile67the patch passed
+1javac67the patch passed
+1checkstyle94the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars340patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1193Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc40the patch passed
+1findbugs307the patch passed
_ Other Tests _
-1unit18277hbase-server in the patch failed.
+1asflicense31The patch does not generate ASF License warnings.
22597
ReasonTests
Failed junit testshadoop.hbase.client.TestAsyncTableGetMultiThreaded
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.client.TestFromClientSide
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/artifact/out/Dockerfile
GITHUB PR#466
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux aafcab0cb35c 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revisionmaster / 547cec4
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/testReport/
Max. process+thread count4622 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 8, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec66Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall352master passed
+1compile57master passed
+1checkstyle90master passed
+1shadedjars295branch has no errors when building our shaded downstream artifacts.
+1javadoc37master passed
0spotbugs266Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs264master passed
_ Patch Compile Tests _
+1mvninstall327the patch passed
+1compile57the patch passed
+1javac57the patch passed
+1checkstyle87the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars297patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1020Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc34the patch passed
+1findbugs273the patch passed
_ Other Tests _
+1unit13401hbase-server in the patch passed.
+1asflicense29The patch does not generate ASF License warnings.
17099
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/3/artifact/out/Dockerfile
GITHUB PR#466
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b690cd16ef2b 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revisionmaster / 9250977
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/3/testReport/
Max. process+thread count4892 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 8, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec140Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall363master passed
+1compile57master passed
+1checkstyle83master passed
+1shadedjars313branch has no errors when building our shaded downstream artifacts.
+1javadoc36master passed
0spotbugs262Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs259master passed
_ Patch Compile Tests _
+1mvninstall393the patch passed
+1compile58the patch passed
+1javac58the patch passed
+1checkstyle80the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars321patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1112Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc35the patch passed
+1findbugs289the patch passed
_ Other Tests _
-1unit18344hbase-server in the patch failed.
+1asflicense37The patch does not generate ASF License warnings.
22342
ReasonTests
Failed junit testshadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.namespace.TestNamespaceAuditor
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/artifact/out/Dockerfile
GITHUB PR#466
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 46369aa56fb5 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revisionmaster / 9250977
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/testReport/
Max. process+thread count4936 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@the-sakthi
the-sakthiforce-pushed the HBASE-22803 branch 2 times, most recently from c8eb0fd to 1c383e4CompareAugust 8, 2019 18:02
@the-sakthi

the-sakthi commented Aug 8, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks for your suggestions @infraio , have updated the changes.

@the-sakthithe-sakthi self-assigned this Aug 8, 2019
@Apache-HBase

Apache-HBase commented Aug 8, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec75Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall363master passed
+1compile60master passed
+1checkstyle91master passed
+1shadedjars305branch has no errors when building our shaded downstream artifacts.
+1javadoc40master passed
0spotbugs273Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs270master passed
_ Patch Compile Tests _
+1mvninstall326the patch passed
+1compile56the patch passed
+1javac56the patch passed
+1checkstyle90the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars295patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1022Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc35the patch passed
+1findbugs266the patch passed
_ Other Tests _
-1unit13701hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
17439
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/artifact/out/Dockerfile
GITHUB PR#466
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f7a93e6c26e0 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-466/out/precommit/personality/provided.sh
git revisionmaster / 9250977
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/testReport/
Max. process+thread count4932 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-466/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@the-sakthi

the-sakthi commented Aug 9, 2019

Copy link
Copy Markdown
MemberAuthor

Thanks for the review @infraio

@the-sakthi
the-sakthi merged commit eb92b25 into apache:masterAug 9, 2019
@the-sakthi
the-sakthi deleted the HBASE-22803 branch August 9, 2019 00:33
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803Modify config value range to enable turning off of the hb…
65d6390
…ck chore (#466)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803Modify config value range to enable turning off of the hb…
126eff5
…ck chore (#466)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803Modify config value range to enable turning off of the hb…
2a707ad
…ck chore (#466)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
the-sakthi added a commit that referenced this pull request Aug 9, 2019
@the-sakthi
HBASE-22803Modify config value range to enable turning off of the hb…
66197dd
…ck chore (#466)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@the-sakthiGuanghao Zhang
HBASE-22803 Modify config value range to enable turning off of the hb…
f288af5
…ck chore (apache#466)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@the-sakthiJenkins
HBASE-22803 Modify config value range to enable turning off of the hb…
56b8d46
…ck chore (apache#466)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit 66197dd)
Change-Id: I92c3c2733f7874724fd0f9745fd759bc7e443486
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infraioinfraioinfraio approved these changes

Assignees

@the-sakthithe-sakthi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@the-sakthi@Apache-HBase@infraio