HBASE-27252 Clean up error-prone findings in hbase-it by apurtell · Pull Request #4662 · apache/hbase

apurtell · 2022-07-28T00:48:46Z

No description provided.

Apache-HBase · 2022-07-28T01:12:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 26s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	3m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	shadedjars	3m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 36s	hbase-it in the patch passed.
		16m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bb80ad9d78d4 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a3eeab8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/testReport/
Max. process+thread count	555 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-28T01:17:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 23s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 8s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 42s	hbase-it in the patch passed.
		20m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f03eaf1105e6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a3eeab8`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/testReport/
Max. process+thread count	588 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-28T01:22:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	checkstyle	0m 10s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	hbase-it generated 0 new + 0 unchanged - 103 fixed = 0 total (was 103)
-0 ⚠️	checkstyle	0m 8s	hbase-it: The patch generated 5 new + 34 unchanged - 5 fixed = 39 total (was 39)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 43s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		26m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4662
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 780594bce52a 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a3eeab8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-06T20:05:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 14s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	shadedjars	4m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	shadedjars	4m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 59s	hbase-it in the patch passed.
		20m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a600968cad0b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `486d19e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/testReport/
Max. process+thread count	553 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-06T20:06:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 11s	master passed
+1 💚	compile	0m 28s	master passed
+1 💚	shadedjars	5m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 31s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	hbase-it generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	shadedjars	4m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 51s	hbase-it in the patch passed.
		21m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4662
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7ed4875a21cf 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `486d19e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/testReport/
Max. process+thread count	574 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-06T20:15:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 21s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	checkstyle	0m 12s	master passed
+1 💚	spotless	0m 52s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	hbase-it generated 0 new + 0 unchanged - 103 fixed = 0 total (was 103)
-0 ⚠️	checkstyle	0m 12s	hbase-it: The patch generated 5 new + 34 unchanged - 5 fixed = 39 total (was 39)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 13s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 47s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		30m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4662
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4d2eaaf06b9a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `486d19e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4662/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

No big problems, left a few nits.

+1

Apache9 · 2022-08-08T09:02:05Z

@@ -598,15 +600,11 @@ private void startWalkers(int numWalkers, Configuration conf, Context context) {

 private void joinWalkers() {
 walkersStop = true;


Better move this inside the synchronized lock?

Apache9 · 2022-08-08T09:15:09Z

- configuration.set(HConstants.ZOOKEEPER_QUORUM, parts[0]);
- configuration.set(HConstants.ZOOKEEPER_CLIENT_PORT, parts[1]);
- configuration.set(HConstants.ZOOKEEPER_ZNODE_PARENT, parts[2]);
+Iterable<String> parts = Splitter.on(':').split(key);


Better to split to list and then use get 0, 1, 2? Or create a iterator, call next 3 times. Iterables.get will always start from the first one and iterate...

taklwu · 2022-08-17T23:29:48Z

should we merge this PR ? or do we need to fix those nits?

Apache9 · 2022-08-20T12:49:18Z

Let me close this PR by a commit with the above fixes.

Close#4662 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 1004876) Conflicts: hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java

apurtell requested review from Apache9 and virajjasani July 28, 2022 00:48

virajjasani approved these changes Jul 29, 2022
View reviewed changes

HBASE-27252 Clean up error-prone findings in hbase-it
277c691

apurtell force-pushed the HBASE-27252 branch from 1c257ce to 277c691Compare August 6, 2022 19:33

Apache9 approved these changes Aug 8, 2022
View reviewed changes

Apache9 closed this in 1004876Aug 20, 2022

Navigation Menu

Uh oh!

HBASE-27252 Clean up error-prone findings in hbase-it - #4662

HBASE-27252 Clean up error-prone findings in hbase-it#4662
apurtell wants to merge 1 commit into
apache:masterfrom
apurtell:HBASE-27252

apurtell commented Jul 28, 2022

Uh oh!

Apache-HBase commented Jul 28, 2022

Uh oh!

Apache-HBase commented Jul 28, 2022

Uh oh!

Apache-HBase commented Jul 28, 2022

Uh oh!

Apache-HBase commented Aug 6, 2022

Uh oh!

Apache-HBase commented Aug 6, 2022

Uh oh!

Apache-HBase commented Aug 6, 2022

Uh oh!

Apache9 left a comment

Uh oh!

Apache9Aug 8, 2022

Uh oh!

Apache9Aug 8, 2022

Uh oh!

taklwu commented Aug 17, 2022

Uh oh!

Apache9 commented Aug 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -598,15 +600,11 @@ private void startWalkers(int numWalkers, Configuration conf, Context context) {

		private void joinWalkers() {
		walkersStop = true;

Uh oh!

Conversation

apurtell commented Jul 28, 2022

Uh oh!

Apache-HBase commented Jul 28, 2022

Uh oh!

Apache-HBase commented Jul 28, 2022

Uh oh!

Apache-HBase commented Jul 28, 2022

Uh oh!

Apache-HBase commented Aug 6, 2022

Uh oh!

Apache-HBase commented Aug 6, 2022

Uh oh!

Apache-HBase commented Aug 6, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

Apache9Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

taklwu commented Aug 17, 2022

Uh oh!

Apache9 commented Aug 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants