Skip to content

HBASE-27258 Computed argLine not passed through to surefire configuration - #4668

Closed
apurtell wants to merge 1 commit into
apache:masterfrom
apurtell:HBASE-27258
Closed

HBASE-27258 Computed argLine not passed through to surefire configuration#4668
apurtell wants to merge 1 commit into
apache:masterfrom
apurtell:HBASE-27258

Conversation

@apurtell

@apurtellapurtell commented Jul 30, 2022

Copy link
Copy Markdown
Contributor

Perhaps I am missing something.

@apurtell
apurtell requested review from Apache9 and ndimidukJuly 30, 2022 01:12
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 59smaster passed
+1 💚compile7m 53smaster passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 33sthe patch passed
+1 💚compile6m 44sthe patch passed
+1 💚javac6m 44sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck13m 51sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
43m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4668
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 1ba42a350d96 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e8c14ee
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count138 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 52smaster passed
+1 💚compile1m 54smaster passed
+1 💚shadedjars3m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 56smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 36sthe patch passed
+1 💚compile1m 57sthe patch passed
+1 💚javac1m 57sthe patch passed
+1 💚shadedjars3m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 56sthe patch passed
_ Other Tests _
-1 ❌unit289m 41sroot in the patch failed.
314m 9s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4668
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8d63a0ae604f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e8c14ee
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/testReport/
Max. process+thread count4908 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 18sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 33smaster passed
+1 💚compile1m 34smaster passed
+1 💚shadedjars3m 43sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 13sthe patch passed
+1 💚compile1m 36sthe patch passed
+1 💚javac1m 36sthe patch passed
+1 💚shadedjars3m 42spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc1m 25sroot generated 6 new + 77 unchanged - 4 fixed = 83 total (was 81)
_ Other Tests _
-1 ❌unit298m 58sroot in the patch failed.
321m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4668
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 23d23d033340 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e8c14ee
Default JavaAdoptOpenJDK-1.8.0_282-b08
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/testReport/
Max. process+thread count2257 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4668/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine

See the documentation here, the user property is called 'argLine', which means it will read the 'argLine' property defined in the properties section by default. This is how the jacoco plugin injects its agent while executing UTs.

@ndimiduk

Copy link
Copy Markdown
Member

@apurtell are you seeing behavior where argLine value is not being honored?

@apurtell

Copy link
Copy Markdown
ContributorAuthor

I have a unit test that is failing with OOME and when looking at the POM I mistakenly thought it was because the -Xmx on the argLine was not being passed through. Thanks for the clarification. Will close this PR and the JIRA.

@apurtellapurtell closed this Aug 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@apurtell@Apache-HBase@Apache9@ndimiduk