Skip to content

HBASE-27260 Set version as 1.7.2 in branch-1 in prep for first RC of … - #4671

Merged
Apache9 merged 1 commit into
apache:branch-1from
Apache9:HBASE-27260
Aug 2, 2022
Merged

HBASE-27260 Set version as 1.7.2 in branch-1 in prep for first RC of …#4671
Apache9 merged 1 commit into
apache:branch-1from
Apache9:HBASE-27260

Conversation

@Apache9

@Apache9Apache9 commented Jul 31, 2022

Copy link
Copy Markdown
Contributor

…1.7.2

@Apache9Apache9 self-assigned this Jul 31, 2022
@Apache-HBase

Apache-HBase commented Jul 31, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec9m 56sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall2m 25sbranch-1 passed
+1 💚compile1m 25sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚compile1m 21sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚checkstyle3m 12sbranch-1 passed
+1 💚shadedjars2m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 42sbranch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 59sbranch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Patch Compile Tests _
+1 💚mvninstall1m 32sbranch-1 passed
+0 🆗mvndep1m 43sMaven dependency ordering for patch
+1 💚mvninstall1m 24sthe patch passed
+1 💚compile1m 15sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javac1m 15sthe patch passed
+1 💚compile1m 17sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚javac1m 17sthe patch passed
+1 💚checkstyle3m 16sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 3sThe patch has 35 ill-formed XML file(s).
+1 💚shadedjars2m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck3m 6sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc1m 39sthe patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚javadoc1m 55sthe patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Other Tests _
-1 ❌unit184m 2sroot in the patch failed.
-1 ❌asflicense0m 21sThe patch generated 1 ASF License warnings.
229m 26s
ReasonTests
XMLParsing Error(s):
hbase-annotations/pom.xml
hbase-archetypes/hbase-archetype-builder/pom.xml
hbase-archetypes/hbase-client-project/pom.xml
hbase-archetypes/hbase-shaded-client-project/pom.xml
hbase-archetypes/pom.xml
hbase-assembly/pom.xml
hbase-checkstyle/pom.xml
hbase-client/pom.xml
hbase-common/pom.xml
hbase-error-prone/pom.xml
hbase-examples/pom.xml
hbase-external-blockcache/pom.xml
hbase-hadoop-compat/pom.xml
hbase-hadoop2-compat/pom.xml
hbase-hbtop/pom.xml
hbase-it/pom.xml
hbase-metrics-api/pom.xml
hbase-metrics/pom.xml
hbase-prefix-tree/pom.xml
hbase-procedure/pom.xml
hbase-protocol/pom.xml
hbase-resource-bundle/pom.xml
hbase-rest/pom.xml
hbase-rsgroup/pom.xml
hbase-server/pom.xml
hbase-shaded/hbase-shaded-check-invariants/pom.xml
hbase-shaded/hbase-shaded-client/pom.xml
hbase-shaded/hbase-shaded-server/pom.xml
hbase-shaded/hbase-shaded-testing-util-tester/pom.xml
hbase-shaded/hbase-shaded-testing-util/pom.xml
hbase-shaded/pom.xml
hbase-shell/pom.xml
hbase-testing-util/pom.xml
hbase-thrift/pom.xml
pom.xml
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.snapshot.TestExportSnapshot
hadoop.hbase.client.TestAdmin1
hadoop.hbase.replication.TestReplicationEndpoint
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.master.TestMasterBalanceThrottling
hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory
hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4671/1/artifact/out/Dockerfile
GITHUB PR#4671
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile checkstyle
unameLinux fcb009b74904 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4671/out/precommit/personality/provided.sh
git revisionbranch-1 / d4b9fce
Default JavaAzul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
xmlhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4671/1/artifact/out/xml.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4671/1/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4671/1/testReport/
asflicensehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4671/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count4238 (vs. ulimit of 10000)
modulesC: . hbase-annotations hbase-archetypes hbase-archetypes/hbase-archetype-builder hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-assembly hbase-checkstyle hbase-client hbase-common hbase-error-prone hbase-examples hbase-external-blockcache hbase-hadoop-compat hbase-hadoop2-compat hbase-hbtop hbase-it hbase-metrics hbase-metrics-api hbase-prefix-tree hbase-procedure hbase-protocol hbase-resource-bundle hbase-rest hbase-rsgroup hbase-server hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-server hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shell hbase-testing-util hbase-thrift U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4671/1/console
versionsgit=2.17.1 maven=3.6.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Aug 1, 2022

Copy link
Copy Markdown
ContributorAuthor

The xml parse error is 'script engine for language js can not be found', seems not very important. Since branch-1 will EOL soon, I do not think it is necessary to fix this problem.

The ASF license error seems strange, let's run rat check locally to see what's the problem. And let me also check the failed UTs.

@Apache9

Apache9 commented Aug 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Run rat check locally, no problem.

Summary
-------
Generated at: 2022-07-31T16:34:25+00:00
Notes: 9
Binaries: 94
Archives: 0
Standards: 194
Apache Licensed: 193
Generated Documents: 0
JavaDocs are generated, thus a license header is optional.
Generated files do not require license headers.
1 Unknown Licenses
*****************************************************
Files with unapproved licenses:
excludes

https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4671/1/artifact/out/patch-asflicense.txt

Seems to be an environment problem, the excludes file is not in our repo. Maybe we download it when running pre commit...

@Apache9

Apache9 commented Aug 1, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ran UTs locally and filtered the output

These are the failed UTs

[ERROR] TestAdmin1.testRegionStateCleanupFromAMMemoryAfterRegionSplitAndMerge:1283 expected:<1> but was:<3>
[ERROR] TestBlockReorderMultiBlocks.testHBaseCluster:214->testFromDFS:260 expected:<[zhangduo-VirtualBox]> but was:<[host1]>
[ERROR] TestSlowLogAccessor.testHigherSlowLogs:227 Waiting timed out after [11,000] msec
[ERROR] TestHRegion.testBatchPut_whileNoRowLocksHeld:1475 Metrics Counters should be equal expected:<158> but was:<157>
[ERROR] TestRSGroupsAdmin2.testMoveServersAndTables:404 Waiting timed out after [300,000] msec
[ERROR] TestRSGroupsAdmin2.testRemoveServers:275 Dead servers shouldn't have been successfully removed.
[ERROR] TestRSGroupsBalance.testGroupBalance:121 Waiting timed out after [300,000] msec

These are the crashed UTs

[ERROR] org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence
[ERROR] org.apache.hadoop.hbase.client.TestFromClientSideNoCodec
[ERROR] org.apache.hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
[ERROR] org.apache.hadoop.hbase.replication.TestMasterReplication
[ERROR] org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream
[ERROR] org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink
[ERROR] org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence
[ERROR] org.apache.hadoop.hbase.client.TestFromClientSideNoCodec
[ERROR] org.apache.hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
[ERROR] org.apache.hadoop.hbase.replication.TestMasterReplication
[ERROR] org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream
[ERROR] org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink

Let me try them separately.

@Apache9

Apache9 commented Aug 2, 2022

Copy link
Copy Markdown
ContributorAuthor

On the failed UTs, TestAdmin1 and TestSlowLogAccessor can pass locally, TestBlockReorderMultiBlocks passed in the pre commit build so it should be my environment. TestHRegion, TestRSGroupsAdmin2, TestRSGroupsBalance are still failing. Let me check whether they are OK in 1.7.1.

@Apache9

Apache9 commented Aug 2, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

OK, they are all fine on 1.7.1.

Let me take a look.

@Apache9

Apache9 commented Aug 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Ah, tried again, they all passed for me locally. Should be flaky...

Let me check the crashed one.

https://nightlies.apache.org/hbase/HBase-Find-Flaky-Tests/branch-1/706/output/dashboard.html

This is the flaky list for branch-1.

GeorryHuang
GeorryHuang approved these changes Aug 2, 2022
View reviewed changes

@GeorryHuangGeorryHuang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

ddupg
ddupg approved these changes Aug 2, 2022
View reviewed changes

@ddupgddupg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9
Apache9 merged commit 4d6b679 into apache:branch-1Aug 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorryHuangGeorryHuangGeorryHuang approved these changes
@ddupgddupgddupg approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@GeorryHuang@ddupg