Skip to content

HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend - #470

Merged
apurtell merged 1 commit into
apache:branch-1from
gjacoby126:HBASE-22623-branch-1
Aug 9, 2019
Merged

HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend#470
apurtell merged 1 commit into
apache:branch-1from
gjacoby126:HBASE-22623-branch-1

Conversation

@gjacoby126

@gjacoby126gjacoby126 commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

This is the branch-1 backport of PR #390 , for HBASE-22623. Since it's a slightly non-trivial backport, opening up a separate PR for ease of review / chance for HBase Robot to pass judgement.

@gjacoby126

Copy link
Copy Markdown
ContributorAuthor

@apurtell@Apache9@anoopsjohn , fyi. The branch-1 backport.

@gjacoby126
gjacoby126force-pushed the HBASE-22623-branch-1 branch from 4515f57 to 1be5074CompareAugust 9, 2019 17:00
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec73Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+1mvninstall600branch-1 passed
+1compile57branch-1 passed with JDK v1.8.0_222
+1compile55branch-1 passed with JDK v1.7.0_232
+1checkstyle126branch-1 passed
+1shadedjars217branch has no errors when building our shaded downstream artifacts.
+1javadoc47branch-1 passed with JDK v1.8.0_222
+1javadoc49branch-1 passed with JDK v1.7.0_232
0spotbugs220Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs216branch-1 passed
_ Patch Compile Tests _
+1mvninstall143the patch passed
+1compile51the patch passed with JDK v1.8.0_222
+1javac51the patch passed
+1compile54the patch passed with JDK v1.7.0_232
+1javac54the patch passed
-1checkstyle114hbase-server: The patch generated 1 new + 636 unchanged - 1 fixed = 637 total (was 637)
+1whitespace0The patch has no whitespace issues.
+1shadedjars220patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck357Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1javadoc40the patch passed with JDK v1.8.0_222
+1javadoc50the patch passed with JDK v1.7.0_232
+1findbugs215the patch passed
_ Other Tests _
-1unit9456hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
12423
ReasonTests
Failed junit testshadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/2/artifact/out/Dockerfile
GITHUB PR#470
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 519955c246bd 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-470/out/precommit/personality/provided.sh
git revisionbranch-1 / e7114f7
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/2/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/2/testReport/
Max. process+thread count4179 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/2/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec1206Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+1mvninstall554branch-1 passed
+1compile41branch-1 passed with JDK v1.8.0_222
+1compile45branch-1 passed with JDK v1.7.0_232
+1checkstyle101branch-1 passed
+1shadedjars181branch has no errors when building our shaded downstream artifacts.
+1javadoc40branch-1 passed with JDK v1.8.0_222
+1javadoc40branch-1 passed with JDK v1.7.0_232
0spotbugs180Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs177branch-1 passed
_ Patch Compile Tests _
+1mvninstall110the patch passed
+1compile38the patch passed with JDK v1.8.0_222
+1javac38the patch passed
+1compile42the patch passed with JDK v1.7.0_232
+1javac42the patch passed
-1checkstyle95hbase-server: The patch generated 1 new + 636 unchanged - 1 fixed = 637 total (was 637)
+1whitespace0The patch has no whitespace issues.
+1shadedjars167patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck304Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1javadoc31the patch passed with JDK v1.8.0_222
+1javadoc40the patch passed with JDK v1.7.0_232
+1findbugs181the patch passed
_ Other Tests _
-1unit9446hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
13097
ReasonTests
Failed junit testshadoop.hbase.master.TestMasterBalanceThrottling
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/1/artifact/out/Dockerfile
GITHUB PR#470
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 0eeb20ca9e17 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-470/out/precommit/personality/provided.sh
git revisionbranch-1 / e7114f7
Default Java1.7.0_232
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/1/testReport/
Max. process+thread count4992 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-470/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@apurtell

Copy link
Copy Markdown
Contributor

TestMasterBalanceThrottling is showing up in a couple of PRs, passes locally.

@apurtell
apurtell merged commit 9888217 into apache:branch-1Aug 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gjacoby126@Apache-HBase@apurtell