Skip to content

Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2 - #4706

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:24163-mob-compactor-string.format-branch-2
Aug 17, 2022
Merged

Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2#4706
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:24163-mob-compactor-string.format-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented Aug 15, 2022

Copy link
Copy Markdown
Member

Signed-off-by: stack stack@apache.org
Signed-off-by: Viraj Jasani vjasani@apache.org
Signed-off-by: Josh Elser elserj@apache.org

@busbey@ndimiduk
HBASE-24163 MOB compactor implementations should use format specifier…
1303562
…s when calling String.format
Signed-off-by: stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Aug 15, 2022
@ndimiduk
ndimiduk requested a review from apurtellAugust 15, 2022 09:41
@ndimiduk

ndimiduk commented Aug 15, 2022

Copy link
Copy Markdown
MemberAuthor

FYI @BukrosSzabolcs

@Apache-HBase

Apache-HBase commented Aug 15, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall2m 19sbranch-2 passed
+1 💚compile2m 15sbranch-2 passed
+1 💚checkstyle0m 33sbranch-2 passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 18sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 10sthe patch passed
+1 💚compile2m 14sthe patch passed
-0 ⚠️javac2m 14shbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚checkstyle0m 31sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 48sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
+1 💚spotbugs1m 23sthe patch passed
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
32m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4706
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 8ce6af393516 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b83165c
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count65 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

This is for aligning the code?

@Apache-HBase

Apache-HBase commented Aug 15, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 22sbranch-2 passed
+1 💚compile0m 34sbranch-2 passed
+1 💚shadedjars3m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 4sthe patch passed
+1 💚compile0m 34sthe patch passed
+1 💚javac0m 34sthe patch passed
+1 💚shadedjars3m 54spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 20sthe patch passed
_ Other Tests _
+1 💚unit185m 39shbase-server in the patch passed.
202m 14s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4706
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7463f699fa97 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b83165c
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/testReport/
Max. process+thread count2364 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 15, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 47sbranch-2 passed
+1 💚compile0m 42sbranch-2 passed
+1 💚shadedjars4m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile0m 42sthe patch passed
+1 💚javac0m 42sthe patch passed
+1 💚shadedjars4m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit184m 27shbase-server in the patch passed.
203m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4706
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 34b71f7a2224 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b83165c
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/testReport/
Max. process+thread count2759 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4706/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimidukndimiduk changed the title HBASE-24163 MOB compactor implementations should use format specifiers when calling String.formatBackport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2Aug 15, 2022
@ndimiduk

ndimiduk commented Aug 15, 2022

Copy link
Copy Markdown
MemberAuthor

This is for aligning the code?

@Apache9 Yes it's one of the missing patches that @BukrosSzabolcs listed on HBASE-27154.

@Apache9

Apache9 commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

This is for aligning the code?

@Apache9 Yes it's one of the missing patches that @BukrosSzabolcs listed on HBASE-27154.

I mean the problem describe on HBASE-24163 does not exist on branch-2. But anyway, no harm to align the code .

@ndimiduk

ndimiduk commented Aug 15, 2022

Copy link
Copy Markdown
MemberAuthor

I mean, maybe @BukrosSzabolcs or @busbey can confirm. I'd rather not backport changes that are not required.

saintstack
saintstack approved these changes Aug 15, 2022
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache9

Apache9 commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

I mean, maybe @BukrosSzabolcs or @busbey can confirm. I'd rather not backport changes that are not required.

The problem on master is we change to use slf4j style formatter but actually we do not use slf4j here, it is String.format...

On branch-2 we even do not use String.format, we just use '+' to concat the error message so no actually bug...

@ndimiduk

ndimiduk commented Aug 17, 2022

Copy link
Copy Markdown
MemberAuthor

Yep, I see that. I wonder what patch brought in the bug that this one fixed on master, it apparently hasn't been back ported to branch-2 yet.

Anyway, I'll continue this backport so that the active release lines remain fairly similar.

@ndimiduk
ndimiduk merged commit 1986a6e into apache:branch-2Aug 17, 2022
@ndimiduk
ndimiduk deleted the 24163-mob-compactor-string.format-branch-2 branch August 17, 2022 11:47
@busbey

busbey commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

One of the distributed mob compaction changes brought in this bug on master

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes
@Apache9Apache9Apache9 approved these changes
@apurtellapurtellAwaiting requested review from apurtell
@huaxiangsunhuaxiangsunAwaiting requested review from huaxiangsun

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ndimiduk@Apache-HBase@Apache9@busbey@saintstack