Skip to content

HBASE-22829 Removed deprecated methods from SnapshotDescription - #472

Merged
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-22829
Aug 12, 2019
Merged

HBASE-22829 Removed deprecated methods from SnapshotDescription#472
HorizonNet merged 1 commit into
apache:masterfrom
ultratendency:HBASE-22829

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec147Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep46Maven dependency ordering for branch
+1mvninstall424master passed
+1compile100master passed
+1checkstyle130master passed
+1shadedjars350branch has no errors when building our shaded downstream artifacts.
+1javadoc69master passed
0spotbugs317Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs394master passed
_ Patch Compile Tests _
0mvndep18Maven dependency ordering for patch
+1mvninstall416the patch passed
+1compile106the patch passed
+1javac106the patch passed
+1checkstyle138the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars343patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1260Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc76the patch passed
+1findbugs401the patch passed
_ Other Tests _
+1unit123hbase-client in the patch passed.
-1unit14473hbase-server in the patch failed.
+1asflicense49The patch does not generate ASF License warnings.
19566
ReasonTests
Failed junit testshadoop.hbase.replication.TestReplicationKillSlaveRS
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/1/artifact/out/Dockerfile
GITHUB PR#472
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 64113f9262e5 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-472/out/precommit/personality/provided.sh
git revisionmaster / c8f57bf
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/1/testReport/
Max. process+thread count4636 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the unit test failure. If not related, +1 on commit. THanks.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec99Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep35Maven dependency ordering for branch
+1mvninstall361master passed
+1compile83master passed
+1checkstyle116master passed
+1shadedjars286branch has no errors when building our shaded downstream artifacts.
+1javadoc59master passed
0spotbugs283Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs354master passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall312the patch passed
+1compile80the patch passed
+1javac80the patch passed
+1checkstyle114the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck983Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc53the patch passed
+1findbugs332the patch passed
_ Other Tests _
+1unit100hbase-client in the patch passed.
-1unit14017hbase-server in the patch failed.
+1asflicense47The patch does not generate ASF License warnings.
18123
ReasonTests
Failed junit testshadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.quotas.TestQuotaAdmin
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/artifact/out/Dockerfile
GITHUB PR#472
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 07089a6ea55d 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-472/out/precommit/personality/provided.sh
git revisionmaster / 15c903b
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/testReport/
Max. process+thread count4619 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec145Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0mvndep49Maven dependency ordering for branch
+1mvninstall488master passed
+1compile102master passed
+1checkstyle127master passed
+1shadedjars335branch has no errors when building our shaded downstream artifacts.
+1javadoc69master passed
0spotbugs286Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs364master passed
_ Patch Compile Tests _
0mvndep18Maven dependency ordering for patch
+1mvninstall413the patch passed
+1compile102the patch passed
+1javac102the patch passed
+1checkstyle133the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars337patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1286Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc68the patch passed
+1findbugs396the patch passed
_ Other Tests _
+1unit115hbase-client in the patch passed.
+1unit13668hbase-server in the patch passed.
+1asflicense46The patch does not generate ASF License warnings.
18751
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/3/artifact/out/Dockerfile
GITHUB PR#472
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a7f8081f4bfc 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-472@2/out/precommit/personality/provided.sh
git revisionmaster / e938215
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/3/testReport/
Max. process+thread count4788 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit 3867fae into apache:masterAug 12, 2019
@HorizonNet
HorizonNet deleted the HBASE-22829 branch August 12, 2019 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HorizonNet@Apache-HBase@saintstack