Uh oh!
There was an error while loading. Please reload this page.
HBASE-27340 Artifacts with resolved profiles (#4740) - #4761
Merged
Conversation
(Forward port from branch-2; simplified by the fact that there is no hadoop-2.0 profile on master branch) Make it so our published poms carry the minimum needed to run an hbase; the published pom has no profiles -- the profiles specified at build time are resolved, their dependencies inlined, and then they are stripped -- and no build-time, or plugins dependencies or properties, etc. Resultant poms have explicit hadoop lib versions baked in -- no more being able to choose hbase with hadoop2 or haddop3 at downstream build time by setting a '-Dhadoop.profile=X.0'. Pattern is to add profiles when none in sub-modules when the flatten plugin complains it can't resolve an hadoop dependency's 'version' (e.g. hadoop-common, hadoop-hdfs). Adding the profile in the sub-module make it so the flatten plugin can figure 'hadoop.version' definitively. (In master there is only the hadoop-3.0 profile). Another spin on the above happens when profiles already exist in submodule but the flatten plugin is complaining it can't figure figure version on an hadoop dependency NOT under profiles. Below, we move the delinquent hadoop dependency under existing profiles (minikdc was the usual dependency outside profiles in sub-modules that flatten complained about). Sometimes, moving an hadoop dependency under a profile, there would be excludes on the local dependency. If the parent pom excludes section was missing the local excludes, we added them up to the parent module so all excluding is done up there in the parent profile dependencyManagement section.
saintstack
commented
Sep 3, 2022
ContributorAuthor
Even though there is no hadoop-2.0 profile in master, there is the hadoop-3.0 profile. A few hadoop dependencies are included but not under the hadoop-3.0 profile and without explicit version which causes flatten-plugin difficultly. This explains movement of dependencies under hadoop-3.0 profiles in this master patch (just as we did on branch-2 but less movement needed). |
Apache-HBase
commented
Sep 3, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 3, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 3, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Sep 4, 2022
Apache9
commented
Sep 6, 2022
Contributor
Let's get this done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Forward port from branch-2; simplified by the fact that there
is no hadoop-2.0 profile on master branch)