Skip to content

HBASE-27561 hbase.master.port is ignored in processing of hbase.masters - #4952

Merged
apurtell merged 1 commit into
apache:masterfrom
apurtell:HBASE-27561
Jan 17, 2023
Merged

HBASE-27561 hbase.master.port is ignored in processing of hbase.masters#4952
apurtell merged 1 commit into
apache:masterfrom
apurtell:HBASE-27561

Conversation

@apurtell

@apurtellapurtell commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Setting of hbase.master.port is ignored in default processing of hbase.masters.

For example,

hbase.masters=localhost
hbase.master.port=8100

"Server at localhost:16000" is in the failed servers list"

but:

hbase.masters=localhost:8100
hbase.master.port=8100

and all is well. This is confusing and a minor configuration handling bug.

@Apache-HBase

Apache-HBase commented Jan 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 22sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 56smaster passed
+1 💚compile4m 23smaster passed
+1 💚checkstyle1m 11smaster passed
+1 💚spotless1m 1sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 46sthe patch passed
+1 💚compile4m 4sthe patch passed
+1 💚javac4m 4sthe patch passed
+1 💚checkstyle1m 3sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck14m 13sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 58spatch has no errors when running spotless:check.
+1 💚spotbugs3m 11sthe patch passed
_ Other Tests _
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
52m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4952
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 6b38240237ff 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f1087f
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 47smaster passed
+1 💚compile0m 58smaster passed
+1 💚shadedjars3m 56sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 24sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚shadedjars3m 57spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 34sthe patch passed
_ Other Tests _
+1 💚unit1m 20shbase-client in the patch passed.
+1 💚unit199m 51shbase-server in the patch passed.
223m 51s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4952
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 78c011eb7f99 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f1087f
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/testReport/
Max. process+thread count2687 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 10, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 15sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 17smaster passed
+1 💚compile0m 58smaster passed
+1 💚shadedjars3m 47sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚shadedjars3m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit1m 17shbase-client in the patch passed.
-1 ❌unit207m 59shbase-server in the patch failed.
231m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4952
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a34a1016a924 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3f1087f
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/testReport/
Max. process+thread count2431 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4952/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
apurtell merged commit 71d0862 into apache:masterJan 17, 2023
@apurtell
apurtell deleted the HBASE-27561 branch January 17, 2023 21:20
asfgit pushed a commit that referenced this pull request Jan 17, 2023
@apurtell
HBASE-27561hbase.master.port is ignored in processing of hbase.maste…
28da154
…rs (#4952)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
asfgit pushed a commit that referenced this pull request Jan 17, 2023
@apurtell
HBASE-27561hbase.master.port is ignored in processing of hbase.maste…
0a88314
…rs (#4952)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
Conflicts:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
asfgit pushed a commit that referenced this pull request Jan 17, 2023
@apurtell
HBASE-27561hbase.master.port is ignored in processing of hbase.maste…
e124b31
…rs (#4952)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@apurtell
HBASE-27561 hbase.master.port is ignored in processing of hbase.maste…
fa52292
…rs (apache#4952)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Reid Chan <reidchan@apache.org>
Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
(cherry picked from commit 0a88314)
Change-Id: Ib1242bda179c41275846e8a36f94cbd6333dedfb
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes
@ReiddddddReiddddddReidddddd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apurtell@Apache-HBase@Apache9@Reidddddd