Skip to content

HBASE-27583 Remove -X option when building protoc check in nightly an… - #4988

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27583
Jan 24, 2023
Merged

HBASE-27583 Remove -X option when building protoc check in nightly an…#4988
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-27583

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…d pre commit job

@Apache9Apache9 self-assigned this Jan 21, 2023
@Apache-HBase

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console in case of problems.

2 similar comments
@Apache-HBase

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console in case of problems.

@Apache-HBase

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console in case of problems.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 46sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
4m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4988
Optional Tests
unameLinux 75890fd051be 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d450d
Max. process+thread count33 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
+1 💚shellcheck0m 1sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
_ Other Tests _
+0 🆗asflicense0m 1sASF License check generated no output?
5m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4988
Optional Testsdupname asflicense spotless shellcheck shelldocs
unameLinux fe5f95d38220 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d450d
Max. process+thread count44 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 56sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for patch
_ Other Tests _
6m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4988
Optional Tests
unameLinux d8527789d70a 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 83d450d
Max. process+thread count42 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreaultbbeaudreault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change makes sense to me. -X is incredibly verbose, so not sure it's useful unless explicitly debugging.

I wonder if we should enable -X when someone checks this checkbox:

Screen Shot 2023-01-24 at 9 45 17 AM

I have no idea how we'd pipe that through, so feel free to disregard. Just a thought.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

this change makes sense to me. -X is incredibly verbose, so not sure it's useful unless explicitly debugging.

I wonder if we should enable -X when someone checks this checkbox:

Screen Shot 2023-01-24 at 9 45 17 AM

I have no idea how we'd pipe that through, so feel free to disregard. Just a thought.

We could check if we could do this later. Let's solve the space problem first. And IIRC we do have some places to add the -X option when DEBUG is enabled.

@Apache9
Apache9 merged commit 5bdf264 into apache:masterJan 24, 2023
Apache9 added a commit that referenced this pull request Jan 24, 2023
…d pre commit job (#4988)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
Apache9 added a commit that referenced this pull request Jan 24, 2023
…d pre commit job (#4988)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
Apache9 added a commit that referenced this pull request Jan 24, 2023
…d pre commit job (#4988)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…d pre commit job (apache#4988)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
(cherry picked from commit 45d0df7)
Change-Id: Idfe2929d68a5f943ac2735a7f593918147e60033
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@bbeaudreault