Skip to content

HBASE-27618: Upgrade Curator version to 5.4.0 and Zookeeper to 3.8.1 - #5013

Open
szucsvillo wants to merge 1 commit into
apache:masterfrom
szucsvillo:HBASE-27618
Open

HBASE-27618: Upgrade Curator version to 5.4.0 and Zookeeper to 3.8.1#5013
szucsvillo wants to merge 1 commit into
apache:masterfrom
szucsvillo:HBASE-27618

Conversation

@szucsvillo

Copy link
Copy Markdown

No description provided.

Change-Id: I8a13f0c1334e56912e06e998e076815dc31520a3
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 22sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 1smaster passed
+1 💚compile1m 25smaster passed
+1 💚shadedjars4m 35sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 47sthe patch passed
+1 💚compile1m 25sthe patch passed
+1 💚javac1m 25sthe patch passed
+1 💚shadedjars4m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17sthe patch passed
_ Other Tests _
-1 ❌unit13m 49sroot in the patch failed.
36m 21s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5013
JIRA IssueHBASE-27618
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4061e0729388 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 198a3b7
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/testReport/
Max. process+thread count671 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 40smaster passed
+1 💚compile4m 46smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile4m 40sthe patch passed
+1 💚javac4m 40sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck12m 11sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
37m 44s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5013
JIRA IssueHBASE-27618
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 62cd7afacf83 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 198a3b7
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 23sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 32smaster passed
+1 💚compile1m 41smaster passed
+1 💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 42smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile1m 42sthe patch passed
+1 💚javac1m 42sthe patch passed
+1 💚shadedjars4m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 41sthe patch passed
_ Other Tests _
-1 ❌unit14m 17sroot in the patch failed.
39m 5s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5013
JIRA IssueHBASE-27618
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 840883d17d35 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 198a3b7
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/testReport/
Max. process+thread count774 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5013/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

So what is the intention here? We do not use new features of zookeeper and curator, keeping an old version can have most compatibility?

Thanks.

@szucsvillo

Copy link
Copy Markdown
Author

So what is the intention here? We do not use new features of zookeeper and curator, keeping an old version can have most compatibility?

Thanks.

I think we should upgrade, because ZooKeeper 3.5 is EoL since 1st of June, 2022. (https://zookeeper.apache.org/releases.html)
ZooKeeper clients from 3.5.x onwards are fully compatible with 3.8.x servers.
ZooKeeper 3.8.x clients are compatible with 3.5.x, 3.6.x and 3.7.x servers as long as we are not using new APIs not present these versions.

@Apache9

Copy link
Copy Markdown
Contributor

So what is the intention here? We do not use new features of zookeeper and curator, keeping an old version can have most compatibility?
Thanks.

I think we should upgrade, because ZooKeeper 3.5 is EoL since 1st of June, 2022. (https://zookeeper.apache.org/releases.html) ZooKeeper clients from 3.5.x onwards are fully compatible with 3.8.x servers. ZooKeeper 3.8.x clients are compatible with 3.5.x, 3.6.x and 3.7.x servers as long as we are not using new APIs not present these versions.

Let's start a discussion thread on the dev mailing list?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@szucsvillo@Apache-HBase@Apache9