Backport "HBASE-23561 Look up of Region in Master by encoded region name is O(n)" and addendum to branch-2 by ndimiduk · Pull Request #5049 · apache/hbase

ndimiduk · 2023-02-21T16:15:31Z

Depends on backport of HBASE-23102 / #5048 ; will rebase once that one is merged.

apache#1193) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

Apache-HBase · 2023-02-27T11:09:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 38s	branch-2 passed
+1 💚	compile	2m 22s	branch-2 passed
+1 💚	checkstyle	0m 35s	branch-2 passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 27s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 35s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	1m 37s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		37m 25s

Reason	Tests
FindBugs	module:hbase-server
	Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo) At RegionStates.java:ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo) At RegionStates.java:[line 129]

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5049
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c3df54cbc913 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3b6d8c3`
Default Java	Eclipse Adoptium-11.0.17+8
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-27T14:43:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 45s	branch-2 passed
+1 💚	compile	0m 41s	branch-2 passed
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 53s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	5m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	216m 13s	hbase-server in the patch passed.
		240m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5049
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2b9da235e0ba 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3b6d8c3`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/testReport/
Max. process+thread count	2341 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-27T15:00:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 40s	branch-2 passed
+1 💚	compile	0m 46s	branch-2 passed
+1 💚	shadedjars	4m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	4m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	211m 39s	hbase-server in the patch passed.
		236m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5049
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d0b2dab2d600 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3b6d8c3`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/testReport/
Max. process+thread count	2339 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2023-03-01T14:09:32Z

Existing spot-bugs issue as also present on master, fixed in HBASE-23983. Will backport that too.

ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Feb 21, 2023

ndimiduk requested review from bharathv, petersomogyi and wchevreuil February 21, 2023 16:15

petersomogyi approved these changes Feb 21, 2023
View reviewed changes

This comment was marked as outdated.
Sign in to view

mwkang added 2 commits February 27, 2023 11:29

HBASE-23561 Look up of Region in Master by encoded region name is O(n) (
574a76e
apache#1193) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

HBASE-23561 acquire lock before update regionsMap (apache#1263)
f78bf84
Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

ndimiduk force-pushed the 23561-master-region-by-region-name-O-n-branch-2 branch from 468fb7c to f78bf84Compare February 27, 2023 10:29

ndimiduk merged commit 13e06c7 into apache:branch-2Mar 1, 2023

ndimiduk deleted the 23561-master-region-by-region-name-O-n-branch-2 branch March 1, 2023 14:11

Navigation Menu

Uh oh!

Backport "HBASE-23561 Look up of Region in Master by encoded region name is O(n)" and addendum to branch-2 - #5049

Backport "HBASE-23561 Look up of Region in Master by encoded region name is O(n)" and addendum to branch-2#5049
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:23561-master-region-by-region-name-O-n-branch-2

ndimiduk commented Feb 21, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Feb 27, 2023

Uh oh!

Apache-HBase commented Feb 27, 2023

Uh oh!

Apache-HBase commented Feb 27, 2023

Uh oh!

ndimiduk commented Mar 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ndimiduk commented Feb 21, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Feb 27, 2023

Uh oh!

Apache-HBase commented Feb 27, 2023

Uh oh!

Apache-HBase commented Feb 27, 2023

Uh oh!

ndimiduk commented Mar 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants