Skip to content

Backport "HBASE-23561 Look up of Region in Master by encoded region name is O(n)" to branch-2.5 - #5070

Merged
ndimiduk merged 2 commits into
apache:branch-2.5from
ndimiduk:23561-master-region-by-region-name-O-n-branch-2.5
Mar 3, 2023
Merged

Backport "HBASE-23561 Look up of Region in Master by encoded region name is O(n)" to branch-2.5#5070
ndimiduk merged 2 commits into
apache:branch-2.5from
ndimiduk:23561-master-region-by-region-name-O-n-branch-2.5

Conversation

@ndimiduk

@ndimidukndimiduk commented Mar 1, 2023

Copy link
Copy Markdown
Member

No description provided.

mwkang added 2 commits March 1, 2023 15:11
@mwkang@ndimiduk
HBASE-23561 Look up of Region in Master by encoded region name is O(n) (
dc2a6ab
apache#1193)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
@mwkang@ndimiduk
HBASE-23561 acquire lock before update regionsMap (apache#1263)
20d3b88
Addendum: tie add and delete of regionMap and encodedRegionsMap
Signed-off-by: stack <stack@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Mar 1, 2023
@Apache-HBase

Apache-HBase commented Mar 1, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+1 💚mvninstall3m 47sbranch-2.5 passed
+1 💚compile2m 22sbranch-2.5 passed
+1 💚checkstyle0m 33sbranch-2.5 passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 22sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 12sthe patch passed
+1 💚compile2m 22sthe patch passed
+1 💚javac2m 22sthe patch passed
+1 💚checkstyle0m 31sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 59sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚spotless0m 37spatch has no errors when running spotless:check.
-1 ❌spotbugs1m 28shbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
37m 38s
ReasonTests
FindBugsmodule:hbase-server
Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo) At RegionStates.java:ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo) At RegionStates.java:[line 129]
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5070
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux eaaba07e2fbe 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / a5d0f26
Default JavaEclipse Adoptium-11.0.17+8
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 1, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 55sbranch-2.5 passed
+1 💚compile0m 34sbranch-2.5 passed
+1 💚shadedjars4m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 37sthe patch passed
+1 💚compile0m 35sthe patch passed
+1 💚javac0m 35sthe patch passed
+1 💚shadedjars4m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21sthe patch passed
_ Other Tests _
+1 💚unit187m 54shbase-server in the patch passed.
208m 52s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5070
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5569a1fb5d32 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / a5d0f26
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/testReport/
Max. process+thread count2578 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 1, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 36sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall4m 24sbranch-2.5 passed
+1 💚compile1m 4sbranch-2.5 passed
+1 💚shadedjars6m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 16sthe patch passed
+1 💚compile0m 51sthe patch passed
+1 💚javac0m 51sthe patch passed
+1 💚shadedjars5m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28sthe patch passed
_ Other Tests _
+1 💚unit226m 48shbase-server in the patch passed.
256m 23s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5070
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fe229f80dda8 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / a5d0f26
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/testReport/
Max. process+thread count2377 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5070/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit cbfdbff into apache:branch-2.5Mar 3, 2023
@ndimiduk
ndimiduk deleted the 23561-master-region-by-region-name-O-n-branch-2.5 branch March 3, 2023 09:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@mwkang