Skip to content

HBASE-27638 Get slow/large log response that matched the ‘CLIENT_IP' … - #5087

Merged
pankaj72981 merged 3 commits into
apache:masterfrom
mokai87:master
Nov 13, 2024
Merged

HBASE-27638 Get slow/large log response that matched the ‘CLIENT_IP' …#5087
pankaj72981 merged 3 commits into
apache:masterfrom
mokai87:master

Conversation

@mokai87

Copy link
Copy Markdown
Contributor

…without client port

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@pankaj72981pankaj72981 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mokai87 for raising the PR. Changes looks fine, can you please update help message in the ruby script as well.

@pankaj72981

Copy link
Copy Markdown
Contributor

@virajjasani Can you please have a look on this.

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the changes, good to go after @pankaj72981's comments are addressed

@mokai87

Copy link
Copy Markdown
ContributorAuthor

Thanks @mokai87 for raising the PR. Changes looks fine, can you please update help message in the ruby script as well.

@pankaj72981 Thanks for the review. Help message updated.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@virajjasani

Copy link
Copy Markdown
Contributor

thanks @mokai87!

@pankaj72981 sir, could you please also take another look?

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile3m 54smaster passed
+1 💚checkstyle0m 59smaster passed
+1 💚spotbugs2m 5smaster passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile3m 58sthe patch passed
+1 💚javac3m 58sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 58sthe patch passed
+1 💚rubocop0m 5sNo new issues.
+1 💚spotbugs2m 18sthe patch passed
+1 💚hadoopcheck10m 17sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
39m 48s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5087
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless rubocop
unameLinux 5a995072b958 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3c12f7b
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-server hbase-mapreduce hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 1smaster passed
+1 💚compile1m 36smaster passed
+1 💚javadoc0m 57smaster passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 55sthe patch passed
+1 💚compile1m 36sthe patch passed
+1 💚javac1m 36sthe patch passed
+1 💚javadoc0m 57sthe patch passed
+1 💚shadedjars5m 17spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit262m 14shbase-server in the patch passed.
+1 💚unit20m 42shbase-mapreduce in the patch passed.
+1 💚unit7m 7shbase-shell in the patch passed.
318m 2s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5087
Optional Testsjavac javadoc unit compile shadedjars
unameLinux eef2589995ae 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3c12f7b
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/testReport/
Max. process+thread count5795 (vs. ulimit of 30000)
modulesC: hbase-server hbase-mapreduce hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981
pankaj72981 merged commit 7fdc248 into apache:masterNov 13, 2024
pankaj72981 pushed a commit that referenced this pull request Nov 13, 2024
…without client port (#5087)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 7fdc248)
mokai87 added a commit to mokai87/hbase that referenced this pull request Nov 14, 2024
pankaj72981 pushed a commit that referenced this pull request Nov 14, 2024
…without client port (#5087) (#6471)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
pankaj72981 pushed a commit that referenced this pull request Nov 14, 2024
…without client port (#5087) (#6471)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 004ebe5)
pankaj72981 pushed a commit that referenced this pull request Nov 14, 2024
…without client port (#5087) (#6471)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 004ebe5)
gvprathyusha6 pushed a commit to gvprathyusha6/hbase that referenced this pull request Dec 19, 2024
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
…without client port (apache#5087) (apache#6471)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 004ebe5)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mokai87@Apache-HBase@pankaj72981@virajjasani