Skip to content

HBASE-27710 ByteBuff ref counting is too expensive for on-heap buffers - #5115

Merged
bbeaudreault merged 3 commits into
apache:branch-2from
HubSpot:HBASE-27710-2
Mar 17, 2023
Merged

HBASE-27710 ByteBuff ref counting is too expensive for on-heap buffers#5115
bbeaudreault merged 3 commits into
apache:branch-2from
HubSpot:HBASE-27710-2

Conversation

@bbeaudreault

@bbeaudreaultbbeaudreault commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@bbeaudreaultbbeaudreault added the backport This PR is a back port of some issue or issues already committed to master label Mar 17, 2023
@Apache-HBase

Apache-HBase commented Mar 17, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 31sbranch-2 passed
+1 💚compile2m 56sbranch-2 passed
+1 💚checkstyle0m 53sbranch-2 passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 59sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile2m 54sthe patch passed
-0 ⚠️javac2m 22shbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚checkstyle0m 52sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck17m 47sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs2m 15sthe patch passed
_ Other Tests _
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
41m 20s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5115
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
unameLinux 5a32bc581dbb 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d136c6d
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 17, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 39sbranch-2 passed
+1 💚compile0m 56sbranch-2 passed
+1 💚shadedjars4m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚shadedjars4m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit2m 1shbase-common in the patch passed.
+1 💚unit195m 59shbase-server in the patch passed.
222m 52s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5115
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f16e5f5c7fc5 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d136c6d
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/testReport/
Max. process+thread count2756 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 17, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 43sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 48sbranch-2 passed
+1 💚compile0m 56sbranch-2 passed
+1 💚shadedjars4m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 40sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars4m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit1m 49shbase-common in the patch passed.
+1 💚unit208m 29shbase-server in the patch passed.
237m 51s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5115
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c3a6d10f4a1d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d136c6d
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/testReport/
Max. process+thread count2080 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5115/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
Revert "trigger build"
61412bd
This reverts commit 63e75be.
@bbeaudreault
bbeaudreault merged commit 5de1e4f into apache:branch-2Mar 17, 2023
@bbeaudreault
bbeaudreault deleted the HBASE-27710-2 branch March 17, 2023 19:24
bbeaudreault added a commit that referenced this pull request Mar 17, 2023
@bbeaudreault
HBASE-27710ByteBuff ref counting is too expensive for on-heap buffers (
29c3230
#5115)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
bbeaudreault added a commit that referenced this pull request Mar 17, 2023
@bbeaudreault
HBASE-27710ByteBuff ref counting is too expensive for on-heap buffers (
acda5b7
#5115)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Mar 23, 2023
@bbeaudreault
HubSpot Backport: HBASE-27710 ByteBuff ref counting is too expensive …
a8a06b5
…for on-heap buffers (apache#5115)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@bbeaudreault@petersomogyi
HBASE-27710 ByteBuff ref counting is too expensive for on-heap buffers (
ec8273f
apache#5115)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit acda5b7)
Change-Id: Iba5a67cfa2fe6b03a92ae3ba8190ca30dbf7b300
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bbeaudreault@Apache-HBase