Skip to content

HBASE-27851 Fix TestListTablesByState which is silently failing due to a surefire bug - #5227

Merged
Apache9 merged 1 commit into
apache:masterfrom
linux-on-ibm-z:fix-TestListTablesByState
May 11, 2023
Merged

HBASE-27851 Fix TestListTablesByState which is silently failing due to a surefire bug#5227
Apache9 merged 1 commit into
apache:masterfrom
linux-on-ibm-z:fix-TestListTablesByState

Conversation

@jonathan-albrecht-ibm

Copy link
Copy Markdown
Contributor

Surefire version 3.0.0-M6 has a bug where tests end up being removed from the test results if they fail with a long exception message. See:

https://issues.apache.org/jira/browse/SUREFIRE-2079

TestListTablesByState is currently failing due to an error. However, it is being missed because of the surefire bug. I found this while testing the final surfire 3.0.0 version which fixes the bug and the test then shows up as failing.

…o a surefire bug
surefire version 3.0.0-M6 has a bug where tests end up being removed from
the test results if they fail with a long exception message. See:
https://issues.apache.org/jira/browse/SUREFIRE-2079
TestListTablesByState is currently failing due to an error. However,
it is being missed because of the surefire bug. I found this while testing
the final surfire 3.0.0 version which fixes the bug and the test then
shows up as failing.
Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 37smaster passed
+1 💚compile2m 22smaster passed
+1 💚checkstyle0m 35smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 30smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 21sthe patch passed
+1 💚compile2m 21sthe patch passed
+1 💚javac2m 21sthe patch passed
+1 💚checkstyle0m 36sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 11sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs1m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
39m 45s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5227
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 2c6fac20f2ea 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d49df8b
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
-1 ❌mvninstall3m 26sroot in master failed.
+1 💚compile0m 39smaster passed
+1 💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 5sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚shadedjars4m 52spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit212m 31shbase-server in the patch passed.
236m 49s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5227
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cc60fa20314a 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d49df8b
Default JavaTemurin-1.8.0_352-b08
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/testReport/
Max. process+thread count2811 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 37smaster passed
+1 💚compile0m 47smaster passed
+1 💚shadedjars4m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile0m 46sthe patch passed
+1 💚javac0m 46sthe patch passed
+1 💚shadedjars4m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sthe patch passed
_ Other Tests _
-1 ❌unit217m 24shbase-server in the patch failed.
242m 10s
SubsystemReport/Notes
DockerClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5227
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 19ef573ab800 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d49df8b
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/testReport/
Max. process+thread count3043 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jonathan-albrecht-ibm

Copy link
Copy Markdown
ContributorAuthor

Two tests failed in the precommit checks but I don't think they are related to my changes which are just in one test class.

Failed tests:

  • precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.io.hfile.TestBlockEvictionOnRegionMovement.(?)
  • precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk.test

@jonathan-albrecht-ibm

Copy link
Copy Markdown
ContributorAuthor

org.apache.hadoop.hbase.master.TestListTablesByState is now showing up in the test results:

https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5227/1/testReport/org.apache.hadoop.hbase.master/TestListTablesByState/

@Apache9
Apache9 merged commit 55aff4c into apache:masterMay 11, 2023
Apache9 pushed a commit that referenced this pull request May 11, 2023
…o a surefire bug (#5227)
surefire version 3.0.0-M6 has a bug where tests end up being removed from
the test results if they fail with a long exception message. See:
https://issues.apache.org/jira/browse/SUREFIRE-2079
TestListTablesByState is currently failing due to an error. However,
it is being missed because of the surefire bug. I found this while testing
the final surfire 3.0.0 version which fixes the bug and the test then
shows up as failing.
Co-authored-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 55aff4c)
@jonathan-albrecht-ibm

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing and merging @Apache9!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathan-albrecht-ibm@Apache-HBase@Apache9