[HBASE-22852] Stop gpg agent daemons in hbase nightlies.

[shahrs87]

https://issues.apache.org/jira/browse/HBASE-22852
@busbey please review.

[shahrs87]

Once reviewed, I will create PR for other branches.

[busbey]

Once reviewed, I will create PR for other branches.

you shouldn't need to do this unless the committer who applies your patch asks for it. by default we push to all applicable branches.

[saintstack]

What you think @busbey ?

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	109	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	shellcheck	0	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	19	The patch does not generate ASF License warnings.
		195

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/16/artifact/out/Dockerfile
GITHUB PR	#525
JIRA Issue	HBASE-22852
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux 814a8e87937f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
git revision	master / 1ea5d8b
Max. process+thread count	41 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/16/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[busbey]

It looks fine, I haven't gotten to try it out to confirm it works. If someone else did, don't let me hold you up.

[shahrs87]

I verified that we are shutting down the ggp agent with the following small extracted version of dev-support/jenkins-scripts/cache-apache-project-artifact.sh.
Here is the test program.

----------- Start test program -------------------
`(base) rushabhshah-ltm:gpg-test rushabh.shah$ cat test-gpg-kill.sh
set -e

function cleanup {
echo "Before stopping gpg agent daemon"
ps -ef | grep gpg-agent
echo "Stopping gpg agent daemon"
gpgconf --homedir "/Users/rushabh.shah/gpg-test/.gpg" --kill gpg-agent
echo "Stopped gpg agent daemon"

echo "After stopping gpg agent daemon"
ps -ef | grep gpg-agent

}
trap cleanup EXIT SIGQUIT

rm -rf /Users/rushabh.shah/gpg-test/.gpg
rm -f /Users/rushabh.shah/gpg-test/*.asc
rm -f /Users/rushabh.shah/gpg-test/KEYS
mkdir /Users/rushabh.shah/gpg-test/.gpg
chmod -R 700 /Users/rushabh.shah/gpg-test/.gpg

curl -L --fail -o /Users/rushabh.shah/gpg-test/artifact.asc "https://archive.apache.org/dist/hadoop/common/hadoop-2.8.5/hadoop-2.8.5.tar.gz.asc"
curl -L --fail -o /Users/rushabh.shah/gpg-test/KEYS "http://www.apache.org/dist/hadoop/common/KEYS"

gpg --homedir /Users/rushabh.shah/gpg-test/.gpg --import /Users/rushabh.shah/gpg-test/KEYS

echo "verifying artifact signature"
gpg --homedir "/Users/rushabh.shah/gpg-test/.gpg" --verify "/Users/rushabh.shah/gpg-test/artifact.asc"
# injected exception here
echo "signature good."`
---------------------- End test program --------------------------------

Below is the output of the program.
---------------------- Start output of test program --------------------------------

(base) rushabhshah-ltm:gpg-test rushabh.shah$ sh test-gpg-kill.sh
gpg: keybox '/Users/rushabh.shah/gpg-test/.gpg/pubring.kbx' created
Importing bunch of keys
gpg: Total number processed: 51
gpg: imported: 51
gpg: no ultimately trusted keys found
verifying artifact signature
gpg: no signed data
gpg: can't hash datafile: No data
Before stopping gpg agent daemon
414592180 50900 1 0 18Aug19 ?? 0:00.01 /bin/bash /usr/local/MacGPG2/libexec/shutdown-gpg-agent
414592180 95647 1 0 1:06PM ?? 0:00.00 gpg-agent --homedir /Users/rushabh.shah/gpg-test/.gpg --use-standard-socket --daemon
414592180 95650 95635 0 1:06PM ttys009 0:00.00 grep gpg-agent
Stopping gpg agent daemon
Stopped gpg agent daemon
After stopping gpg agent daemon
414592180 50900 1 0 18Aug19 ?? 0:00.01 /bin/bash /usr/local/MacGPG2/libexec/shutdown-gpg-agent
414592180 95654 95635 0 1:06PM ttys009 0:00.00 grep gpg-agent
---------------------- End output of test program --------------------------------

@saintstack@busbey Hope this testing helps.