Uh oh!
There was an error while loading. Please reload this page.
HBASE-27683 Should support single call queue mode for RPC handlers wh… - #5259
Open
sunhelly wants to merge 1 commit into
Open
HBASE-27683 Should support single call queue mode for RPC handlers wh…#5259sunhelly wants to merge 1 commit into
sunhelly wants to merge 1 commit into
Conversation
…ile separating by request type
Apache-HBase
commented
May 30, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 30, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 30, 2023
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
May 31, 2023
| writeHandlersCount = Math.max(numWriteQueues, calcNumWriters(handlerCount, callqReadShare)); | ||
| int readQueues = calcNumReaders(this.numCallQueues, callqReadShare); | ||
| int readQueues = callqReadShare > 0 ? |
Contributor
There was a problem hiding this comment.
What is the return value of calcNumReaders if callqReadShare is 0?
ContributorAuthor
There was a problem hiding this comment.
If callqReadShare==0, it will not be an instance of RWQueueRpcExecutor, then will not call calcNumReaders. But readQueues will be 0 under other circumstances by the origin design, when the numCallQueues=1 and numWriteQueues=1.
Contributor
There was a problem hiding this comment.
What do you mean by "will not call calcNumReaders"? Either in the old code or in your new code, we will always call the calcNumReaders method?
ContributorAuthor
There was a problem hiding this comment.
Thanks. I think when callqReadShare is 0, the RpcExecutor will be FastPathBalancedQueueRpcExecutor by default (see SimpleRpcScheduler line 88), not based on RWQueueRpcExecutor(which by default will create FastPathRWQueueRpcExecutor), and then there are not distinguished queues, all queues serve for read and write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ile separating by request type