Skip to content

HBASE-27871 Meta replication stuck forever if wal it's still reading gets rolled and deleted - #5271

Merged
wchevreuil merged 1 commit into
apache:branch-2.5from
wchevreuil:HBASE-27871-branch-2.5
Jun 15, 2023
Merged

HBASE-27871 Meta replication stuck forever if wal it's still reading gets rolled and deleted#5271
wchevreuil merged 1 commit into
apache:branch-2.5from
wchevreuil:HBASE-27871-branch-2.5

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

The base code for the original change is quite different between branch-2 and branch-2.5, mostly due to HBASE-27321, so cherry-picking the original branch-2 PR didn't work.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@wchevreuil
wchevreuilforce-pushed the HBASE-27871-branch-2.5 branch from 89148ce to 75df95aCompareJune 12, 2023 15:31
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

Apache-HBase commented Jun 14, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 28sbranch-2.5 passed
+1 💚compile2m 20sbranch-2.5 passed
+1 💚checkstyle0m 33sbranch-2.5 passed
+1 💚spotless0m 38sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 21sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile2m 22sthe patch passed
+1 💚javac2m 22sthe patch passed
+1 💚checkstyle0m 32sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 0sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚spotless0m 38spatch has no errors when running spotless:check.
+1 💚spotbugs1m 28sthe patch passed
_ Other Tests _
+1 💚asflicense0m 8sThe patch does not generate ASF License warnings.
29m 48s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5271
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 03c2027e2cd2 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7d7fbf3
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 14, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 17sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 9sbranch-2.5 passed
+1 💚compile0m 39sbranch-2.5 passed
+1 💚shadedjars4m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚shadedjars4m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit191m 59shbase-server in the patch passed.
211m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5271
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2835219317c0 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7d7fbf3
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/testReport/
Max. process+thread count4402 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 14, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 47sbranch-2.5 passed
+1 💚compile0m 45sbranch-2.5 passed
+1 💚shadedjars4m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sbranch-2.5 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 31sthe patch passed
+1 💚compile0m 46sthe patch passed
+1 💚javac0m 46sthe patch passed
+1 💚shadedjars4m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
-1 ❌unit206m 24shbase-server in the patch failed.
229m 12s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5271
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7a747e3ff4c6 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7d7fbf3
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/testReport/
Max. process+thread count4367 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5271/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil

wchevreuil commented Jun 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Latest UT failure is unrelated. I've noticed this UT is failing on all branches to me, locally (even master branch that doesn't include this change).

@wchevreuil
wchevreuil merged commit 91627ce into apache:branch-2.5Jun 15, 2023
wchevreuil added a commit that referenced this pull request Jun 20, 2023
@wchevreuil
HBASE-27871Meta replication stuck forever if wal it's still reading …
c74fadd
…gets rolled and deleted (#5271)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 91627ce)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@wchevreuilJenkins
HBASE-27871 Meta replication stuck forever if wal it's still reading …
3f9ea4b
…gets rolled and deleted (apache#5271)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 91627ce)
(cherry picked from commit c74fadd)
Change-Id: I47d1806482bb3ceef0402b2cc4f3b8c27252155d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wchevreuil@Apache-HBase@petersomogyi