Skip to content

HBASE-22881 Fix non-daemon threads in hbase server implementation - #536

Merged
saintstack merged 1 commit into
apache:branch-2from
sunhelly:HBASE-22881
Aug 28, 2019
Merged

HBASE-22881 Fix non-daemon threads in hbase server implementation#536
saintstack merged 1 commit into
apache:branch-2from
sunhelly:HBASE-22881

Conversation

@sunhelly

@sunhellysunhelly commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Aug 26, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec106Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep33Maven dependency ordering for branch
+1mvninstall364branch-2 passed
+1compile157branch-2 passed
+1checkstyle206branch-2 passed
+1shadedjars276branch has no errors when building our shaded downstream artifacts.
+1javadoc108branch-2 passed
0spotbugs100Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs419branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall323the patch passed
+1compile160the patch passed
+1javac160the patch passed
+1checkstyle27The patch passed checkstyle in hbase-common
+1checkstyle40The patch passed checkstyle in hbase-client
-1checkstyle97hbase-server: The patch generated 2 new + 153 unchanged - 4 fixed = 155 total (was 157)
+1checkstyle40hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1whitespace0The patch has no whitespace issues.
+1shadedjars286patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1035Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc127the patch passed
+1findbugs550the patch passed
_ Other Tests _
+1unit180hbase-common in the patch passed.
+1unit212hbase-client in the patch passed.
+1unit13065hbase-server in the patch passed.
+1unit329hbase-thrift in the patch passed.
+1asflicense130The patch does not generate ASF License warnings.
18779
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/artifact/out/Dockerfile
GITHUB PR#536
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux fcee61cff48f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revisionbranch-2 / fe689bf
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/testReport/
Max. process+thread count4617 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-server hbase-thrift U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 27, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec103Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall346branch-2 passed
+1compile152branch-2 passed
+1checkstyle198branch-2 passed
+1shadedjars289branch has no errors when building our shaded downstream artifacts.
+1javadoc114branch-2 passed
0spotbugs106Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs456branch-2 passed
_ Patch Compile Tests _
0mvndep15Maven dependency ordering for patch
+1mvninstall327the patch passed
+1compile142the patch passed
+1javac142the patch passed
+1checkstyle28The patch passed checkstyle in hbase-common
+1checkstyle39The patch passed checkstyle in hbase-client
-1checkstyle90hbase-server: The patch generated 2 new + 153 unchanged - 4 fixed = 155 total (was 157)
+1checkstyle42hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1whitespace0The patch has no whitespace issues.
+1shadedjars281patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1088Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc112the patch passed
+1findbugs520the patch passed
_ Other Tests _
+1unit179hbase-common in the patch passed.
+1unit215hbase-client in the patch passed.
-1unit16208hbase-server in the patch failed.
+1unit328hbase-thrift in the patch passed.
+1asflicense135The patch does not generate ASF License warnings.
21886
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectory
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/artifact/out/Dockerfile
GITHUB PR#536
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 01c0427b9533 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revisionbranch-2 / a386c6c
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/testReport/
Max. process+thread count4073 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-server hbase-thrift U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 27, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep14Maven dependency ordering for branch
+1mvninstall312branch-2 passed
+1compile139branch-2 passed
+1checkstyle184branch-2 passed
+1shadedjars251branch has no errors when building our shaded downstream artifacts.
+1javadoc114branch-2 passed
0spotbugs90Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs373branch-2 passed
_ Patch Compile Tests _
0mvndep18Maven dependency ordering for patch
+1mvninstall291the patch passed
+1compile139the patch passed
+1javac139the patch passed
+1checkstyle28The patch passed checkstyle in hbase-common
+1checkstyle37The patch passed checkstyle in hbase-client
+1checkstyle80hbase-server: The patch generated 0 new + 153 unchanged - 4 fixed = 153 total (was 157)
+1checkstyle39hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1whitespace1The patch has no whitespace issues.
+1shadedjars250patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck904Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc112the patch passed
+1findbugs413the patch passed
_ Other Tests _
+1unit176hbase-common in the patch passed.
+1unit206hbase-client in the patch passed.
-1unit9320hbase-server in the patch failed.
+1unit239hbase-thrift in the patch passed.
+1asflicense101The patch does not generate ASF License warnings.
14211
ReasonTests
Failed junit testshadoop.hbase.client.TestBlockEvictionFromClient
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/artifact/out/Dockerfile
GITHUB PR#536
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b9b542473dbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revisionbranch-2 / caba5cf
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/testReport/
Max. process+thread count4459 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-server hbase-thrift U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Aug 27, 2019
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Let me rerun build to make sure unrelated test failure.

@Apache-HBase

Apache-HBase commented Aug 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec129Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep21Maven dependency ordering for branch
+1mvninstall453branch-2 passed
+1compile173branch-2 passed
+1checkstyle210branch-2 passed
+1shadedjars325branch has no errors when building our shaded downstream artifacts.
+1javadoc114branch-2 passed
0spotbugs116Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs485branch-2 passed
_ Patch Compile Tests _
0mvndep16Maven dependency ordering for patch
+1mvninstall336the patch passed
+1compile143the patch passed
+1javac143the patch passed
+1checkstyle27The patch passed checkstyle in hbase-common
+1checkstyle37The patch passed checkstyle in hbase-client
+1checkstyle92hbase-server: The patch generated 0 new + 153 unchanged - 4 fixed = 153 total (was 157)
+1checkstyle43hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1whitespace0The patch has no whitespace issues.
+1shadedjars287patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1035Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc111the patch passed
+1findbugs479the patch passed
_ Other Tests _
+1unit185hbase-common in the patch passed.
+1unit229hbase-client in the patch passed.
-1unit14418hbase-server in the patch failed.
+1unit282hbase-thrift in the patch passed.
+1asflicense89The patch does not generate ASF License warnings.
20188
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/artifact/out/Dockerfile
GITHUB PR#536
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ad1346483137 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revisionbranch-2 / a18be19
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/testReport/
Max. process+thread count4351 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-server hbase-thrift U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 28, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec42Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall311branch-2 passed
+1compile138branch-2 passed
+1checkstyle181branch-2 passed
+1shadedjars249branch has no errors when building our shaded downstream artifacts.
+1javadoc114branch-2 passed
0spotbugs90Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs396branch-2 passed
_ Patch Compile Tests _
0mvndep17Maven dependency ordering for patch
+1mvninstall288the patch passed
+1compile136the patch passed
+1javac136the patch passed
+1checkstyle26The patch passed checkstyle in hbase-common
+1checkstyle36The patch passed checkstyle in hbase-client
+1checkstyle79hbase-server: The patch generated 0 new + 153 unchanged - 4 fixed = 153 total (was 157)
+1checkstyle39hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1whitespace0The patch has no whitespace issues.
+1shadedjars250patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck914Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1javadoc111the patch passed
+1findbugs424the patch passed
_ Other Tests _
+1unit175hbase-common in the patch passed.
+1unit217hbase-client in the patch passed.
+1unit8977hbase-server in the patch passed.
+1unit225hbase-thrift in the patch passed.
+1asflicense113The patch does not generate ASF License warnings.
13900
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/5/artifact/out/Dockerfile
GITHUB PR#536
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 16359bc54346 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revisionbranch-2 / 9b9f055
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/5/testReport/
Max. process+thread count4966 (vs. ulimit of 10000)
modulesC: hbase-common hbase-client hbase-server hbase-thrift U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit 84b4a61 into apache:branch-2Aug 28, 2019
asfgit pushed a commit that referenced this pull request Aug 28, 2019
@sunhelly@saintstack
HBASE-22881Fix non-daemon threads in hbase server implementation (#512…
7a90c1a
…) (#536)
Signed-off-by: stack <stack@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@sunhellyGuanghao Zhang
HBASE-22881 Fix non-daemon threads in hbase server implementation (ap…
b5f3118
…ache#512) (apache#536)
Signed-off-by: stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@sunhellyJenkins User
HBASE-22881 Fix non-daemon threads in hbase server implementation (ap…
7d4c818
…ache#512) (apache#536)
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 7a90c1a)
Change-Id: I262ff840f6e7c072306813f6c39a4e1456a64d59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunhelly@Apache-HBase@saintstack