HBASE-28089 Upgrade BouncyCastle to fix CVE-2023-33201 by NihalJain · Pull Request #5407 · apache/hbase

NihalJain · 2023-09-16T19:41:18Z

Upgrades to v1.76, i.e. the latest version
Replaces bcprov-jdk15on with bcprov-jdk18on and bcpkix-jdk15on with bcpkix-jdk18on
Excludes bcprov-jdk15on from everywhere else, to avoid conflicts with bcprov-jdk18on

NihalJain · 2023-09-16T19:48:42Z

First ran mvn dependency:tree > original-tree.txt without fix.
Output of grep 'bouncycastle' original-tree.txt is as follows:

$ grep 'bouncycastle' original-tree.txt
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcpkix-jdk15on:jar:1.70:test
[INFO] | \- org.bouncycastle:bcutil-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcpkix-jdk15on:jar:1.70:test
[INFO] | \- org.bouncycastle:bcutil-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:test

Next, ran mvn dependency:tree > fixed-tree.txt with fix.
Output of grep 'bouncycastle' fixed-tree.txt is as follows:

$ grep 'bouncycastle' fixed-tree.txt [INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcpkix-jdk18on:jar:1.76:test
[INFO] | \- org.bouncycastle:bcutil-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcpkix-jdk18on:jar:1.76:test
[INFO] | \- org.bouncycastle:bcutil-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.76:test

NihalJain · 2023-09-16T20:11:13Z

 <jcodings.version>1.0.57</jcodings.version>
 <spy.version>2.12.2</spy.version>
- <bouncycastle.version>1.70</bouncycastle.version>
+ <bouncycastle.version>1.76</bouncycastle.version>


should we add an enforcer rule to ban org.bouncycastle:*-jdk15on or is this fine?

Fixed, will undo this changes if others feel this is not needed.

Verified the ban plugin is working correctly by deleting the explicit exclusion from org.apache.directory.server:apacheds-protocol-ldap and letting org.bouncycastle:bcprov-jdk15on dependency come transitively.
Next ran mvn clean verify and following error is thrown (as expected):
. . [INFO] [INFO] --------------------< org.apache.hbase:hbase-http >--------------------- [INFO] Building Apache HBase - HTTP 4.0.0-alpha-1-SNAPSHOT [16/50] [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ hbase-http --- [INFO] Deleting /Users/nihaljain/code/os/hbase/hbase-http/target [INFO] [INFO] --- flatten-maven-plugin:1.3.0:clean (flatten.clean) @ hbase-http --- [INFO] Deleting /Users/nihaljain/code/os/hbase/hbase-http/.flattened-pom.xml [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:bsh-property (negate-license-bundles-property) @ hbase-http --- [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:regex-property (create-license-file-path-property) @ hbase-http --- [INFO] No match to regex '\\' found in '/Users/nihaljain/code/os/hbase/hbase-http/target/maven-shared-archive-resources/META-INF/LICENSE'. The initial value '/Users/nihaljain/code/os/temp/hbase/hbase-http/target/maven-shared-archive-resources/META-INF/LICENSE' is left as-is... [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (hadoop-profile-min-maven-min-java-banned-xerces) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-jsr305) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-scala) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-commons-logging) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-other-logging-framework) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-jetty) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-jersey) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-htrace) @ hbase-http --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-bouncycastle-jdk15on) @ hbase-http --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with message: Use org.bouncycastle:*-jdk18on instead Found Banned Dependency: org.bouncycastle:bcprov-jdk15on:jar:1.62 Use 'mvn dependency:tree' to locate the source of the banned dependencies. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache HBase 4.0.0-alpha-1-SNAPSHOT: [INFO] [INFO] Apache HBase ....................................... SUCCESS [ 2.544 s] [INFO] Apache HBase - Checkstyle .......................... SUCCESS [ 0.653 s] [INFO] Apache HBase - Annotations ......................... SUCCESS [ 0.916 s] [INFO] Apache HBase - Build Configuration ................. SUCCESS [ 0.165 s] [INFO] Apache HBase - Logging ............................. SUCCESS [ 1.251 s] [INFO] Apache HBase - Shaded Protocol ..................... SUCCESS [ 36.023 s] [INFO] Apache HBase - Common .............................. SUCCESS [ 9.505 s] [INFO] Apache HBase - Metrics API ......................... SUCCESS [ 1.602 s] [INFO] Apache HBase - Metrics Implementation .............. SUCCESS [ 1.717 s] [INFO] Apache HBase - Hadoop Compatibility ................ SUCCESS [ 3.534 s] [INFO] Apache HBase - Client .............................. SUCCESS [ 9.969 s] [INFO] Apache HBase - Zookeeper ........................... SUCCESS [ 2.485 s] [INFO] Apache HBase - Replication ......................... SUCCESS [ 2.522 s] [INFO] Apache HBase - Balancer ............................ SUCCESS [ 3.402 s] [INFO] Apache HBase - Resource Bundle ..................... SUCCESS [ 0.173 s] [INFO] Apache HBase - HTTP ................................ FAILURE [ 0.702 s] [INFO] Apache HBase - Asynchronous FileSystem ............. SKIPPED [INFO] Apache HBase - Procedure ........................... SKIPPED [INFO] Apache HBase - Server .............................. SKIPPED [INFO] Apache HBase - MapReduce ........................... SKIPPED [INFO] Apache HBase - Testing Util ........................ SKIPPED [INFO] Apache HBase - Thrift .............................. SKIPPED [INFO] Apache HBase - Shell ............................... SKIPPED [INFO] Apache HBase - Coprocessor Endpoint ................ SKIPPED [INFO] Apache HBase - Backup .............................. SKIPPED [INFO] Apache HBase - Integration Tests ................... SKIPPED [INFO] Apache HBase - Rest ................................ SKIPPED [INFO] Apache HBase - Examples ............................ SKIPPED [INFO] Apache HBase - Shaded .............................. SKIPPED [INFO] Apache HBase - Shaded - Client (with Hadoop bundled) SKIPPED [INFO] Apache HBase - Shaded - Client ..................... SKIPPED [INFO] Apache HBase - Shaded - MapReduce .................. SKIPPED [INFO] Apache HBase - External Block Cache ................ SKIPPED [INFO] Apache HBase - HBTop ............................... SKIPPED [INFO] Apache HBase - Compression ......................... SKIPPED [INFO] Apache HBase - Compression - Aircompressor ......... SKIPPED [INFO] Apache HBase - Compression - Brotli ................ SKIPPED [INFO] Apache HBase - Compression - LZ4 ................... SKIPPED [INFO] Apache HBase - Compression - Snappy ................ SKIPPED [INFO] Apache HBase - Compression - XZ .................... SKIPPED [INFO] Apache HBase - Compression - ZStandard ............. SKIPPED [INFO] Apache HBase - Assembly ............................ SKIPPED [INFO] Apache HBase - Shaded - Testing Util ............... SKIPPED [INFO] Apache HBase - Shaded - Testing Util Tester ........ SKIPPED [INFO] Apache HBase Shaded Packaging Invariants ........... SKIPPED [INFO] Apache HBase Shaded Packaging Invariants (with Hadoop bundled) SKIPPED [INFO] Apache HBase - Archetypes .......................... SKIPPED [INFO] Apache HBase - Exemplar for hbase-client archetype . SKIPPED [INFO] Apache HBase - Exemplar for hbase-shaded-client archetype SKIPPED [INFO] Apache HBase - Archetype builder ................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:18 min [INFO] Finished at: 2023-09-17T01:38:00+05:30 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce (banned-bouncycastle-jdk15on) on project hbase-http: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <args> -rf :hbase-http

Apache-HBase · 2023-09-16T20:24:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	4m 47s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	4m 49s	the patch passed
+1 💚	javac	4m 49s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 11s	The patch has no ill-formed XML file.
-1 ❌	hadoopcheck	8m 33s	The patch causes 10 errors with Hadoop v3.3.5.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	1m 11s	The patch does not generate ASF License warnings.
		29m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux 415abe4a7024 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a80b341`
Default Java	Eclipse Adoptium-11.0.17+8
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/artifact/yetus-general-check/output/patch-javac-3.3.5.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-17T00:38:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 48s	master passed
+1 💚	compile	1m 54s	master passed
+1 💚	shadedjars	4m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 58s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	1m 56s	the patch passed
+1 💚	javac	1m 56s	the patch passed
+1 💚	shadedjars	4m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 59s	the patch passed
		_ Other Tests _
-1 ❌	unit	249m 32s	root in the patch failed.
		283m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 90023c94cd4d 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a80b341`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/testReport/
Max. process+thread count	5435 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-17T02:09:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	1m 33s	master passed
+1 💚	shadedjars	5m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 26s	the patch passed
+1 💚	shadedjars	4m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 0s	the patch passed
		_ Other Tests _
-1 ❌	unit	343m 15s	root in the patch failed.
		373m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d3856da51417 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a80b341`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/testReport/
Max. process+thread count	5135 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-17T02:37:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	4m 48s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	4m 44s	the patch passed
+1 💚	javac	4m 44s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 10s	The patch has no ill-formed XML file.
-1 ❌	hadoopcheck	5m 43s	The patch causes 10 errors with Hadoop v3.3.5.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	1m 14s	The patch does not generate ASF License warnings.
		26m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux c5c02e8c2468 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a80b341`
Default Java	Eclipse Adoptium-11.0.17+8
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/artifact/yetus-general-check/output/patch-javac-3.3.5.txt
Max. process+thread count	65 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-17T08:24:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	1m 30s	master passed
+1 💚	shadedjars	4m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	1m 31s	the patch passed
+1 💚	javac	1m 31s	the patch passed
+1 💚	shadedjars	5m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 57s	the patch passed
		_ Other Tests _
-1 ❌	unit	343m 2s	root in the patch failed.
		373m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7a6a3d87afeb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a80b341`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/testReport/
Max. process+thread count	5182 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-17T08:41:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	1m 56s	master passed
+1 💚	shadedjars	4m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	1m 54s	the patch passed
+1 💚	javac	1m 54s	the patch passed
+1 💚	shadedjars	4m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 2s	the patch passed
		_ Other Tests _
-1 ❌	unit	354m 46s	root in the patch failed.
		390m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5ea51a9dc779 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a80b341`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/testReport/
Max. process+thread count	8136 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T06:35:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 35s	master passed
+1 💚	compile	4m 56s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	4m 54s	the patch passed
+1 💚	javac	4m 54s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 10s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	9m 49s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	1m 13s	The patch does not generate ASF License warnings.
		35m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux 331242d8ccba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `787d524`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T11:23:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	1m 57s	master passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	1m 58s	the patch passed
+1 💚	javac	1m 58s	the patch passed
+1 💚	shadedjars	4m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 3s	the patch passed
		_ Other Tests _
+1 💚	unit	287m 9s	root in the patch passed.
		322m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 437fc412bf0b 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `787d524`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/testReport/
Max. process+thread count	8294 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T12:17:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	4m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 53s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 57s	the patch passed
		_ Other Tests _
-1 ❌	unit	346m 38s	root in the patch failed.
		376m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a3bb1211e152 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `787d524`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/testReport/
Max. process+thread count	5219 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T21:39:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 35s	master passed
+1 💚	compile	4m 49s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	4m 51s	the patch passed
+1 💚	javac	4m 51s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 10s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	9m 25s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	1m 12s	The patch does not generate ASF License warnings.
		34m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux 012128a20d80 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94e4055`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-20T02:27:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 37s	master passed
+1 💚	compile	1m 55s	master passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	1m 55s	the patch passed
+1 💚	javac	1m 55s	the patch passed
+1 💚	shadedjars	4m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 1s	the patch passed
		_ Other Tests _
+1 💚	unit	286m 51s	root in the patch passed.
		322m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9f4b46f88472 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94e4055`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/testReport/
Max. process+thread count	8171 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-20T04:25:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	1m 58s	master passed
+1 💚	shadedjars	5m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 3s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	1m 31s	the patch passed
+1 💚	javac	1m 31s	the patch passed
+1 💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	407m 40s	root in the patch passed.
		440m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5407
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d6867f5357ca 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94e4055`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/testReport/
Max. process+thread count	8419 (vs. ulimit of 30000)
modules	C: hbase-common hbase-resource-bundle hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5407/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-09-20T05:09:19Z

All checks are green now, will merge this to master and branch-2 by EOD.
@Apache9 Please let me know if we want to pull this in branch-2.5, branch2.4 also.

Apache9 · 2023-09-20T06:30:22Z

This is a security fix so let's them in all active branches. All branch-2.x are jdk8+ only, so it should be fine.

Thanks.

NihalJain · 2023-09-20T06:58:24Z

Thanks for the quick heads up @Apache9.

- Upgrades to v1.76, i.e. the latest version - Replaces *-jdk15on with *-jdk18on - Excludes *-jdk15on from everywhere else, to avoid conflicts with *-jdk18on Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com> (cherry picked from commit 8b2ca86)

NihalJain · 2023-09-20T09:24:24Z

This change fixes https://github.com/apache/hbase/security/dependabot/56 !

- Upgrades to v1.76, i.e. the latest version - Replaces *-jdk15on with *-jdk18on - Excludes *-jdk15on from everywhere else, to avoid conflicts with *-jdk18on Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>

HBASE-28089 Upgrade BouncyCastle to fixCVE-2023-33201
0dee68f

NihalJain commented Sep 16, 2023
View reviewed changes

Address self review comments
cc33234

Apache9 approved these changes Sep 17, 2023
View reviewed changes

mnpoonia approved these changes Sep 18, 2023
View reviewed changes

Fix hadoop-3 check
455c460

NihalJain force-pushed the HBASE-28089 branch from f4bf177 to 455c460Compare September 19, 2023 05:58

NihalJain merged commit 8b2ca86 into apache:masterSep 20, 2023

NihalJain mentioned this pull request Sep 20, 2023
HBASE-28089 Upgrade BouncyCastle to fix CVE-2023-33201 #5415
Merged

This was referenced Sep 20, 2023
HBASE-28089 Upgrade BouncyCastle to fix CVE-2023-33201 #5422
Merged
HBASE-28089 Upgrade BouncyCastle to fix CVE-2023-33201 #5423
Merged

Uh oh!

Conversation

NihalJain commented Sep 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NihalJain commented Sep 16, 2023

Uh oh!

NihalJainSep 16, 2023

Choose a reason for hiding this comment

Uh oh!

NihalJainSep 16, 2023

Choose a reason for hiding this comment

Uh oh!

NihalJainSep 16, 2023

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Sep 16, 2023

Uh oh!

Apache-HBase commented Sep 17, 2023

Uh oh!

Apache-HBase commented Sep 17, 2023

Uh oh!

Apache-HBase commented Sep 17, 2023

Uh oh!

Apache-HBase commented Sep 17, 2023

Uh oh!

Apache-HBase commented Sep 17, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 20, 2023

Uh oh!

Apache-HBase commented Sep 20, 2023

Uh oh!

NihalJain commented Sep 20, 2023

Uh oh!

Apache9 commented Sep 20, 2023

Uh oh!

NihalJain commented Sep 20, 2023

Uh oh!

NihalJain commented Sep 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NihalJain commented Sep 16, 2023•
edited
Loading