HBASE-22138 Undo our direct dependence on protos in google.protobuf.A… by Apache9 · Pull Request #5411 · apache/hbase

Apache9 · 2023-09-19T08:01:03Z

…ny in Procedure.proto

Apache-HBase · 2023-09-19T08:21:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 30s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 46s	root in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-protocol-shaded in the patch passed.
		5m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit
uname	Linux 061bb6163afa 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `787d524`
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/testReport/
Max. process+thread count	46 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded U: hbase-protocol-shaded
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T08:21:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 10s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 50s	root in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 35s	hbase-protocol-shaded in the patch passed.
		6m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit
uname	Linux 02a2a416391b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `787d524`
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/testReport/
Max. process+thread count	75 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded U: hbase-protocol-shaded
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T08:22:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 47s	root in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hbaseprotoc	0m 43s	the patch passed
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		7m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	dupname asflicense cc hbaseprotoc spotless prototool
uname	Linux e620c5b7839b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `787d524`
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded U: hbase-protocol-shaded
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-09-19T08:52:58Z

Ah, the Any class has some help messages like pack and unpack, so can not be simply changed to a self defined protobuf message.

Although the two methods are not very hard to implement by our own, let me also relocate the proto files in HBASE-28096 and try again to see if we can rely on the relocated proto files. If not, will try to copy these two methods to our code bases too to fix the problem.

Thanks.

Apache-HBase · 2023-09-19T15:33:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	4m 57s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
-1 ❌	compile	1m 20s	root in the patch failed.
-0 ⚠️	cc	1m 20s	root in the patch failed.
-0 ⚠️	javac	1m 20s	root in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	9m 20s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	2m 51s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		32m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	dupname asflicense cc hbaseprotoc spotless prototool javac hadoopcheck xml compile
uname	Linux 1bef86855c98 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94e4055`
Default Java	Eclipse Adoptium-11.0.17+8
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/patch-compile-root.txt
cc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/patch-compile-root.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T19:32:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 3s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	1m 54s	the patch passed
+1 💚	javac	1m 54s	the patch passed
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 1s	the patch passed
		_ Other Tests _
-1 ❌	unit	242m 44s	root in the patch failed.
		271m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 0f070e5ed8d0 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94e4055`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/testReport/
Max. process+thread count	4957 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-19T21:30:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	1m 36s	master passed
+1 💚	shadedjars	4m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 15s	the patch passed
+1 💚	compile	1m 36s	the patch passed
+1 💚	javac	1m 36s	the patch passed
+1 💚	shadedjars	4m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	362m 54s	root in the patch passed.
		390m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 629bcd6ea2a5 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94e4055`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/testReport/
Max. process+thread count	8225 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-09-20T00:00:56Z

Ah, an error prone error...

Let me check what is the root cause, maybe the problem is we upgrade the error prone annotation version in hbase-thirdparty.

Apache9 · 2023-09-20T00:11:13Z

OK, I think the problem is I removed the exclusion for CanIgnoreReturnValue in protobuf so error prone is working now...

It is excluded in HBASE-18666, because we found a lot of error prone problems in HBASE-18656 which causes build to fail...

Anyway, we have done a bunch of error prone cleanup now, I think it is time to remove these exclusions and get all the checks back.

@saintstack FYI.

Apache9 · 2023-09-20T03:22:00Z

Oh, it is not related to the exclusive, there is no CanIgnoreReturnValue annotation for protobuf 3.21.x, it is introduced in 3.22.x, so we will hit this error.

Let me open an issue to fix the problem.

Apache-HBase · 2023-09-30T09:13:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	4m 42s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	4m 36s	the patch passed
+1 💚	cc	4m 36s	the patch passed
+1 💚	javac	4m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	9m 58s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	2m 49s	the patch passed
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		36m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	dupname asflicense cc hbaseprotoc spotless prototool javac hadoopcheck xml compile
uname	Linux 6f05e8e2932d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ff0f0e4`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-30T13:35:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 38s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s	master passed
+1 💚	compile	1m 44s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	1m 46s	the patch passed
+1 💚	javac	1m 46s	the patch passed
+1 💚	shadedjars	5m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 51s	the patch passed
		_ Other Tests _
+1 💚	unit	268m 0s	root in the patch passed.
		298m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux b4dfe2739407 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ff0f0e4`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/testReport/
Max. process+thread count	8194 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-30T14:35:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 15s	master passed
+1 💚	compile	1m 36s	master passed
+1 💚	shadedjars	4m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	4m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	the patch passed
		_ Other Tests _
-1 ❌	unit	331m 58s	root in the patch failed.
		358m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 4287d9f1e5bb 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ff0f0e4`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/testReport/
Max. process+thread count	5760 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk

Thanks for chasing down these issues @Apache9

…ny in Procedure.proto Also bump the hbase thirdparty dependency to 4.1.5

Apache-HBase · 2023-10-06T07:03:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	5m 54s	master passed
+1 💚	spotless	0m 54s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	5m 41s	the patch passed
+1 💚	cc	5m 41s	the patch passed
-0 ⚠️	javac	5m 41s	root generated 1 new + 909 unchanged - 1 fixed = 910 total (was 910)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	10m 37s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	2m 53s	the patch passed
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		42m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	dupname asflicense cc hbaseprotoc spotless prototool javac hadoopcheck xml compile
uname	Linux cf833c81bed2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7ec0176`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-06T11:12:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	5m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 54s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	1m 51s	the patch passed
+1 💚	javac	1m 51s	the patch passed
+1 💚	shadedjars	5m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 51s	the patch passed
		_ Other Tests _
-1 ❌	unit	262m 3s	root in the patch failed.
		292m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 78a156d55f9f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7ec0176`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/testReport/
Max. process+thread count	5312 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-06T13:32:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	1m 33s	master passed
+1 💚	shadedjars	4m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	1m 34s	the patch passed
+1 💚	javac	1m 34s	the patch passed
+1 💚	shadedjars	4m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	403m 34s	root in the patch passed.
		431m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5411
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux b2d13ca3d0c7 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7ec0176`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/testReport/
Max. process+thread count	7988 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…ny in Procedure.proto (#5411) Bump the hbase thirdparty dependency to 4.1.5 where we relocated the proto files in protobuf-java jar The generated protobuf messages are OK since we do not need to change any non generated java code Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit eb24001)

…ny in Procedure.proto (apache#5411) Bump the hbase thirdparty dependency to 4.1.5 where we relocated the proto files in protobuf-java jar The generated protobuf messages are OK since we do not need to change any non generated java code Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

… google.protobuf.Any in Procedure.proto (apache#5411) Bump the hbase thirdparty dependency to 4.1.5 where we relocated the proto files in protobuf-java jar The generated protobuf messages are OK since we do not need to change any non generated java code Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit eb24001)

…ny in Procedure.proto (apache#5411) Bump the hbase thirdparty dependency to 4.1.5 where we relocated the proto files in protobuf-java jar The generated protobuf messages are OK since we do not need to change any non generated java code Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit eb24001) Change-Id: If058beda9d6521dd43220d8aac9bcf75cb05563a

Apache9 self-assigned this Sep 19, 2023

Apache9 marked this pull request as draft September 19, 2023 08:53

Apache9 force-pushed the HBASE-22138 branch from 006fd32 to cdcb076Compare September 19, 2023 14:52

Apache9 force-pushed the HBASE-22138 branch from cdcb076 to a0fb94fCompare September 30, 2023 08:34

ndimiduk approved these changes Oct 4, 2023
View reviewed changes

NihalJain approved these changes Oct 4, 2023
View reviewed changes

HBASE-22138 Undo our direct dependence on protos in google.protobuf.A…
5836091
…ny in Procedure.proto Also bump the hbase thirdparty dependency to 4.1.5

Apache9 force-pushed the HBASE-22138 branch from a0fb94f to 5836091Compare October 6, 2023 06:14

Apache9 marked this pull request as ready for review October 6, 2023 06:17

Apache9 merged commit eb24001 into apache:masterOct 6, 2023

Uh oh!

Conversation

Apache9 commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache9 commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache-HBase commented Sep 19, 2023

Uh oh!

Apache9 commented Sep 20, 2023

Uh oh!

Apache9 commented Sep 20, 2023

Uh oh!

Apache9 commented Sep 20, 2023

Uh oh!

Apache-HBase commented Sep 30, 2023

Uh oh!

Apache-HBase commented Sep 30, 2023

Uh oh!

Apache-HBase commented Sep 30, 2023

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Oct 6, 2023

Uh oh!

Apache-HBase commented Oct 6, 2023

Uh oh!

Apache-HBase commented Oct 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants