Skip to content

[branch-2 ] HBASE-27981 Add connection and request attributes to slow log (#5335) - #5412

Merged
bbeaudreault merged 1 commit into
apache:branch-2from
HubSpot:HBASE-27981-branch-2
Sep 19, 2023
Merged

[branch-2 ] HBASE-27981 Add connection and request attributes to slow log (#5335)#5412
bbeaudreault merged 1 commit into
apache:branch-2from
HubSpot:HBASE-27981-branch-2

Conversation

@rmdmattingly

Copy link
Copy Markdown
Contributor

Master PR: #5335

In HBASE-27657 we added support for request and connection attributes. By pushing this metadata to the slow log we can provide more flexible and meaningful visibility for those debugging via the slow log.

cc @bbeaudreault

…#5335)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 50sbranch-2 passed
+1 💚compile3m 49sbranch-2 passed
+1 💚checkstyle1m 1sbranch-2 passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 13sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile3m 43sthe patch passed
+1 💚cc3m 43sthe patch passed
+1 💚javac3m 43sthe patch passed
+1 💚checkstyle1m 0sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 6sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚hbaseprotoc1m 19sthe patch passed
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs4m 36sthe patch passed
_ Other Tests _
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
43m 47s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5412
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux a96e6465f62b 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / e8cbc3f
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 14sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 22sbranch-2 passed
+1 💚compile1m 39sbranch-2 passed
+1 💚shadedjars4m 45sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 33sthe patch passed
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
+1 💚shadedjars4m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 50sthe patch passed
_ Other Tests _
+1 💚unit0m 29shbase-protocol-shaded in the patch passed.
+1 💚unit8m 5shbase-client in the patch passed.
+1 💚unit204m 4shbase-server in the patch passed.
238m 26s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5412
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b21f5f62a8b9 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / e8cbc3f
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/testReport/
Max. process+thread count4251 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile2m 9sbranch-2 passed
+1 💚shadedjars5m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 20sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars5m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sthe patch passed
_ Other Tests _
+1 💚unit0m 36shbase-protocol-shaded in the patch passed.
+1 💚unit7m 29shbase-client in the patch passed.
+1 💚unit238m 45shbase-server in the patch passed.
276m 42s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5412
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 601d21b1baaf 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / e8cbc3f
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/testReport/
Max. process+thread count4497 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5412/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreault merged commit 4bb7409 into apache:branch-2Sep 19, 2023
@bbeaudreault
bbeaudreault deleted the HBASE-27981-branch-2 branch September 19, 2023 19:57
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Sep 19, 2023
…o slow log (apache#5412)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rmdmattingly@Apache-HBase@bbeaudreault